Received: by 2002:a05:7412:8d11:b0:fa:4934:9f with SMTP id bj17csp170450rdb; Sun, 14 Jan 2024 11:10:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IF9keOLRbmjZhmtyjZgizcGUuEWupcQGIRYsaH2YPrgJNk/v3RqwP+k7LyLbCcxklBrfpKf X-Received: by 2002:a05:6402:3104:b0:559:329b:221f with SMTP id dc4-20020a056402310400b00559329b221fmr426207edb.42.1705259409672; Sun, 14 Jan 2024 11:10:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1705259409; cv=none; d=google.com; s=arc-20160816; b=LqTE3cVXWlIEVO/nAwOoa9jRc8Fa8rn09WAqgyD+k1j2IqIrZyygiMX+S0Khq/clt8 s3fWPBeiWVgPeO/bcMn2jU0B4AZTnlPbRuOyZlOaIlBnzTVxCQbt5E4jEANhzNVy5Mv+ vZKkLn6SLk4wsHU7nLraZ/7/YbH/IluabMqO1/3b8oWDd1cSGbh8tDX4uZm/uu6OjxIt R/3rYwipaAoa7CUJY3pAylMmEzj4PDGtw6t0jlVOh9cWWIo9J3cHdBAG7LnvAbuuScnR eU6pcdFV8rBT8Zvu6jVM9B2qnpJL1zugbgsclHQSe7Uy1XSwFFnuD5Sr0UB5hsQyScUt rmPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=date:message-id:user-agent:cc:to:references:in-reply-to:from :subject:content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature; bh=Ustk86qJf44jEvKgjyZRKuP2z5vrccXljH3vDN2LwTs=; fh=WLR/EgGP8LnoRETZ+PoieReSVWIjBN6GPR456gdEBDI=; b=u27oPzwAz2w/qAD9GCvpE7ejk8VfbkKXRjiOqy7IG2/A5qXFFGB9Ew+9WsPtrfk1Dx ShfrF5duioNxU9spxp1SmsmYroGbBrYjUhosRUj+cQKG/UFxTZPKnvBEbX9hLE9s5p0X Tbs7jRPKOqPGk4bx9A0o7TzcWYN6o4ydxol/zAQyO+9OsaHmzZ71xavl8NvCtV76BHlD 00R/3RfOf5MmgOMZyLZQbeTHOJmHDN8bJtXHhsWRACojXOMGMrrMgapHR1tz5AeHY/3s aifyhhfSe4CX8vzMT5uWX/Lo1QSBQXN0FCENAZaXnm9CTIzd4GPPDs/TvcWQdTU6Zk5v IF5A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=TW1MSQCi; spf=pass (google.com: domain of linux-wireless+bounces-1893-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-wireless+bounces-1893-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id e5-20020a50fb85000000b0054c6ee88805si3292525edq.649.2024.01.14.11.10.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Jan 2024 11:10:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-1893-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=TW1MSQCi; spf=pass (google.com: domain of linux-wireless+bounces-1893-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-wireless+bounces-1893-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 524D71F2139B for ; Sun, 14 Jan 2024 19:10:09 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E968D10796; Sun, 14 Jan 2024 19:10:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="TW1MSQCi" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE2AD101D2 for ; Sun, 14 Jan 2024 19:10:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E25EEC433C7; Sun, 14 Jan 2024 19:10:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705259404; bh=sfiQpP7+TDJLTjHNyWr8gkkCmSbQwzFSm+rs+Rr8xm0=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=TW1MSQCi0shp9NgzbBR8PjuoXarhIHO7RSYyOYdQznkk5Pn2iNctWgOTo4O0tOTAI 1aYY87AXN5Hfvf3eF3FquVx+oqkSLXbe3fyMEBOaNtniYWq9mkqFdB3z8K1zdrne5W EMcRUMvdmb43ooZ3vVsglBt19SiGW9WWwxMIEOC1wrgadDnLLy/0nc0oPkHklxvJSc mc+wWs8HW96PuCOVxr3jjWTGpCvELdNCPuA+wElaKq+sT1c2ImWIeGGVfCP6XFmzcc BhsyivQ721h+Qixd2SiAnPk/4FWzu8x7zwGanKJA3uOQnYDRi6Ex84XeUNhBLRMxOR ZDz3kQ3PdlNdA== Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v3 1/2] wifi: rtl8xxxu: add cancel_work_sync() for c2hcmd_work From: Kalle Valo In-Reply-To: <20240111163628.320697-2-martin.kaistra@linutronix.de> References: <20240111163628.320697-2-martin.kaistra@linutronix.de> To: Martin Kaistra Cc: linux-wireless@vger.kernel.org, Jes Sorensen , Ping-Ke Shih , Bitterblue Smith , Sebastian Andrzej Siewior User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <170525940101.1549893.9097725363739190681.kvalo@kernel.org> Date: Sun, 14 Jan 2024 19:10:02 +0000 (UTC) Martin Kaistra wrote: > The workqueue might still be running, when the driver is stopped. To > avoid a use-after-free, call cancel_work_sync() in rtl8xxxu_stop(). > > Fixes: e542e66b7c2e ("rtl8xxxu: add bluetooth co-existence support for single antenna") > Signed-off-by: Martin Kaistra > Reviewed-by: Ping-Ke Shih 2 patches applied to wireless-next.git, thanks. 1213acb478a7 wifi: rtl8xxxu: add cancel_work_sync() for c2hcmd_work ece90a862232 wifi: rtl8xxxu: enable channel switch support -- https://patchwork.kernel.org/project/linux-wireless/patch/20240111163628.320697-2-martin.kaistra@linutronix.de/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches