Received-SPF: pass (google.com: domain of linux-wireless+bounces-1919-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <ef5ea65e80aa0eb8d73d37505a26d2dbc32c2e0f.camel@sipsolutions.net>
Subject: Re: [PATCH] wifi: ath11k: rely on mac80211 debugfs handling for vif
From: Benjamin Berg <benjamin@sipsolutions.net>
To: Kalle Valo <kvalo@kernel.org>
Cc: linux-wireless@vger.kernel.org, lenb@kernel.org,
 ath11k@lists.infradead.org
Date: Mon, 15 Jan 2024 11:36:11 +0100
In-Reply-To: <87a5pb9cxp.fsf@kernel.org>
References: <20240111170629.1257217-1-benjamin@sipsolutions.net>
	 <877ckfip1g.fsf@kernel.org> <87a5pb9cxp.fsf@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
Precedence: bulk
MIME-Version: 1.0

On Fri, 2024-01-12 at 10:24 +0200, Kalle Valo wrote:
> Kalle Valo <kvalo@kernel.org> writes:
>=20
> > benjamin@sipsolutions.net=C2=A0writes:
> >=20
> > > From: Benjamin Berg <benjamin.berg@intel.com>
> > >=20
> > > mac80211 started to delete debugfs entries in certain cases,
> > > causing a
> > > conflict between ath11k also trying to delete them later on. Fix
> > > this by
> > > relying on mac80211 to delete the entries when appropriate and
> > > adding
> > > them from the vif_add_debugfs handler.
> > >=20
> > > Fixes: 0a3d898ee9a8 ("wifi: mac80211: add/remove driver debugfs
> > > entries as appropriate")
> > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=3D218364
> > > Signed-off-by: Benjamin Berg <benjamin.berg@intel.com>
> >=20
> > Adding ath11k list so that the whole team sees this.
>=20
> Thanks, this patch passes my ath11k tests and I don't see crashes
> anymore. But what about other drivers, can we trust that they don't
> have
> similar problems? I'm just wondering should we consider reverting the
> mac80211 commit for the time being?

Good question.

I did have a look originally and I just went over all drivers (i.e.
debugfs_remove calls). None of these seem to be vif related. As such, I
would say we could just go ahead with this patch and leave in the fix.

That said, we could also revert 0a3d898ee9a8 for now. I don't think
that has any severe side effects other than a warning from debugfs
reappearing again for iwlwifi.

Benjamin