Received-SPF: pass (google.com: domain of linux-wireless+bounces-1939-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Kalle Valo <kvalo@kernel.org>
To: Karthikeyan Periyasamy <quic_periyasa@quicinc.com>
Cc: <ath12k@lists.infradead.org>,  <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 2/2] wifi: ath12k: Introduce the container for mac80211 hw
References: <20240109051252.3325106-1-quic_periyasa@quicinc.com>
	<20240109051252.3325106-3-quic_periyasa@quicinc.com>
	<87mst67ge4.fsf@kernel.org>
Date: Mon, 15 Jan 2024 18:05:53 +0200
In-Reply-To: <87mst67ge4.fsf@kernel.org> (Kalle Valo's message of "Mon, 15 Jan
	2024 17:41:55 +0200")
Message-ID: <87il3u7fa6.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

Kalle Valo <kvalo@kernel.org> writes:

> Karthikeyan Periyasamy <quic_periyasa@quicinc.com> writes:
>
>> To support multi link operation, we need to combine all the link/pdev
>> under a single wiphy. This avoids the overhead of synchronization
>> across multiple hardware instances in both the cfg80211 and mac80211
>> layers. Currently, each link/pdev is registered as separate wiphy,
>> tightly coupled with link/pdev/radio (ar) structure. To enable single
>> wiphy registration within the chip, we decouple the wiphy data entity from
>> the link/pdev/radio (ar) structure and move it under the chip (ab)
>> structure with a new data container (ath12k_hw) structure. This approach
>> improves scalability for future multi link operation support.
>>
>> 		mac80211 hw private data structure diagram
>> 		------------------------------------------
>>
>> 	Now						After
>>
>>  +---------------------+                          +---------------------+
>>  |mac80211 hw priv data|                          |mac80211 hw priv data|
>>  |                     |                          |                     |
>>  |                     |                          |                     |
>>  |                     |                          |                     |
>>  |                     |                          |   ath12k_hw (ah)    |
>>  |                     |                          |                     |
>>  |                     |  +------------------->   |                     |
>>  |    ath12k (ar)      |                          |   +-------------+   |
>>  |                     |                          |   |             |   |
>>  |                     |                          |   | ath12k (ar) |   |
>>  |                     |                          |   |             |   |
>>  |                     |                          |   |             |   |
>>  |                     |                          |   +-------------+   |
>>  |                     |                          |                     |
>>  |                     |                          |                     |
>>  +---------------------+                          +---------------------+
>>
>> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
>> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3
>>
>> Signed-off-by: Karthikeyan Periyasamy <quic_periyasa@quicinc.com>
>
> [...]
>
>> @@ -3790,6 +3831,10 @@ static int ath12k_mac_op_sta_state(struct ieee80211_hw *hw,
>>  	     new_state == IEEE80211_STA_NOTEXIST))
>>  		cancel_work_sync(&arsta->update_wk);
>>  
>> +	mutex_lock(&ah->conf_mutex);
>> +
>> +	ar = ath12k_ah_to_ar(ah);
>> +
>>  	mutex_lock(&ar->conf_mutex);
>
> Do we really need two mutexes? I don't see any analysis about that. And
> even if we do, I feel that it should be added in a separate patch.

Sorry, wrong version. I'll comment on v2.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches