Received-SPF: pass (google.com: domain of linux-wireless+bounces-1946-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <88ad7e8849f7b29826ddf922734997d73539b21d.camel@sipsolutions.net>
Subject: Re: [PATCH 5/8] wifi: mac80211: disallow drivers with HT wider than
 HE
From: Johannes Berg <johannes@sipsolutions.net>
To: Ben Greear <greearb@candelatech.com>, Kalle Valo <kvalo@kernel.org>, 
	Miri Korenblit <miriam.rachel.korenblit@intel.com>
Cc: linux-wireless@vger.kernel.org, Gregory Greenman
	 <gregory.greenman@intel.com>
Date: Mon, 15 Jan 2024 23:00:17 +0100
In-Reply-To: <b1046a3b-8c29-aa64-2954-adec6c5d9bc9@candelatech.com>
References: <20240111161746.3978601-1-miriam.rachel.korenblit@intel.com>
	 <20240111181514.da15fe3214d2.I4df51ad2f4c844615c168bf9bdb498925b3c77d4@changeid>
	 <87wmsehf3d.fsf@kernel.org>
	 <aae05a63171cf0f3c81dedc24d3b0a558ce530f5.camel@sipsolutions.net>
	 <b1046a3b-8c29-aa64-2954-adec6c5d9bc9@candelatech.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.3 (3.50.3-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

On Fri, 2024-01-12 at 11:58 -0800, Ben Greear wrote:
>=20
> I tried backporting this patch into my 6.7 tree.  An mtk7915 radio system=
 blows up badly
> in this case.  Likely this is mt76 bug, but also...it used to work and th=
e crash doesn't
> make it very obvious that the above code is to blame.

Yeah, hence my comment about kernel developers hopefully being able to
figure it out :-)

> mt7915e 0000:06:00.0: mt7915_register_device failed, ret: -22
> mt7915e 0000:06:00.0: mt7915_pci_probe had error on try 3/3, ret: -22

Felix says this kind of retry logic doesn't exist upstream, maybe you
have some delta in your tree that's making it crash?

Also, from what he says and looking at the code, it should register with
HE 40 MHz capability set whenever has_he=3D=3Dtrue, so also here, do you
have any non-upstream changes that could affect it?

johannes