Received-SPF: pass (google.com: domain of linux-wireless+bounces-1959-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <915171c5-7176-f7be-fd7f-f748917dfbf0@quicinc.com>
Date: Tue, 16 Jan 2024 10:20:38 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH 00/10] wifi: ath12k: Refactor mac80211 callback operation
 functions
Content-Language: en-US
To: Kalle Valo <kvalo@kernel.org>
CC: <ath12k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
References: <20240103063731.3356060-1-quic_periyasa@quicinc.com>
 <87r0ii7goe.fsf@kernel.org>
From: Karthikeyan Periyasamy <quic_periyasa@quicinc.com>
In-Reply-To: <87r0ii7goe.fsf@kernel.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


On 1/15/2024 9:05 PM, Kalle Valo wrote:
> Karthikeyan Periyasamy <quic_periyasa@quicinc.com> writes:
>
>> Currently, the existing mac80211 callback functions are defined assuming
>> each link/radio is represented by a single mac80211 hw. In order to
>> support multi link operation (MLO), need to move from the multi wiphy
>> model to a single wiphy model. However, the single wiphy model allows
>> multiple link/radio to be exposed by the same mac80211 hw. Therefore, we
>> need to separate the link/radio specific handling within the mac80211
>> callback operations. This way, the callback can be extended to support
>> multiple link/radio in the future.
>>
>> 			Current Multi wiphy Model
>>
>> +---------------+            +---------------+            +-------------+
>> |  Mac80211 hw  |            | Mac80211 hw   |            |Mac80211 hw  |
>> |  private data |            | private data  |            |private data |
>> |               |            |               |            |             |
>> |               |            |               |            |             |
>> |               |            |               |            |             |
>> |   ar (2GHz)   |            |   ar (5GHz)   |            |  ar (6GHz)  |
>> |               |            |               |            |             |
>> |               |            |               |            |             |
>> |               |            |               |            |             |
>> +---------------+            +---------------+            +-------------+
>>
>>
>>
>>
>> 			  Single wiphy Model
>>
>>                             +--------------+
>>                             | Mac80211 hw  |
>>                             | private data |
>>                             |              |
>>                             |ath12k hw (ah)|
>>                             | +----------+ |
>>                             | |ar (2GHz) | |
>>                             | +----------+ |
>>                             | |          | |
>>                             | |ar (5GHz) | |
>>                             | +----------+ |
>>                             | |          | |
>>                             | |ar (6GHz) | |
>>                             | |          | |
>>                             | +----------+ |
>>                             +--------------+
>>
>>
>> Karthikeyan Periyasamy (10):
>>    wifi: ath12k: Refactor mac callback of config
>>    wifi: ath12k: Refactor mac callback of bss info changed
>>    wifi: ath12k: Refactor mac callback of conf tx
>>    wifi: ath12k: Refactor mac callback of start
>>    wifi: ath12k: Refactor mac callback of stop
>>    wifi: ath12k: Refactor mac callback of update vif offload
>>    wifi: ath12k: Refactor mac callback of configure filter
>>    wifi: ath12k: Refactor mac callback of ampdu action
>>    wifi: ath12k: Refactor mac callback of flush
>>    wifi: ath12k: Refactor start vdev delay function
> In the pending branch I renamed the patch titles like this, an example:
>
> wifi: ath12k: refactor ath12k_mac_op_conf_tx()
>
> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=bdb399b467daacabdc0e2127e03874d399f17a38

Looks fine to me.


Thanks,

Karthikeyan