Received-SPF: pass (google.com: domain of linux-wireless+bounces-1971-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Kalle Valo <kvalo@kernel.org>
To: Martin Kaistra <martin.kaistra@linutronix.de>
Cc: linux-wireless@vger.kernel.org,  Jes Sorensen <Jes.Sorensen@gmail.com>,
  Ping-Ke Shih <pkshih@realtek.com>,  Bitterblue Smith
 <rtl8821cerfe2@gmail.com>,  Sebastian Andrzej Siewior
 <bigeasy@linutronix.de>
Subject: Re: [PATCH] wifi: rtl8xxxu: add missing number of sec cam entries
 for all variants
References: <20240116095001.399500-1-martin.kaistra@linutronix.de>
Date: Tue, 16 Jan 2024 13:13:42 +0200
In-Reply-To: <20240116095001.399500-1-martin.kaistra@linutronix.de> (Martin
	Kaistra's message of "Tue, 16 Jan 2024 10:50:01 +0100")
Message-ID: <87y1cpfs49.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

Martin Kaistra <martin.kaistra@linutronix.de> writes:

> Commit b837f78fbffa ("wifi: rtl8xxxu: add hw crypto support for AP
> mode") introduced max_sec_cam_num as a member of rtl8xxxu_fileops.
> It was missed to set this number for all variants except 8188f, which
> caused rtl8xxxu_get_free_sec_cam() to always return 0.
>
> Fix it by adding the numbers for all variants. The values are taken from
> the vendor drivers and rtlwifi.

Does this fix a user visible regression? It would be good to add that to
the commit message. I can do it, just let me know what to add.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches