Received-SPF: pass (google.com: domain of linux-wireless+bounces-1972-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <7b45d86b-d5ed-4e1a-b514-7388211d7860@linutronix.de>
Date: Tue, 16 Jan 2024 12:28:34 +0100
Precedence: bulk
MIME-Version: 1.0
Subject: Re: [PATCH] wifi: rtl8xxxu: add missing number of sec cam entries for
 all variants
Content-Language: de-DE
To: Kalle Valo <kvalo@kernel.org>
Cc: linux-wireless@vger.kernel.org, Jes Sorensen <Jes.Sorensen@gmail.com>,
 Ping-Ke Shih <pkshih@realtek.com>, Bitterblue Smith
 <rtl8821cerfe2@gmail.com>, Sebastian Andrzej Siewior <bigeasy@linutronix.de>
References: <20240116095001.399500-1-martin.kaistra@linutronix.de>
 <87y1cpfs49.fsf@kernel.org>
From: Martin Kaistra <martin.kaistra@linutronix.de>
In-Reply-To: <87y1cpfs49.fsf@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Kalle,

Am 16.01.24 um 12:13 schrieb Kalle Valo:
> Martin Kaistra <martin.kaistra@linutronix.de> writes:
> 
>> Commit b837f78fbffa ("wifi: rtl8xxxu: add hw crypto support for AP
>> mode") introduced max_sec_cam_num as a member of rtl8xxxu_fileops.
>> It was missed to set this number for all variants except 8188f, which
>> caused rtl8xxxu_get_free_sec_cam() to always return 0.
>>
>> Fix it by adding the numbers for all variants. The values are taken from
>> the vendor drivers and rtlwifi.
> 
> Does this fix a user visible regression? It would be good to add that to
> the commit message. I can do it, just let me know what to add.
> 

Yes, traffic to encrypted networks was broken for all hw variants except 8188f. 
This was reported by Zenm Chen in [1].

Maybe you could add something like:
[..]
caused rtl8xxxu_get_free_sec_cam() to always return 0 and therefore breaking 
encrypted traffic.

[1] https://lore.kernel.org/linux-wireless/20240111163603.2325-1-zenmchen@gmail.com/