Received-SPF: pass (google.com: domain of linux-wireless+bounces-1980-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Zenm Chen <zenmchen@gmail.com>
To: linux-wireless@vger.kernel.org
Cc: martin.kaistra@linutronix.de,
	Jes.Sorensen@gmail.com,
	bigeasy@linutronix.de,
	kvalo@kernel.org,
	pkshih@realtek.com,
	rtl8821cerfe2@gmail.com,
	zenmchen@gmail.com
Subject: RE: [PATCH] wifi: rtl8xxxu: add missing number of sec cam entries for all variants
Date: Tue, 16 Jan 2024 21:46:42 +0800
Message-ID: <20240116134642.2898-1-zenmchen@gmail.com>
In-Reply-To: <20240116095001.399500-1-martin.kaistra@linutronix.de>
References: <20240116095001.399500-1-martin.kaistra@linutronix.de>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

>Hi Zenm,
>
>On Tue, 2024-01-16 at 10:50 +0100, Martin Kaistra wrote:
>> 
>> Commit b837f78fbffa ("wifi: rtl8xxxu: add hw crypto support for AP
>> mode") introduced max_sec_cam_num as a member of rtl8xxxu_fileops.
>> It was missed to set this number for all variants except 8188f, which
>> caused rtl8xxxu_get_free_sec_cam() to always return 0.
>> 
>> Fix it by adding the numbers for all variants. The values are taken from
>> the vendor drivers and rtlwifi.
>> 
>> Fixes: b837f78fbffa ("wifi: rtl8xxxu: add hw crypto support for AP mode")
>> Signed-off-by: Martin Kaistra <martin.kaistra@linutronix.de>
>> 
>
> Could you please try if this patch can fix your problem? 
>

Yes, my devices work fine now, thank you and Martin for fixing this!

devices tested: MERCUSYS MW300UM (RTL8192EU)
                MERCURY  MW310UH (RTL8192FU)

> Thanks
> Ping-Ke