Received-SPF: pass (google.com: domain of linux-wireless+bounces-2069-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <36972ff5-0c48-4bd2-8f9a-9649bfa24225@lexina.in>
 <11c7333aee0d45fd9fbfc65f6e2a3aa2@realtek.com> <216e8522-fa56-4d54-ae32-74c6008a2075@lexina.in>
 <0969b1ca039e423dbcc41de18db023c6@realtek.com> <cc54a8b2-2fea-406c-8d4a-24ddfd34f983@lexina.in>
 <0be52db8941c4e609bfda6c69a14184e@realtek.com> <CAFBinCDT2Pj_BYqCtk+i7y8LPU2qwah-4Scdq29ONBqs3wt0pQ@mail.gmail.com>
 <8192e59807e14525b821317a5f550ea4@realtek.com>
In-Reply-To: <8192e59807e14525b821317a5f550ea4@realtek.com>
From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Date: Tue, 16 Jan 2024 23:07:20 +0100
Message-ID: <CAFBinCBf2XM-W8-_YEGXydy4kLHHar7Fv5=GoKddjE9f0hTkAw@mail.gmail.com>
Subject: Re: rtw88: rtl8822cs AP mode not working
To: Ping-Ke Shih <pkshih@realtek.com>, Viacheslav <adeep@lexina.in>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>, 
	=?UTF-8?Q?Jernej_=C5=A0krabec?= <jernej.skrabec@gmail.com>
Content-Type: multipart/mixed; boundary="0000000000005b144c060f175b28"

--0000000000005b144c060f175b28
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Ping-Ke and Viacheslav,

On Mon, Jan 15, 2024 at 3:17=E2=80=AFAM Ping-Ke Shih <pkshih@realtek.com> w=
rote:
[...]
> > > I don't have this kind of wifi cards, could you help to check if AP m=
ode
> > > works in your side?
> > I'll check that in the next few days.
AP mode is also not working for me, I get the same problem as
Viacheslav reported.

> > Also I'm wondering where code enables beacons (is it
> > rtw_core_enable_beacon() or is there another relevant function?).
> > Knowing that would be helpful to analyze this further.
>
> The main function to get and set beacon template to firmware is
> rtw_fw_download_rsvd_page(). The basic concept is to put beacon frame via
> qsel=3DBCN to a special TX FIFO area called "reserve page", and then
> hardware/firmware will send beacon in interval of 100ms.
Thanks for the explanation - that helped me find a better starting point!

I didn't have much time in the past few days, but I have some findings
and questions:
1) I found the following comment/code in the downstream driver [0]:
/*
 * Disable Hw protection for a time which revserd for Hw sending beacon.
 * Fix download reserved page packet fail that access collision with
the protection time.
 */
val8 =3D rtw_read8(adapter, REG_BCN_CTRL_8822C);
restore[1] =3D val8;
val8 &=3D ~BIT_EN_BCN_FUNCTION_8822C;
val8 |=3D BIT_DIS_TSF_UDT_8822C;
rtw_write8(adapter, REG_BCN_CTRL_8822C, val8);

This is not part of the upstream rtw88 driver, so I made a patch and
attached it.
Unfortunately it doesn't fix the problem.

2) PCI is the only HCI which does not need the checksum in the
pkt_Info (USB and SDIO need the checksum).
The checksum is added by rtw_tx_fill_txdesc_checksum() which is only
called in usb.c and sdio.c.
My understanding is that for reserved pages we can have more than one
pkt_info in the buffer (my starting point for this thought is
rtw_fill_rsvd_page_desc() from fw.c).
In usb.c and sdio.c we're only calculating the checksum for the very
first pkt_info, not for any subsequent ones (I didn't even know that
it's possible to have more than one pkt_Info outside of RX and TX
aggregation).
However, it seems that the downstream code calculates the TX checksum
for *all* pkt_info in the buffer, see [1]
This code is missing from rtw88 at the moment. Since I didn't have
time I did not try to implement this yet.

3) Has anybody tried AP mode with rtw88 on a (supported) USB chipset?
If my thought (from #2) is correct then AP mode would show the same
problems there.

4) Viacheslav, I think you previously mentioned that you did a bit of
work with the downstream driver.
It would be awesome if you could also take a look at the rtw88 and
downstream driver code and start comparing them (logic that's
different or completely missing from rtw88 is suspicious).


Best regards,
Martin


[0] https://github.com/chewitt/RTL8822CS/blob/60cd82134d63aa9436b43c42933a8=
6d6e5a191ba/hal/rtl8822c/rtl8822c_ops.c#L1885-L1893
[1] https://github.com/chewitt/RTL8822CS/blob/main/hal/rtl8822c/sdio/rtl882=
2cs_xmit.c#L311-L312

--0000000000005b144c060f175b28
Content-Type: text/x-patch; charset="US-ASCII"; 
	name="rtw_fw_write_data_rsvd_page-write-REG_FWHW_TXQ_CTRL_2.diff"
Content-Disposition: attachment; 
	filename="rtw_fw_write_data_rsvd_page-write-REG_FWHW_TXQ_CTRL_2.diff"
Content-Transfer-Encoding: base64
Content-ID: <f_lrgwbgai0>
X-Attachment-Id: f_lrgwbgai0

ZGlmZiAtLWdpdCBhL2RyaXZlcnMvbmV0L3dpcmVsZXNzL3JlYWx0ZWsvcnR3ODgvZncuYyBiL2Ry
aXZlcnMvbmV0L3dpcmVsZXNzL3JlYWx0ZWsvcnR3ODgvZncuYwppbmRleCAzZjAzN2RkY2VjZjEu
LjIyZDI2NjViOWY1OCAxMDA2NDQKLS0tIGEvZHJpdmVycy9uZXQvd2lyZWxlc3MvcmVhbHRlay9y
dHc4OC9mdy5jCisrKyBiL2RyaXZlcnMvbmV0L3dpcmVsZXNzL3JlYWx0ZWsvcnR3ODgvZncuYwpA
QCAtMTQzNyw3ICsxNDM3LDcgQEAgdm9pZCBydHdfYWRkX3JzdmRfcGFnZV9zdGEoc3RydWN0IHJ0
d19kZXYgKnJ0d2RldiwKIGludCBydHdfZndfd3JpdGVfZGF0YV9yc3ZkX3BhZ2Uoc3RydWN0IHJ0
d19kZXYgKnJ0d2RldiwgdTE2IHBnX2FkZHIsCiAJCQkJdTggKmJ1ZiwgdTMyIHNpemUpCiB7Ci0J
dTggYmNrcFsyXTsKKwl1OCBiY2twWzNdOwogCXU4IHZhbDsKIAl1MTYgcnN2ZF9wZ19oZWFkOwog
CXUzMiBiY25fdmFsaWRfYWRkcjsKQEAgLTE0NjIsOCArMTQ2MiwxNCBAQCBpbnQgcnR3X2Z3X3dy
aXRlX2RhdGFfcnN2ZF9wYWdlKHN0cnVjdCBydHdfZGV2ICpydHdkZXYsIHUxNiBwZ19hZGRyLAog
CXZhbCB8PSBCSVRfRU5TV0JDTiA+PiA4OwogCXJ0d193cml0ZTgocnR3ZGV2LCBSRUdfQ1IgKyAx
LCB2YWwpOwogCi0JdmFsID0gcnR3X3JlYWQ4KHJ0d2RldiwgUkVHX0ZXSFdfVFhRX0NUUkwgKyAy
KTsKKwl2YWwgPSBydHdfcmVhZDgocnR3ZGV2LCBSRUdfQkNOX0NUUkwpOwogCWJja3BbMV0gPSB2
YWw7CisJdmFsICY9IH5CSVRfRU5fQkNOX0ZVTkNUSU9OOworCXZhbCB8PSBCSVRfRElTX1RTRl9V
RFQ7CisJcnR3X3dyaXRlOChydHdkZXYsIFJFR19CQ05fQ1RSTCwgdmFsKTsKKworCXZhbCA9IHJ0
d19yZWFkOChydHdkZXYsIFJFR19GV0hXX1RYUV9DVFJMICsgMik7CisJYmNrcFsyXSA9IHZhbDsK
IAl2YWwgJj0gfihCSVRfRU5fQkNOUV9ETCA+PiAxNik7CiAJcnR3X3dyaXRlOChydHdkZXYsIFJF
R19GV0hXX1RYUV9DVFJMICsgMiwgdmFsKTsKIApAQCAtMTQ5MCw3ICsxNDk2LDggQEAgaW50IHJ0
d19md193cml0ZV9kYXRhX3JzdmRfcGFnZShzdHJ1Y3QgcnR3X2RldiAqcnR3ZGV2LCB1MTYgcGdf
YWRkciwKIAlyc3ZkX3BnX2hlYWQgPSBydHdkZXYtPmZpZm8ucnN2ZF9ib3VuZGFyeTsKIAlydHdf
d3JpdGUxNihydHdkZXYsIFJFR19GSUZPUEFHRV9DVFJMXzIsCiAJCSAgICByc3ZkX3BnX2hlYWQg
fCBCSVRfQkNOX1ZBTElEX1YxKTsKLQlydHdfd3JpdGU4KHJ0d2RldiwgUkVHX0ZXSFdfVFhRX0NU
UkwgKyAyLCBiY2twWzFdKTsKKwlydHdfd3JpdGU4KHJ0d2RldiwgUkVHX0ZXSFdfVFhRX0NUUkwg
KyAyLCBiY2twWzJdKTsKKwlydHdfd3JpdGU4KHJ0d2RldiwgUkVHX0JDTl9DVFJMLCBiY2twWzFd
KTsKIAlydHdfd3JpdGU4KHJ0d2RldiwgUkVHX0NSICsgMSwgYmNrcFswXSk7CiAKIAlyZXR1cm4g
cmV0Owo=
--0000000000005b144c060f175b28--