Received-SPF: pass (google.com: domain of linux-wireless+bounces-2073-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <045bf616-f69b-4253-92ce-05744d72b084@amd.com>
Date: Tue, 16 Jan 2024 22:18:14 -0600
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/2] wifi: mt76: mt7921: Disable powersaving by default
Content-Language: en-US
To: James Prestwood <prestwoj@gmail.com>, Ben Greear
 <greearb@candelatech.com>, Lorenzo Bianconi <lorenzo@kernel.org>,
 Kalle Valo <kvalo@kernel.org>
Cc: Felix Fietkau <nbd@nbd.name>, Ryder Lee <ryder.lee@mediatek.com>,
 Shayne Chen <shayne.chen@mediatek.com>, Sean Wang <sean.wang@mediatek.com>,
 Matthias Brugger <matthias.bgg@gmail.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>,
 Deren Wu <deren.wu@mediatek.com>, Ming Yen Hsieh
 <mingyen.hsieh@mediatek.com>,
 "open list:MEDIATEK MT76 WIRELESS LAN DRIVER"
 <linux-wireless@vger.kernel.org>,
 "open list:ARM/Mediatek SoC support" <linux-kernel@vger.kernel.org>,
 "moderated list:ARM/Mediatek SoC support"
 <linux-mediatek@lists.infradead.org>, Sultan Alsawaf <sultan@kerneltoast.com>
References: <20231212090852.162787-1-mario.limonciello@amd.com>
 <874jgmnud8.fsf@kernel.org> <ZXmxD1foASMaCDIe@lore-desk>
 <d92c081e-47dd-5c57-a6f1-bd72b2748141@candelatech.com>
 <1ef12773-74ca-489c-b36b-d3cf7da22c43@amd.com>
 <e0fbe9cb-22de-462f-9123-14a220d5a9c6@gmail.com>
From: Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <e0fbe9cb-22de-462f-9123-14a220d5a9c6@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RDR0UVloZ052Tm4yR2s2Q2VtNWEwQ2ZOd0JJMjZxN3dRTURUb0FuKzhVR0JW?=
 =?utf-8?B?S0djWlZBM2kxV1EvbW1yclhIUmpLUjBObXI2UlZTcHpielc0S2RySGhDUHov?=
 =?utf-8?B?bnlCNllTM0dYaS8yMzFzNWs1UE9oR1UxV2tNSGR3N2RqbmV0RDFwejVOa0hH?=
 =?utf-8?B?RlBKa01KZSt6bnEyaVdMR3VyU0JtK05LWkJ4OUttRlJjbFpNOFFBQThSdmpR?=
 =?utf-8?B?YWFJNHJ3c3cxV1NSTHk0STdQVGlCRGVIUGFkRms3U2MxMnl2ZFdUTWhraXU5?=
 =?utf-8?B?bWxUYTE1by9TVHc3d1RBUVUwcklVbHUxWXlUVWlFakVFSEUwSnZpWHV1SURv?=
 =?utf-8?B?dnp1bTZMbWwyZkw3K1hPYmtpOUhwTWVUZlRrNkdLV282bS9ueXIvWUdhZm9J?=
 =?utf-8?B?S09YTGExZkFZS3hQRFIwS1JOY1FNazZtMjg5MGZNdHVXK3dEcFRyQ1NFUEpv?=
 =?utf-8?B?SVhBcmpsejBTVlBBcnJ2VXRNYmxCSHdzdngwRFluYmZPNHAraVkzOCtrTWFm?=
 =?utf-8?B?SGRxbmJRS2ZuUkJYM3B5d0MreFNPV1NlZ003MTFmSldieHVCbGROLytlOFZU?=
 =?utf-8?B?blRqSUlJeU12ZmVZd0Zwc1VNU2JLb0ZiQlZqeG4xWjlQWXRCeDZscW51MGd2?=
 =?utf-8?B?N25KUUloOFBMWmRVSmZFVXR0b3c0WnVidjlidE8rSks5UVR2dzNVcW9HSml1?=
 =?utf-8?B?alhKZ0Q5SmQvT0s5bFlTZlc5WVI2b042TG1MMXdWNmt5SVFWNkROMjloU3hh?=
 =?utf-8?B?OGw0YWl6Z0M0a3JzZ1Y2QkhPY3dOQis3eFVBOWFJL01NZmg2SG5NeklRZUJ4?=
 =?utf-8?B?bHlUekN6R082RGJBL2pNWXlzRk15aU41QlUrcERaeWlyTlJ3d2FxTnVwTXJ0?=
 =?utf-8?B?bTZhUUZNVGlTVlk1VTRnMXcyNU9BZStKa24wNzltZi9WU2dRNkk0dmIzd2NZ?=
 =?utf-8?B?Q2M1V084TFJzL2VTaHlzQWw3QkFPWlZMdytYVXdHRzRZQ2dTT0toU3N3MnFW?=
 =?utf-8?B?S1RBaFZlWVdQajZDeXJsVlBlT1JzeXBKZU1pTDdZVkV4RmliWTM0aEZhclB0?=
 =?utf-8?B?SVVTRFFuSEdMU2pDVVAzYitTa3VKQTFZZ2N3Z2R1d1NURHBwbmthTWdRSDZv?=
 =?utf-8?B?TFd4TXk5ZTAyeFQrZlU0bFVYVjlTSmVHSG5NMXlyTVlNbngrMzJSRVhGaUxZ?=
 =?utf-8?B?S01PMllJMTJUVXRzb1VvTmxubWUyRkVYdHZBQTFqaWpMSU9mN1ZTckZQVzRx?=
 =?utf-8?B?SEtlQ29oYlBHeHFBbm1iUFBYMHFKV2dicG15VW1ndWZsQS8zd0g2bXQvWkFP?=
 =?utf-8?B?czZ0KzhZNGlaQThLKzl2ZDR2SXRsNDhtQnV2VFlVd01sTlF1cUpGMkVySlh6?=
 =?utf-8?B?cG1TOWxMQXVvZnpsOExrc1FLcnlBUVdpKytRZWpwbE51WmJvQnBIRTJEdTdJ?=
 =?utf-8?B?QjRzMTN4MGNmZzJoWWxOSFdWRm5jNFVRemw0YlU2V2FkN2Y3OUg4WkR2Vkpv?=
 =?utf-8?B?K0I2MEpINnE5Szgxb1JEOXVhZnJwMDZ0SVlhSVRQYzFWbzdEeU4xeno1MHpM?=
 =?utf-8?B?TVlIcTRwM0xsTk1SaElYTzR3OHhydUpReGpsWFJhZStsenRHL01SMjVDSE5K?=
 =?utf-8?B?WnFFVUpuQ1k2R2V5ak5TM2lOdS84UXlaMEg5SENsYnduZlFIY3QwWmhISm1V?=
 =?utf-8?B?ZCtGdTVmekY5akFPcW4wOURiMGYrTy9BSG4xMzVKUU9vekl5cXNKR2lDZzZs?=
 =?utf-8?B?cmxyS3oycXR0Tkw5MXY4dHlrdThUa1BSKzdQM25KT2kwV3JvNlRkMy95aytL?=
 =?utf-8?B?VjFqMmtCV1Z0UWpWRVcweSsrWWtieTdvWUl1cmtIZWZ5TEx5WWs4VmF3L3FQ?=
 =?utf-8?B?ZW1xT09peEg1ZzAxOEVxZjVWV1JFSjI1NjhSQ2FCM0JOQlpPeFVISXpnYWZV?=
 =?utf-8?B?cVI0bDJFVFRYSklGaG5ueVFRdHNqazBZbWtVS1BLN0YzalIzTDB4TytZcGRL?=
 =?utf-8?B?d2puUjRhaTVVWGJLdWwwazVaazdtLzB1SWNhamRBc1Z1c3MrckhVWjFFallr?=
 =?utf-8?B?VWlEVzF6ZGU5amZzR20rckVPbmZYOUF3WVVSWFJzRWxsblYyaXdpM3YwT3lI?=
 =?utf-8?Q?Q3QlrHh+KngpF0SBgkDQa3mHP?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 44743a7b-c107-4006-9aca-08dc1713551a
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jan 2024 04:18:18.0764
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PBF5b1fdCbNhyEwIGWhUCwYm892srfy6kNU2Tdp+myjgjH9w6nuD8YHrI+ldOoNu3FPpqrmDPm0Kst+og+S+bg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4495

On 12/14/2023 06:39, James Prestwood wrote:
> On 12/13/23 11:27, Mario Limonciello wrote:
>> On 12/13/2023 08:45, Ben Greear wrote:
>>> On 12/13/23 5:26 AM, Lorenzo Bianconi wrote:
>>>>> Mario Limonciello <mario.limonciello@amd.com> writes:
>>>>>
>>>>>> Several users have reported awful latency when powersaving is enabled
>>>>>> with certain access point combinations.
>>>>>
>>>>> What APs are these exactly? In the past 802.11 Power Save Mode was
>>>>> challenging due to badly behaving APs. But nowadays with so many 
>>>>> mobile
>>>>> devices in the market I would assume that APs work a lot better. It
>>>>> would be best to investigate the issues in detail and try to fix 
>>>>> them in
>>>>> mt76, assuming the bugs are in mt76 driver or firmware.
>>>>>
>>>>>> It's also reported that the powersaving feature doesn't provide an
>>>>>> ample enough savings to justify being enabled by default with these
>>>>>> issues.
>>>>>
>>>>> Any numbers or how was this concluded?
>>>>>
>>>>>> Introduce a module parameter that would control the power saving
>>>>>> behavior.  Set it to default as disabled. This mirrors what some 
>>>>>> other
>>>>>> WLAN drivers like iwlwifi do.
>>>>>
>>>>> We have already several ways to control 802.11 power save mode:
>>>>>
>>>>> * NL80211_CMD_SET_POWER_SAVE (for example used by 'iw set power_save')
>>>>>
>>>>> * CONFIG_CFG80211_DEFAULT_PS (for kernel level default)
>>>>>
>>>>> * WIPHY_FLAG_PS_ON_BY_DEFAULT (for the driver to control the 
>>>>> default setting)
>>>>>
>>>>> Adding module parameters as a fourth method sounds confusing so not
>>>>> really a fan of this. And the bar is quite high for adding new module
>>>>> parameters anyway.
>>>>
>>>> agree, I think we do not need a new parameter for this, just use the 
>>>> current
>>>> APIs.
>>>
>>> Is there a convenient way for a user to make any of those options 
>>> above stick through
>>> reboots?
>>>
>>> To me, the ability to set system defaults through reboots is a nice 
>>> feature of
>>> module options.
>>>
>>> Thanks,
>>> Ben
>>>
>>
>> Some userspace has the ability to do this.  For example in Network 
>> Manager:
>>
>> https://unix.stackexchange.com/questions/595116/wi-fi-powersaving-in-networkmanager
> 
> And recently added to IWD for this very reason, there are no decent ways 
> to persist between reboots (except when using NM).
> 
> https://git.kernel.org/pub/scm/network/wireless/iwd.git/commit/?id=29edb1626d88bb713db71f7b374d8f24832fd94f
> 
> Thanks,
> 
> James
> 

All,

Just wanted to update you that I looked at this issue again over the 
holidays and it's fixed by upgrading the linux-firmware for the mt7921 
that was submitted in late November.

I get the correct performance and latency without modifying power saving 
now on my Unifi access points.

Thanks,