Received-SPF: pass (google.com: domain of linux-wireless+bounces-2100-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <6fc593ee-0b4f-4116-a30a-94ba375bba4f@gmail.com>
Date: Wed, 17 Jan 2024 06:25:38 -0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: ath11k and vfio-pci support
Content-Language: en-US
To: Kalle Valo <kvalo@kernel.org>
Cc: Baochen Qiang <quic_bqiang@quicinc.com>, linux-wireless@vger.kernel.org,
 ath11k@lists.infradead.org
References: <adcb785e-4dc7-4c4a-b341-d53b72e13467@gmail.com>
 <8734v5zhol.fsf@kernel.org> <87fa5220-6fd9-433d-879b-c55ac67a0748@gmail.com>
 <87r0ipcn7j.fsf@kernel.org> <356e0b05-f396-4ad7-9b29-c492b54af834@gmail.com>
 <26119c3f-9012-47bb-948e-7e976d4773a7@quicinc.com>
 <87mstccmk6.fsf@kernel.org> <df9fd970-5af3-468c-b1f1-18f91215cf44@gmail.com>
 <8734v4auc4.fsf@kernel.org> <e8878979-1f3f-4635-a716-9ac381c617d9@gmail.com>
 <285b84d0-229c-4c83-a7d6-4c3c23139597@quicinc.com>
 <4607fb37-8227-49a3-9e8c-10c9b117ec7b@gmail.com>
 <3d22a730-aee5-4f2a-9ddc-b4b5bd4d62fe@quicinc.com>
 <ee0280fd-032c-4f45-a3f9-50d96d8bed6d@gmail.com>
 <16cfd010-b62d-4385-92d1-002820a8db38@quicinc.com>
 <cdec259a-b779-4856-8585-f285179e3671@gmail.com> <87cyu05b4j.fsf@kernel.org>
From: James Prestwood <prestwoj@gmail.com>
In-Reply-To: <87cyu05b4j.fsf@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Kalle,

On 1/17/24 5:43 AM, Kalle Valo wrote:
> James Prestwood <prestwoj@gmail.com> writes:
>
>>>> I don't see anything in the dmesg logs, or in lspci etc.
>>>>
>>> fee00578 is the physical MSI vector so I got it using lspci in host, see
>>> ...
>>>          Capabilities: [50] MSI: Enable+ Count=1/32 Maskable+ 64bit-
>>>                  Address: fee00578  Data: 0000
>>>                  Masking: fffffffe  Pending: 00000000
>>> ...
>> Mine looks like this:
>>
>> ...
>>
>>      Capabilities: [50] MSI: Enable- Count=1/32 Maskable+ 64bit-
>>          Address: 00000000  Data: 0000
>>          Masking: 00000000  Pending: 00000000
> And that lspci output is from the host (not the guest)?

Yes, that is on the host. On the guest I have:

Capabilities: [50] MSI: Enable+ Count=1/32 Maskable+ 64bit-
         Address: fee01004  Data: 0028
         Masking: fffffffe  Pending: 00000000

And I just tried those values, i.e:

-       ath11k_dbg(ab, ATH11K_DBG_PCI, "msi base data is %d\n", 
ab->pci.msi.ep_base_data);
+        ab->pci.msi.addr_hi = 0;
+        ab->pci.msi.addr_lo = 0xfee01004;
+        ath11k_dbg(ab, ATH11K_DBG_PCI, "msi addr hi 0x%x lo 0x%x base 
data is %d\n",
+                   ab->pci.msi.addr_hi,
+                   ab->pci.msi.addr_lo,
+                   ab->pci.msi.ep_base_data);

Though wasn't sure for "Data"/ep_base_data since the kernel uses a u32 
but lspci appears to show a 16 bit value. I tried:

+       ab_pci->ab->pci.msi.ep_base_data = 0;
+       ab_pci->ab->pci.msi.ep_base_data = 0x0028;
+       ab_pci->ab->pci.msi.ep_base_data = 0x0028000;

(maybe thats entirely the wrong change)

>