Received: by 2002:a05:7412:ba23:b0:fa:4c10:6cad with SMTP id jp35csp228897rdb; Thu, 18 Jan 2024 01:35:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IGHdPdmXlyStGN6h+YC2Br+KD2gZ/dcmQ3z0r1W6KiSxTBzNp/YHi3iGHKGEjjbMLwZCalc X-Received: by 2002:a4a:bd03:0:b0:599:4819:5c1d with SMTP id n3-20020a4abd03000000b0059948195c1dmr79327oop.3.1705570503412; Thu, 18 Jan 2024 01:35:03 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705570503; cv=pass; d=google.com; s=arc-20160816; b=oD3XTWE7JvExJkXQfyRc8l00suCX2Xl/vwDGs1PMNo2MtMp+6lhccG1bHbxdubfAUe 3sRNDOWxCxkxjyJx/fdo4q96HI5L/IaeyXbp+4/z4o2idggSAy/K0QZANzSsA0RcNS94 iEkWYIbtFU1MLtepFKerPw8mwriAPRTuGRyzC22OY5GygSUNzKzRvraf2qY1bunsc++q +UhuxV90l9SeYRJOpy0BUNJRyL0i5dK1MAyyStuDlOitNFCjHKYx/Ns2/Jy23TDhCqz+ 8JeLHIbbZnk5EaO5zqKMWePjxOeBR8lFz62tQmfDiWLQMi7oSxWr3BhvhyUVLXq/bWag z6tg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=date:message-id:user-agent:cc:to:references:in-reply-to:from :subject:content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature; bh=hNZf5Nt8BA3rvYHJshCs1b7liatbu6Ty9co/auNTi2Q=; fh=KLYZroe+hx7PXWHWhHVHm3kyvVqb0KvAA/sfTDNY4Ss=; b=O4iUUES2W3agaM+AWwmLmpNbYMjxr8AIpC+sP9Kl8UmqMn8Jyp9cWG/SeO+UCl7Kyp jcXV3Voc8S4bdCuLKEwNaen1JO2YjM2YQAJrg26RxfFjx/Y65GHzpTFjBSO7cwpYJTRe hFgyq8GR6eAHt5GsQZqB10Z/mxIP4LUZ6cEGMNsxhcWfxXWO5DBp36yAYTzl/2rh0Bg5 S0iU4AKSrdZR5/xtl/3+jjPhBIBgMa7urFnrPtHYtl/mloQF5+qJmUJGSwfzi827O+g8 DJP5QX2HLlbKE6F+X1/fgBBNK+yH2JD/8EPbGvf1TPotwlJdWPPBM3mnxqF38QmKVLQV QoWA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=UxS26i8o; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-2156-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-2156-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id n5-20020a634005000000b005c6183ccab2si1139627pga.630.2024.01.18.01.35.03 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jan 2024 01:35:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-2156-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=UxS26i8o; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-2156-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-2156-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id CFF982844AF for ; Thu, 18 Jan 2024 09:35:02 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E22481F92D; Thu, 18 Jan 2024 09:34:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="UxS26i8o" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE82E1F922 for ; Thu, 18 Jan 2024 09:34:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705570498; cv=none; b=SBzwvhsD2XG5UifVoz75cqUGAggFnfBs25ub6KWMEaiSoP0xyRXkRGmXf96nA1GiFnyvAhUPVsDct7oAZIxu3qsvhp/JSj0xUIK22kIR/2BGKA51RBojQrDST561exxlpVbdhjA1lW8rcXr95CykB0hs1qSNUqqHts8ejlnySUA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705570498; c=relaxed/simple; bh=jjGU8SBil3ovYJwjQeXIPrHs0IgBjQKjzMR3H0g5mIA=; h=Received:DKIM-Signature:Content-Type:MIME-Version: Content-Transfer-Encoding:Subject:From:In-Reply-To:References:To: Cc:User-Agent:Message-ID:Date; b=PVDIUDaBal9NdSvd94lYXTFbOvtaolx+UqI2r/FpNChh9fjnAjdUh7YvcKsKX8zVHKK+NuhyISzRY9Rx8G6gUvIw5BWcQEAvsQ0elacCmwAfXwwobHwfN/DqLbSegFBVkDZf2u+grBhFhEKl23PYydNrz1/3WyPlMvKxjfD92YA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=UxS26i8o; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 44B2BC433C7; Thu, 18 Jan 2024 09:34:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705570498; bh=jjGU8SBil3ovYJwjQeXIPrHs0IgBjQKjzMR3H0g5mIA=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=UxS26i8oEafF6v6f9UQBU9QLq1Co0ALiRgIetm5wJdA28COlcJp6HAAOS8U91nwej 4hVRrfr7QAqRy8VJ9yo3WZ0BESFDJ9fjyRoAY8hYfQ2Unr/c/FQMq38zLE0IoYSUTl PA3chjKvmGtKWieNIAn2OzBhvx169rH0XAGww7H/eRFNt7t/TEfaBNZ5FJ85O1TqMN ul8PKSyJ/BuFTjeWRbIKSJp5ZvsNEICSzyPPHUT3/YD+fqHmRMB2ZHhpfs5BNsePWt PlOvhrRuzdCFHHhLM2V5sPc5l1RjISnQeGw54rII5maakMiqCNdFQmWoCpAMdRz9rD eWqOLVgpLA3jw== Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wifi: rtlwifi: rtl8192de: Don't read register in _rtl92de_query_rxphystatus From: Kalle Valo In-Reply-To: <19a3e023-0eaa-4096-9f78-a2c8e909cb54@gmail.com> References: <19a3e023-0eaa-4096-9f78-a2c8e909cb54@gmail.com> To: Bitterblue Smith Cc: "linux-wireless@vger.kernel.org" , Ping-Ke Shih , Larry Finger User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <170557049546.2797779.11828652028578423722.kvalo@kernel.org> Date: Thu, 18 Jan 2024 09:34:57 +0000 (UTC) Bitterblue Smith wrote: > Instead of reading bit 9 of RFPGA0_XA_HSSIPARAMETER2 every time a frame > is received, just use rtlphy->cck_high_power, which is initialised in > _rtl92d_phy_bb_config(). That bit never changes anyway. > > With this change _rtl92de_query_rxphystatus() can be shared with the > upcoming USB driver. The USB driver can't read registers in this > function because register reading can sleep. > > Compile tested only. > > Signed-off-by: Bitterblue Smith > Acked-by: Ping-Ke Shih Patch applied to wireless-next.git, thanks. 0635d73d85c1 wifi: rtlwifi: rtl8192de: Don't read register in _rtl92de_query_rxphystatus -- https://patchwork.kernel.org/project/linux-wireless/patch/19a3e023-0eaa-4096-9f78-a2c8e909cb54@gmail.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches