Received: by 2002:a05:7412:ba23:b0:fa:4c10:6cad with SMTP id jp35csp277453rdb; Thu, 18 Jan 2024 03:22:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IE2hT27e8Zr6TpTjshDXMx42KV3qeuCijcXRR3vxNbs27C7NUZ+FrLeOXBiUTCTp5OLKQKE X-Received: by 2002:a54:4d06:0:b0:3bd:946d:486c with SMTP id v6-20020a544d06000000b003bd946d486cmr792772oix.47.1705576965133; Thu, 18 Jan 2024 03:22:45 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705576965; cv=pass; d=google.com; s=arc-20160816; b=UqDWi8W6sKCDPuf93jkZbo/dLGt4EpexdvwxKABDJ4rlI91kDZmVhOCa+SqTa4CLAU vun2sA/BTUUjmEQA4IVr31R7BL9GwFavYPLW2IM19hCFS/sXG+kGNAyQ5d4S6jZZNZd6 gwBpjlHrd/2ktmDVgoVygMaYuJUseG18Rs9zibh7n+5uAXaVYj92/mbmT5IPfvX3598u wlPibwnlDmWREmGw4M4JYZe/vK7kEpj9sdpqfx5bKfgElykEWRtsWAzBVLEm1DbL3a0o irX9USdzOkgP8XdFXGLV76+rnB9kWx2iDaoEYyb3Z9h79xcpgH0pY79l9DW5Vicm1wRs RFow== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=date:message-id:user-agent:cc:to:references:in-reply-to:from :subject:content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature; bh=W9+xxfRnqIQXTRSbj0DzMELqMAuTy8wLtsSpFrwfmQg=; fh=8Ly+PLcRZbvKdCwj/FVl4897GG6JjeyeUk4ZS97zOlw=; b=ojOsLSZGut3zUNQorp3z4BtNyP4EdRe9pA8WCtgw0fsb5Iv4aREuG0kJBgaU/l/dhW u5GxCK48FOeMgfSGosjcBXhgv/uMkdqNzpJ7twZ4Dnc95DCCkBWlN6MTdWUxoP9VrhQE qBmrV+jyxMfpDNKERVkhBYDL+ABpEhYv3Sd702ojLOOOv1JcM31HtYg8r2aSEwnIH5xN 6zfiKYfUL2YONMzwiJz7GpJS3i8JnE3tZ4/g3x+RatBMiWNwIP+g3Qm1wHIthQPrix0A 1ejXoqMxvMzRtVCAGwghjDTbDGFujxwZqqeg7tVGQ8A/rLfnVLhUcM1ttsXE5Mrx4YWW TAOA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="FMfy/uiT"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-2167-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-wireless+bounces-2167-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id f11-20020a6547cb000000b005cdf7b05f36si1269893pgs.615.2024.01.18.03.22.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jan 2024 03:22:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-2167-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="FMfy/uiT"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-2167-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-wireless+bounces-2167-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id F27A62858CC for ; Thu, 18 Jan 2024 11:22:42 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 95DD623776; Thu, 18 Jan 2024 11:22:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FMfy/uiT" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 725DE2376E for ; Thu, 18 Jan 2024 11:22:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705576957; cv=none; b=HQPQrjuTRy1pXJCJfOf+zH8D80z2KGQhGg/UNnE0jQw3koBbR5rUZiPipclQ38RBzm52JJOGiq9rRs5WuiWOfbssnHVgMCRSSJnzxpfVfpx7Q6Pjy2ArQFSbrLxzW1GgMhSYtyXPEe/vX/q54ZrxoHJvD1Wo0xs7Kz7K/S19/zI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705576957; c=relaxed/simple; bh=kJ1+f7gxO+YiffBwWp80CS+iQ2pr1dNPzRuJutrSncw=; h=Received:DKIM-Signature:Content-Type:MIME-Version: Content-Transfer-Encoding:Subject:From:In-Reply-To:References:To: Cc:User-Agent:Message-ID:Date; b=Rl2egGGqm2JBj7rX6/UVpYqWFDSZ3zL7+pvwYp2zTP37S3kDqbCidMpTZ11HNDQ5XDItbu+GuM/WoHv306bZQBVjVBxkU34Ee5wPW6VLVsxc+JHCulz2w/DO9HGizlZphcpEcROPEvzbhjcAUlCc+WC6nNt4j5RCRWwDHpKfqxs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FMfy/uiT; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7EDCEC433F1; Thu, 18 Jan 2024 11:22:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705576956; bh=kJ1+f7gxO+YiffBwWp80CS+iQ2pr1dNPzRuJutrSncw=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=FMfy/uiT10fpLfocn9g1Q3dR6DKc1zcG2S+QTcMpqO9ZL+1nY0QAfqt96YTh7ZLSF JDYuEmEd+3TlU1482LOFZeZ9h+yGPLFtGfDHVPIyTV8hU2ISbX4OEc1eBCzueSzMXr NY7f0rS8SSIG3NkMpPrPhmbyzjUlSJdDhWn2QHtO5Bl5vewhISKuXN2epwoP1xGGl6 fDBMAVFPb3QIIhLiSjANwFcB8uIs5+trlgQ5qZCTZv8N8/5LKtO9kp7X1F7wocrn/1 n5fVPMorMrsoSMKFRs7OgQqMRqHUe7WljNjAHNy3GY3e5x7WsikYRis5nOM0k1wI9h g0/yYXjuc/Fyg== Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH 1/2] [v2] wifi: brcmfmac: handle possible completion timeouts From: Kalle Valo In-Reply-To: <20230614075848.80536-1-dmantipov@yandex.ru> References: <20230614075848.80536-1-dmantipov@yandex.ru> To: Dmitry Antipov Cc: Hante Meuleman , brcm80211-dev-list.pdl@broadcom.com, linux-wireless@vger.kernel.org, lvc-project@linuxtesting.org, Dmitry Antipov User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <170557695372.2924528.2049717324928380180.kvalo@kernel.org> Date: Thu, 18 Jan 2024 11:22:35 +0000 (UTC) Dmitry Antipov wrote: > Handle possible 'wait_for_completion_timeout()' errors in > 'brcmf_p2p_af_searching_channel()', 'brcmf_p2p_tx_action_frame()' > and 'brcmf_p2p_del_vif()', adjust related code. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Signed-off-by: Dmitry Antipov This is not simple cleanup and I feel that these should be tested on a real device. 2 patches set to Changes Requested. 13279707 [1/2,v2] wifi: brcmfmac: handle possible completion timeouts 13279708 [2/2,v2] wifi: brcmfmac: handle possible MSI enabling error -- https://patchwork.kernel.org/project/linux-wireless/patch/20230614075848.80536-1-dmantipov@yandex.ru/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches