Received: by 2002:a05:7412:ba23:b0:fa:4c10:6cad with SMTP id jp35csp279761rdb; Thu, 18 Jan 2024 03:27:53 -0800 (PST) X-Google-Smtp-Source: AGHT+IGHIp5KWMPcCxILahzfQRmZ1cIdw/81oQSW4iNNavT9CRo/rerrMNqbvX1a7oEAJUbGmhlX X-Received: by 2002:a17:906:f819:b0:a2e:9f3c:45bb with SMTP id kh25-20020a170906f81900b00a2e9f3c45bbmr415162ejb.61.1705577273680; Thu, 18 Jan 2024 03:27:53 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705577273; cv=pass; d=google.com; s=arc-20160816; b=Kfh36zzOOtjbWeo04KGgnT3nni2avTv8xhqxs1dtlIsgUQENMDF0CiejVzwJIB7vhu 1tGo93Y6Vhlsi4q13G59WDAmZqTIbjIPCa+0VMSt7H2+7Y6Cj1yN+YbNFzJVZzUhzE8K 9KOepbOU7pJ3egkxFNdwHYOe/JVZLWkPSom7I/vjehcSf9tJ1tHUpZOvXMpu6+jPI639 xQLKA+y50PHIiefFiYYVL+0ngjI1GSFsMDeGQ6NOw9HcbjXnEl47J8acXYA+hh4DfwmB 1ZH+ciCkHAhujnGlYKXreOj17pvT2O0kEG47F9XQ3u9kGH9fXtG/DHV5xz55bCYKKiJe O5ng== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=date:message-id:user-agent:cc:to:references:in-reply-to:from :subject:content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature; bh=YDN0nCBzMkjXVD8WBzjOMPvsXKRMQWfWwBkN54o9+K4=; fh=xXIsUxTbkFTHrTCrN/fIdogOXF8O9XPKGWK7EGS0CO0=; b=e8fMFtSEaQO6aIvzxVT7dZ6hyQUHQRdvIsy0VlZS34Ngen16bqqAqISc6zf1JBU3sj FQPaPQslONsJ45wWOMjCRP6AW8H9mnEwE3i5shkmdKfvQ7RHPDMT9iP/BOxhjKb3TzUb 7BQPbe4MLjS4BRb73+XzcbamFI2JZElQT7gvNDzytkGiRp7Fa2f1rNTiwT58B4Uqzncx VWZphG+ySywEvpu5C1P6uli78IOU0+gS8VQwF6hCQ5EHgYAVhlUsmZNu0xY2/ITmqBhU JrSio/jusfEFyZaVXp4mGJvA+a00ExH+ITlqhR14y7b4NSi7ailjMyiPVOUZAqKIg+If PGNw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=czYhUdp5; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-2171-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-wireless+bounces-2171-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id mb19-20020a170906eb1300b00a2ef4c5da11si999252ejb.143.2024.01.18.03.27.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jan 2024 03:27:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-2171-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=czYhUdp5; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-2171-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-wireless+bounces-2171-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 6CE1E1F23826 for ; Thu, 18 Jan 2024 11:27:53 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5AC6A241E9; Thu, 18 Jan 2024 11:27:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="czYhUdp5" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3716A241E6 for ; Thu, 18 Jan 2024 11:27:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705577269; cv=none; b=Y5VwYkELT6c0J6lSJ7VzaxXSTTx/Tsbeikl0VWopwj5F/fL9h32wnPo9fGUgRMZb1ybuXOhLZZ0GTRjEA61z6MaEntc9KbEY0EFhUUZgqKETak35v+AFTV19fk4gbsHxo2zZXfaKHafit8FaY226XoFVG6djlyY6UXmt1ieC+8E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705577269; c=relaxed/simple; bh=7FIs+TjXKnt5a3ThLNrp1veujLm+GW2sAhmpr1l3B7I=; h=Received:DKIM-Signature:Content-Type:MIME-Version: Content-Transfer-Encoding:Subject:From:In-Reply-To:References:To: Cc:User-Agent:Message-ID:Date; b=uSP+iKL9O77v8tjDBSdE+PZJA1qy9PUg6/Yblz6/rafWYspKAhBxLtS9PfizIGfr/7eYa5Cb3u/DWJGQAwv6+f1k5x0n8N8ZEjep+b3UglKbTnBEOPu3PYImv+9j+g3ZPWKmSU5prsi+f2Cjc2OdiG3uav5vFTX52Z192GWFMG4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=czYhUdp5; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4BD3FC433F1; Thu, 18 Jan 2024 11:27:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705577268; bh=7FIs+TjXKnt5a3ThLNrp1veujLm+GW2sAhmpr1l3B7I=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=czYhUdp5Jmb1qKtg6H25xOQ/wpuYPSB/O4sSpcMsdsje72+/QlD8hkhAYowFhc6c3 Ikik40RzRPnWYdGvA/cx8roCYVHp8pXXNHIcyZoEhmUQHAAvL2hI50IfMpYnfQQ+nR EED9Bo6E7fjGQh13PuIiY6pFBjBLewWAPW0y4UCb/KZx89sN9uoMiHjYvXTTV3vkkf m2fxapJTStL0rfQDzsG0uHdyaZja7rsJPBj3exoNFsQ4gUrUFYE2Km4Im/U8x5nqDR 2twzhnE7HgcvVWwBmqFUvoosDWiW2SWBZ5d9eHmKdRA8fZO6YlcT5/zH1IC4rdgL4R odz1FtEymRO5A== Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wifi: brcmfmac: always check the value returned by brcmf_chip_add_core() From: Kalle Valo In-Reply-To: <20230821112337.160974-1-dmantipov@yandex.ru> References: <20230821112337.160974-1-dmantipov@yandex.ru> To: Dmitry Antipov Cc: Franky Lin , Arend van Spriel , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, Dmitry Antipov User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <170557726552.2924528.1111973793443376429.kvalo@kernel.org> Date: Thu, 18 Jan 2024 11:27:47 +0000 (UTC) Dmitry Antipov wrote: > In 'brcmf_chip_recognition()', always check the value returned by > 'brcmf_chip_add_core()' with 'IS_ERR()' and return convenient > 'PTR_ERR()' in case of error. > > Fixes: cb7cf7be9eba ("brcmfmac: make chip related functions host interface independent") > Signed-off-by: Dmitry Antipov This should be tested on a real device. Patch set to Changes Requested. -- https://patchwork.kernel.org/project/linux-wireless/patch/20230821112337.160974-1-dmantipov@yandex.ru/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches