Received-SPF: pass (google.com: domain of linux-wireless+bounces-2173-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <2aa115c7-b8b7-4bb6-a559-840e723edc3b@gmail.com>
Date: Thu, 18 Jan 2024 12:57:41 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/2] [v2] wifi: brcmfmac: handle possible completion
 timeouts
Content-Language: en-US
To: Kalle Valo <kvalo@kernel.org>, Dmitry Antipov <dmantipov@yandex.ru>
Cc: Hante Meuleman <hante.meuleman@broadcom.com>,
 brcm80211-dev-list.pdl@broadcom.com, linux-wireless@vger.kernel.org,
 lvc-project@linuxtesting.org
References: <20230614075848.80536-1-dmantipov@yandex.ru>
 <170557695372.2924528.2049717324928380180.kvalo@kernel.org>
From: Arend Van Spriel <aspriel@gmail.com>
In-Reply-To: <170557695372.2924528.2049717324928380180.kvalo@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 1/18/2024 12:22 PM, Kalle Valo wrote:
> Dmitry Antipov <dmantipov@yandex.ru> wrote:
> 
>> Handle possible 'wait_for_completion_timeout()' errors in
>> 'brcmf_p2p_af_searching_channel()', 'brcmf_p2p_tx_action_frame()'
>> and 'brcmf_p2p_del_vif()', adjust related code.
>>
>> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>>
>> Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
> 
> This is not simple cleanup and I feel that these should be tested on a
> real device.

P2P testing. Ouch. Let me first have a closer look at the patches ;-)

> 2 patches set to Changes Requested.
> 
> 13279707 [1/2,v2] wifi: brcmfmac: handle possible completion timeouts
> 13279708 [2/2,v2] wifi: brcmfmac: handle possible MSI enabling error
>