Received-SPF: pass (google.com: domain of linux-wireless+bounces-2180-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Content-Type: text/plain; charset="utf-8"
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [wireless-next,v2,2/3] wifi: mwifiex: debugfs: Drop unnecessary
 error check for debugfs_create_dir()
From: Kalle Valo <kvalo@kernel.org>
In-Reply-To: <20230903030216.1509013-3-ruanjinjie@huawei.com>
References: <20230903030216.1509013-3-ruanjinjie@huawei.com>
To: Jinjie Ruan <ruanjinjie@huawei.com>
Cc: <gregory.greenman@intel.com>, <briannorris@chromium.org>, <nbd@nbd.name>,
 <lorenzo@kernel.org>, <ryder.lee@mediatek.com>, <shayne.chen@mediatek.com>,
 <sean.wang@mediatek.com>, <matthias.bgg@gmail.com>,
 <angelogioacchino.delregno@collabora.com>, <avraham.stern@intel.com>,
 <johannes.berg@intel.com>, <emmanuel.grumbach@intel.com>, <trix@redhat.com>,
 <dmantipov@yandex.ru>, <christophe.jaillet@wanadoo.fr>,
 <yangyang@marvell.com>, <linville@tuxdriver.com>, <rramesh@marvell.com>,
 <akarwar@marvell.com>, <nishants@marvell.com>,
 <linux-wireless@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>,
 <linux-mediatek@lists.infradead.org>, Bing Zhao <bzhao@marvell.com>,
 Frank Huang <frankh@marvell.com>, Kiran Divekar <dkiran@marvell.com>,
 <ruanjinjie@huawei.com>
User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2
Message-ID: <170558320955.2924528.12751516138860022016.kvalo@kernel.org>
Date: Thu, 18 Jan 2024 13:06:51 +0000 (UTC)

Jinjie Ruan <ruanjinjie@huawei.com> wrote:

> debugfs_create_dir() returns ERR_PTR and never return NULL.
> 
> As Russell suggested, this patch removes the error checking for
> debugfs_create_dir(). This is because the DebugFS kernel API is developed
> in a way that the caller can safely ignore the errors that occur during
> the creation of DebugFS nodes. The debugfs APIs have a IS_ERR() judge in
> start_creating() which can handle it gracefully. So these checks are
> unnecessary.
> 
> Fixes: 5e6e3a92b9a4 ("wireless: mwifiex: initial commit for Marvell mwifiex driver")
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
> Suggested-by: Russell King (Oracle) <linux@armlinux.org.uk>

Patch applied to wireless-next.git, thanks.

50180c7f8e3d wifi: mwifiex: debugfs: Drop unnecessary error check for debugfs_create_dir()

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20230903030216.1509013-3-ruanjinjie@huawei.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches