Received: by 2002:a05:7412:ba23:b0:fa:4c10:6cad with SMTP id jp35csp358251rdb; Thu, 18 Jan 2024 05:56:08 -0800 (PST) X-Google-Smtp-Source: AGHT+IEUQD63VUadXnh7LmCxroamk/pQ3OlP07HL5hRiijYsq9cdx4IZfQg6lGMBYkttriMYR6Cc X-Received: by 2002:aa7:c3ce:0:b0:55a:452:1851 with SMTP id l14-20020aa7c3ce000000b0055a04521851mr295001edr.68.1705586167953; Thu, 18 Jan 2024 05:56:07 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705586167; cv=pass; d=google.com; s=arc-20160816; b=Fic+wdJiaqqj/ZVgibYWBgvTVPLphsJAnI/EMsPG/swYlKGxibfCu0E2Gp+9ovcCW1 RtpzskRjmTmbnRrx6cIOu9gXqYBpDdN9dIgECyQs+sLySJJXEFw9IzuuMJ8QBlatC9Of NtTLgm3vuCzWNwzsPp+kGCplBoILO3+OTsMRm7nhRHTQLiB3muGGXYw53awwboWH61mL huC78yS60Fsz8gl1nW5l1ccNbqDcUq+VVqIGEsLplyBn2ja9Qr4Us0gDrh9SRvYzAM8B RwQKthYsQrlpjvxLJ2japtTRcjC7OfGynjZioueLv7azzjsB0R0tmVKBYdEgbfFRP2Kz ACZg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:content-transfer-encoding:references:in-reply-to:date:cc :to:from:subject:message-id:dkim-signature; bh=je3JewdLj5PYFyLNnXFPbuzK89xCvkX0qHYM9S3A/yY=; fh=PcuFhHJMhMJuueCQRolEC85hK0nfz0/Yap/OAavMfHM=; b=LuLTkruh7fc/hZ8B2pab70GW4eNw9VlkcwAovnyJyi1p4jhteW4og/46mCt+fqLWYx Sr0Mqi+PFXGa7IQn10nckH3LylMCCrekdlWB7NzWwaTP9VghYPiLUg30aBWJjzKpisQo ADgpn95aJAR6PZpiQHZyQR2lL7Jell8kznh9Bb7X1LMfcD8ANpShPYGd+clZtvbSNeJN it/0DAJgytTlZGCYlWmqhFDGh4N3gpIEw3zKIEI/KQk4f+L9k37spb9RjejihwJqKSys Eopz9XyZvUPfF344CtaPmjrllF9UAjiClMMqjeOf0R+4yVtOvbIfSpevPf9DuE5ojMKA vqJA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=AzHplHdy; arc=pass (i=1 spf=pass spfdomain=sipsolutions.net dkim=pass dkdomain=sipsolutions.net dmarc=pass fromdomain=sipsolutions.net); spf=pass (google.com: domain of linux-wireless+bounces-2186-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-wireless+bounces-2186-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id gy5-20020a0564025bc500b0055411a2bb22si6933194edb.371.2024.01.18.05.56.07 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jan 2024 05:56:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-2186-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=AzHplHdy; arc=pass (i=1 spf=pass spfdomain=sipsolutions.net dkim=pass dkdomain=sipsolutions.net dmarc=pass fromdomain=sipsolutions.net); spf=pass (google.com: domain of linux-wireless+bounces-2186-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-wireless+bounces-2186-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 47AF31F22492 for ; Thu, 18 Jan 2024 13:46:31 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id F10C725553; Thu, 18 Jan 2024 13:46:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sipsolutions.net header.i=@sipsolutions.net header.b="AzHplHdy" X-Original-To: linux-wireless@vger.kernel.org Received: from sipsolutions.net (s3.sipsolutions.net [168.119.38.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F8BD24B42 for ; Thu, 18 Jan 2024 13:46:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=168.119.38.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705585586; cv=none; b=ltTJ7LHU6nsOHu5MQol8XiMksSNgIg3fIo3xTkKveWkE/G8ssa8TifjG64mAbQF24n9i1vywiismZqqUOpj52BcnrzdFddN0oHCPzKJ0FsqLBc0ZnmNGIqMOgtetROC1L33J7md2/+2xZXv/si7J5Ks/PcJCXVf47LgI0iduNyY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705585586; c=relaxed/simple; bh=je3JewdLj5PYFyLNnXFPbuzK89xCvkX0qHYM9S3A/yY=; h=DKIM-Signature:Received:Message-ID:Subject:From:To:Cc:Date: In-Reply-To:References:Content-Type:Content-Transfer-Encoding: User-Agent:MIME-Version:X-malware-bazaar; b=U1Dhooeteo5w8wqTvDn+njvpM+wwuSmY6F8rPFQ9vw9qokj3ShmtVXxmZwnDK8MDhUZyS3O0zUMPlTynJ+psQ9GRwngQN7XUk9njaT0bSGzcz16S2yXche4NlFKJORCjlNhYtORfJT8vRIFOQug/+TPVdhwHr9r2z/9S8zV0FHY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sipsolutions.net; spf=pass smtp.mailfrom=sipsolutions.net; dkim=pass (2048-bit key) header.d=sipsolutions.net header.i=@sipsolutions.net header.b=AzHplHdy; arc=none smtp.client-ip=168.119.38.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sipsolutions.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sipsolutions.net DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=je3JewdLj5PYFyLNnXFPbuzK89xCvkX0qHYM9S3A/yY=; t=1705585585; x=1706795185; b=AzHplHdyNV5f0kNwVYZMc+m9UCGv1LKgRuWeIa2qBtfdY3I ou1Sy6zii5qQvR1X3Ddvks/wMMXHJWjbJjf5yBVKXsqFePccz/tqzGsfDnqOYPUWtjofzkZU4Aq+O 7kL1hMV5cI+JUd1KdWsMxeMvxrX5Dmb5gXeeUrLqlMPBTrLTCK4Ma9kch7VjtjXBHXTp9cPMdLNeR oudy2UGofv39JVcI8nbPVb3Theta1wOM1vS9Vj1ZOl9XCYJcZ9N7umrABvjh99EXGHGmhXUFmmnbD A/nG8trp3m7AszqE7+eW1ulGVPr3VQfXcAVDVOcc8i8m3MlcWGfFB+TytOhhTMJQ==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.97) (envelope-from ) id 1rQSil-000000082kt-2h7n; Thu, 18 Jan 2024 14:46:15 +0100 Message-ID: <9433d29b643e4cce3a9354282405288c75c45e02.camel@sipsolutions.net> Subject: Re: [PATCH] wifi: mac80211: don't ask rate control with zero rate mask if scanning From: Johannes Berg To: Dmitry Antipov Cc: Felix Fietkau , Kalle Valo , linux-wireless@vger.kernel.org, lvc-project@linuxtesting.org, syzbot+fdc5123366fb9c3fdc6d@syzkaller.appspotmail.com Date: Thu, 18 Jan 2024 14:46:14 +0100 In-Reply-To: <20240117124848.120438-1-dmantipov@yandex.ru> References: <20240117124848.120438-1-dmantipov@yandex.ru> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.3 (3.50.3-1.fc39) Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-malware-bazaar: not-scanned On Wed, 2024-01-17 at 15:48 +0300, Dmitry Antipov wrote: > If we're scanning and got the control frame with zero rate mask, drop > the frame before '__rate_control_send_low()' getting stuck attempting > to select supported rate. But why drop the frame? I'm still thinking that it just doesn't really make sense to apply the rate mask to scanning at all? The most common use case for this is probably P2P-style things where you just don't want to use CCK, but for scanning we have NL80211_ATTR_TX_NO_CCK_RATE for this, so there's really no need to apply the rate mask? johannes