Received-SPF: pass (google.com: domain of linux-wireless+bounces-2262-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Erick Archer <erick.archer@gmx.com>
To: Stanislaw Gruszka <stf_xl@wp.pl>,
	Kalle Valo <kvalo@kernel.org>,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: Erick Archer <erick.archer@gmx.com>,
	linux-wireless@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-hardening@vger.kernel.org
Subject: [PATCH] wifi: iwlegacy: Use kcalloc() instead of kzalloc()
Date: Fri, 19 Jan 2024 18:16:55 +0100
Message-Id: <20240119171655.7740-1-erick.archer@gmx.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:2tEhQomloAs=;xFOFmVFKajcsN2YfYY0lIFqFpPa
 wDTwfVxs5uMCUUud5TFtNaaU6YMdrsLCveR5n5MmroN2Lj/0p65wSQf8OlZ5yo2AdBGs2eNk1
 4CiPTEcq0eI19pjkNfTU4YNWZGXOtfS4APx7LJF1eBHs0Fbu+1tuQLBCRe/El0AW25a10jxWX
 LexCal7YaNjHm3gqXgDJlkYbA4hsXgbqTHY+OUysasI7VmDzGJ482vgsWveDPcAXUSBf0KeN/
 QmHNicMjqBAO+7sNIb2PIpOAtAyeXAEaRT//VqZElZCyFLdHUlM3ngLe5H0/JnTrrYrSXPm9d
 5wmkJJpyn1LdmJyhexHKERqN3G1jTp6CdGcsAPxFvi0PWzWmiVOs8W3EhTlBHwvHMTxFxiNDu
 MCXbyWne/tm3b2NjyNa40Ef1T1k+kEegjsvVhPz+3nxef9x3/R7Pn/VmGQiocFwpS2wx6QhqB
 w/waCgdHlRDuCWgjpOWouJsw8+/xILY68ep/C3qp9XcWXo7wB/7hMnHHCRz2S9flXMkldGoUs
 PauYL8Vay/v4ApxOybf/UKyR773TgIpFLi3K3FYTT0v1bp2qNuypmMTRGeO2yZKjjKbHVVUVP
 MmdyDxTqqNKuv5eQuMi9Gkc8fjndanEGoq//QCLNLHOiQPVcLnMHQWgBhbxL4plciuMXd6TxN
 yrENgozk/F/m9yjZ2scW36F2jflNCn/JWtHK5iqofHn/ZL6s6u0wCN3iIBNuLP3Sr14YdP1BY
 SjVs/fTMXaVh4kUkXTYoiCGz5Ix+oNoUS0cOvsULveWnmlRwjzx/lsMvAx64Ej0R/Z/46QtdV
 CbX+vpbppurHhVslgHcFNckbCd5o3B0y5fRs54mcj6OG88ol+QogNgLunzC7LwTUnhZwbeVNM
 bOr9rlAXLoJupv7+mJaEeOEWPBhM83ZKfoFo8/aqtAVkJph7rZe3l5TYpFzKMOpR5eWRYtzUh
 sl9Ts8RzSC9GDrRcQ37QmZ6iZ3A=

As noted in the "Deprecated Interfaces, Language Features, Attributes,
and Conventions" documentation [1], size calculations (especially
multiplication) should not be performed in memory allocator (or similar)
function arguments due to the risk of them overflowing. This could lead
to values wrapping around and a smaller allocation being made than the
caller was expecting. Using those allocations could lead to linear
overflows of heap memory and other misbehaviors.

So, use the purpose specific kcalloc() function instead of the argument
size * count in the kzalloc() function.

Also, it is preferred to use sizeof(*pointer) instead of sizeof(type)
due to the type of the variable can change and one needs not change the
former (unlike the latter).

Link: https://www.kernel.org/doc/html/next/process/deprecated.html#open-co=
ded-arithmetic-in-allocator-arguments [1]
Link: https://github.com/KSPP/linux/issues/162
Signed-off-by: Erick Archer <erick.archer@gmx.com>
=2D--
 drivers/net/wireless/intel/iwlegacy/common.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/wireless/intel/iwlegacy/common.c b/drivers/net/wi=
reless/intel/iwlegacy/common.c
index 17570d62c896..9d33a66a49b5 100644
=2D-- a/drivers/net/wireless/intel/iwlegacy/common.c
+++ b/drivers/net/wireless/intel/iwlegacy/common.c
@@ -3438,9 +3438,7 @@ il_init_geos(struct il_priv *il)
 	if (!channels)
 		return -ENOMEM;

-	rates =3D
-	    kzalloc((sizeof(struct ieee80211_rate) * RATE_COUNT_LEGACY),
-		    GFP_KERNEL);
+	rates =3D kcalloc(RATE_COUNT_LEGACY, sizeof(*rates), GFP_KERNEL);
 	if (!rates) {
 		kfree(channels);
 		return -ENOMEM;
=2D-
2.25.1