Received-SPF: pass (google.com: domain of linux-wireless+bounces-2267-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Content-Type: text/plain; charset="utf-8"
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH v2] wifi: rtlwifi: Speed up firmware loading for USB
From: Kalle Valo <kvalo@kernel.org>
In-Reply-To: <d9bd4949-6e92-4f35-8b60-3b45f9ad74ab@gmail.com>
References: <d9bd4949-6e92-4f35-8b60-3b45f9ad74ab@gmail.com>
To: Bitterblue Smith <rtl8821cerfe2@gmail.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
 Ping-Ke Shih <pkshih@realtek.com>, Larry Finger <Larry.Finger@lwfinger.net>
User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2
Message-ID: <170568549408.3153793.3782157778815282405.kvalo@kernel.org>
Date: Fri, 19 Jan 2024 17:31:35 +0000 (UTC)

Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote:

> Currently it takes almost 6 seconds to upload the firmware for RTL8192CU
> (and 11 seconds for RTL8192DU). That's because the firmware is uploaded
> one byte at a time.
> 
> Also, after plugging the device, the firmware gets uploaded three times
> before a connection to the AP is established.
> 
> Maybe this is fine for most users, but when testing changes to the
> driver it's really annoying to wait so long.
> 
> Speed up the firmware upload by writing chunks of 64 bytes at a time.
> This way it takes about 110 ms for RTL8192CU (and about 210 ms for
> RTL8192DU).
> 
> PCI devices could upload it in chunks of 4 bytes, but I don't have any
> to test and commit 89d32c9071aa ("rtlwifi: Download firmware as bytes
> rather than as dwords") decided otherwise anyway.
> 
> Allocate memory for the firmware image with kmalloc instead of vzalloc
> because this memory is passed directly to usb_control_msg(), which
> can't take memory allocated by vmalloc.
> 
> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
> Acked-by: Ping-Ke Shih <pkshih@realtek.com>

Patch applied to wireless-next.git, thanks.

b06439c66874 wifi: rtlwifi: Speed up firmware loading for USB

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/d9bd4949-6e92-4f35-8b60-3b45f9ad74ab@gmail.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches