Received-SPF: pass (google.com: domain of linux-wireless+bounces-2366-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Kalle Valo <kvalo@kernel.org>
To: Breno Leitao <leitao@debian.org>
Cc: kuba@kernel.org,  davem@davemloft.net,  abeni@redhat.com,
  edumazet@google.com,  Arend van Spriel <aspriel@gmail.com>,  Franky Lin
 <franky.lin@broadcom.com>,  Hante Meuleman <hante.meuleman@broadcom.com>,
  dsahern@kernel.org,  weiwan@google.com,  linux-wireless@vger.kernel.org
 (open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER),
  brcm80211-dev-list.pdl@broadcom.com (open list:BROADCOM BRCM80211
 IEEE802.11n WIRELESS DRIVER),  linux-kernel@vger.kernel.org (open list)
Subject: Re: [PATCH net-next 17/22] net: fill in MODULE_DESCRIPTION()s for
 Broadcom WLAN
References: <20240122184543.2501493-1-leitao@debian.org>
	<20240122184543.2501493-18-leitao@debian.org>
Date: Tue, 23 Jan 2024 08:38:29 +0200
In-Reply-To: <20240122184543.2501493-18-leitao@debian.org> (Breno Leitao's
	message of "Mon, 22 Jan 2024 10:45:38 -0800")
Message-ID: <877ck0eeqi.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

Breno Leitao <leitao@debian.org> writes:

> W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> Add descriptions to the Broadcom FullMac WLAN drivers.
>
> Signed-off-by: Breno Leitao <leitao@debian.org>
> ---
>  drivers/net/wireless/broadcom/brcm80211/brcmfmac/bca/module.c | 1 +
>  drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/module.c | 1 +
>  drivers/net/wireless/broadcom/brcm80211/brcmfmac/wcc/module.c | 1 +
>  3 files changed, 3 insertions(+)
>
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bca/module.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bca/module.c
> index d55f3271d619..c1f91dc151c2 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bca/module.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bca/module.c
> @@ -20,6 +20,7 @@ static void __exit brcmf_bca_exit(void)
>  	brcmf_fwvid_unregister_vendor(BRCMF_FWVENDOR_BCA, THIS_MODULE);
>  }
>  
> +MODULE_DESCRIPTION("Broadcom FullMAC WLAN BCA driver");

It would be good to spell out BCA. I don't even know what it means :)

> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/module.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/module.c
> @@ -20,6 +20,7 @@ static void __exit brcmf_cyw_exit(void)
>  	brcmf_fwvid_unregister_vendor(BRCMF_FWVENDOR_CYW, THIS_MODULE);
>  }
>  
> +MODULE_DESCRIPTION("Broadcom FullMAC WLAN CYW driver");

Same for CYW.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches