Received-SPF: pass (google.com: domain of linux-wireless+bounces-2368-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: Kalle Valo <kvalo@kernel.org>
To: Alexis =?utf-8?Q?Lothor=C3=A9?= <alexis.lothore@bootlin.com>
Cc: David Mosberger-Tang <davidm@egauge.net>,  Ajay.Kathat@microchip.com,
  linux-wireless@vger.kernel.org
Subject: Re: RFQ: wifi: wilc1000: make wilc1000-spi bus-probe useful
References: <90fb762e5840f9d5a6ae46f81692fb947a7796a4.camel@egauge.net>
	<e17d654a-8bd5-4327-8bf2-ad81c2f7355b@bootlin.com>
	<5ff15ae65ccb7c144ba8e0f07dc2ac25bd8b2b42.camel@egauge.net>
	<7615dcfe-4363-4d00-aac0-510c279f6b96@bootlin.com>
Date: Tue, 23 Jan 2024 11:28:36 +0200
In-Reply-To: <7615dcfe-4363-4d00-aac0-510c279f6b96@bootlin.com> ("Alexis
	=?utf-8?Q?Lothor=C3=A9=22's?= message of "Tue, 23 Jan 2024 10:16:48 +0100")
Message-ID: <877ck02ybf.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Alexis Lothor=C3=A9 <alexis.lothore@bootlin.com> writes:

> Hello David,
> just reacting to your answers, but I will take a look at your updated pat=
ch
>
> On 1/22/24 21:41, David Mosberger-Tang wrote:
>> Alexis,
>>=20
>> Thanks for your feedback!
>>=20
>> On Mon, 2024-01-22 at 15:19 +0100, Alexis Lothor=C3=A9 wrote:
>>> Hello,
>>>
>>> On 1/19/24 22:51, David Mosberger-Tang wrote:
>
> [...]
>
>>>> + if (ret) {
>>>> + ret =3D -ENODEV;
>>>
>>> I would keep wilc_spi_configure_bus_protocol original error instead of
>>> rewriting/forcing it to -ENODEV here. I mean, if something fails in
>>> wilc_spi_configure_bus_protocol but not right at the first attempt to
>>> communicate with the chip, it does not translate automatically to an ab=
sence of
>>> chip, right ?
>>=20
>> Hmmh, I'm happy to change it, but, as it happens, all failure returns in
>> wilc_spi_configure_bus_protocol() basically mean that the device isn't p=
resent
>> or a device is present which the driver doesn't support, so I think -ENO=
DEV is
>> more useful than returning -EINVAL (as would be the case).  Let me know =
if you
>> still think I should change it.
>
> Yeah, but then I would change wilc_spi_configure_bus_protocol() to return
> -ENODEV instead of -EINVAL, if that's really the cause, and just let call=
ing
> functions propagate it. That may just be a personal taste, but I find it =
pretty
> tedious to debug some error code and eventually realize that some interme=
diate
> function just rewrote the real error to another one (and sometime, loosin=
g some
> info while doing so).

Yeah, changing error values is very much discouraged.

--=20
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatc=
hes