Received: by 2002:a05:7412:5112:b0:fa:6e18:a558 with SMTP id fm18csp411714rdb; Tue, 23 Jan 2024 03:44:01 -0800 (PST) X-Google-Smtp-Source: AGHT+IFbY9h8UfTRAUNl45U1heZu4Qoebx0KvPtX8VZVaPWlWrbdX5Mj8y2GfcqcrRYU6ip19+kj X-Received: by 2002:a17:902:d489:b0:1d7:79cf:cce with SMTP id c9-20020a170902d48900b001d779cf0ccemr78055plg.46.1706010241010; Tue, 23 Jan 2024 03:44:01 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706010240; cv=pass; d=google.com; s=arc-20160816; b=EPxC2j/nEG0oDAzfFZHoORNqGvTJHQnZt+A04Snfg0Deui/MzBzfRNUWBj2YOc+TLR DCHQgG8gKzUcOiQS8zEpKXgPg9HJO46y/hFJiGzT9XU9JVTY/f9+ZHk4Q22dKnhcRWE8 sNMWqFm/LWS0RF/fhRhp1me3u58DAh+OwmWGsU26Iz6hhx39C405lC3/e/6pRqHJpmPy XaTgBQAMhGp+9Fx/yyLLRajgByXrokHhBLD9TVZuCWh3F2n22Zzo4QXVMj/diyw02oBC mgGaZ7quwKLUp/yBqcGsIgswzzTRNyJYlbsTAE38TMk3lKtqJpfiB35Uge+MnDJELxKm pWQA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=date:message-id:user-agent:cc:to:references:in-reply-to:from :subject:content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature; bh=Lmonky4p3qcfMMmNvJe3KvudtEyEo7biQMuph+uTmCA=; fh=xj3JPLYtNpO/p1wK/oHh+NrRQYCNSzXoR8iehM6gpvk=; b=l+/32tTwmyezgZsu/syDlMgchnpAQqLVW1QNFLgGA2x0027n65n3IBVmdpvSEUDkQz Ba3YOhWLPuP5EVJPI9IUa7+w1K4GC812EEWW0m0DptIFR5JM44Irf0EG5MB6kffHApH2 8NfuiG4GPAxmQdj3WYK0d6tPrzA73ejnsR27ZGGbpRZxFWFGzBesPjnK/3+WyGj1MOUn XFIYM93438LPTTq0qB8V2uTYVOwslT4zFvpSEBg8eBsR3kMFVW9E4czSrIxC3WuT2Eam i6TlweAwggWusXS7kAqEKFMNFsbTr+P+Cx5L5pnCbY3glfT5U4jKC+L4jRr0RSSb1N90 OdMA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=I24y5Ieh; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-2376-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-2376-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id h5-20020a170902f7c500b001d7389e3255si4875756plw.529.2024.01.23.03.44.00 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jan 2024 03:44:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-2376-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=I24y5Ieh; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-2376-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-2376-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 4CD7028A7B7 for ; Tue, 23 Jan 2024 11:44:00 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 86F6D50268; Tue, 23 Jan 2024 11:43:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="I24y5Ieh" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 640054BAA8 for ; Tue, 23 Jan 2024 11:43:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706010237; cv=none; b=KhUnozSg9fQn6GlInkCuv1cY/cGjHP67ktKNFRkPSUdFz1bqV5DPKIF6QI3yO2IZKLS5SZrdXYFZ+NIFw+k+hSDV/7ThCj3ubUr4ATqWOQp+f3YUYjsTvlQglwGMaX/3Ksz9S1BhWLE/KxRToAcUfYrkwgCGNvNq4IBNTlscJSc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706010237; c=relaxed/simple; bh=s0V7GHpf63yU5Ahp+XUdiMpFDwH86KbmA1WqyxH7ONk=; h=Content-Type:MIME-Version:Subject:From:In-Reply-To:References:To: Cc:Message-ID:Date; b=Y4syEaxmdKDLr5Bl640yF5p92AlC3umrmockR+MQh+xSS62zj2keAFBkIDqUEQOgjG5AIszraje5/Vk29Scnrc5i3JzB2yilpCFezjuWxbkH9aZcOAvN18NZgOApQCrWNWxb4PEXDlTVhU16ksv6pqSCmXigTxoXvLukrJPzP8U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=I24y5Ieh; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id BA311C433F1; Tue, 23 Jan 2024 11:43:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706010236; bh=s0V7GHpf63yU5Ahp+XUdiMpFDwH86KbmA1WqyxH7ONk=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=I24y5IehZV2AjLdoAoHeOnK6JG2SfhN/Pr6t4JWr9KgsJFfmOCPR2Hyn0VsJ7mDmo hKhZ1uYyV51iX3Xd6dpkYtWx08wGLhNAk/f/oPzcm3wHbCmznG3zOV4jpF83J26Ye3 gkByebHt/oUOFVyPSFfvOefIlp3uFRDHlLxRQ2QZVSNcjJE6SeVE2YfqMiCeidIWSi 1T1As7FA1VTxm4fDC4z5tm+U9F51eTBUvY41vhJdfjaqGJE2BBe0Yq44eDtotkylVv GV97vDQzH5WxW0fHMwHh4FWbzghZmr0O452GJCGCWjWBqmJfuzwPqeVpQlBmYTS5ss C1fercHecGPtQ== Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wifi: mwifiex: cleanup SSID-related data types From: Kalle Valo In-Reply-To: <20240118145715.475513-1-dmantipov@yandex.ru> References: <20240118145715.475513-1-dmantipov@yandex.ru> To: Dmitry Antipov Cc: Brian Norris , David Lin , linux-wireless@vger.kernel.org, Dmitry Antipov User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <170601023387.3962299.2804573379810764117.kvalo@kernel.org> Date: Tue, 23 Jan 2024 11:43:55 +0000 (UTC) Dmitry Antipov wrote: > Drop unused 'struct mwifiex_ssid_bssid' and replace custom > 'struct mwifiex_802_11_ssid' with generic 'struct cfg80211_ssid' > as a member of 'struct mwifiex_uap_bss_param'. Compile tested only. > > Signed-off-by: Dmitry Antipov The commit message should also explain _why_ this change is safe. I have no idea if you just randomly changed this or there was a proper analysis. For example, there are changes in length field and if the firmware uses this struct there will be problems. Patch set to Changes Requested. -- https://patchwork.kernel.org/project/linux-wireless/patch/20240118145715.475513-1-dmantipov@yandex.ru/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches