Received-SPF: pass (google.com: domain of linux-wireless+bounces-2383-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Kalle Valo <kvalo@kernel.org>
To: Alexis =?utf-8?Q?Lothor=C3=A9?= <alexis.lothore@bootlin.com>
Cc: David Mosberger-Tang <davidm@egauge.net>,
  linux-wireless@vger.kernel.org,  Ajay.Kathat@microchip.com
Subject: Re: [PATCH] wifi: wilc1000: validate chip id during bus probe
References: <20240122211315.1444880-2-davidm@egauge.net>
	<20240122220350.1449413-1-davidm@egauge.net>
	<751bf8e4-c81c-495b-9166-9f91f9c4b2d5@bootlin.com>
	<8734uo2ts1.fsf@kernel.org>
	<94d08fd2-ce43-4085-a6f6-d91981853393@bootlin.com>
Date: Tue, 23 Jan 2024 14:59:40 +0200
In-Reply-To: <94d08fd2-ce43-4085-a6f6-d91981853393@bootlin.com> ("Alexis
	=?utf-8?Q?Lothor=C3=A9=22's?= message of "Tue, 23 Jan 2024 13:44:40 +0100")
Message-ID: <87y1cg19z7.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Alexis Lothor=C3=A9 <alexis.lothore@bootlin.com> writes:

> On 1/23/24 12:06, Kalle Valo wrote:
>> Alexis Lothor=C3=A9 <alexis.lothore@bootlin.com> writes:
>>=20
>>> On 1/22/24 23:03, David Mosberger-Tang wrote:
>>>> Previously, the driver created a net device (typically wlan0) as soon
>>>> as the module was loaded.  This commit changes the driver to follow
>>>> normal Linux convention of creating the net device only when bus
>>>> probing detects a supported chip.
>>>
>>> I would gladly help review/test the patch, but please give us some time=
 between
>>> versions to take a look (even if you can mention if you found issues yo=
urself).
>>> Also, each version should be a separate thread, bearing the new version=
 in the
>>> "Subject" line.
>>> Additionally (to answer your cover letter), the patches must target the=
 wireless
>>> branches (likely wireless-testing), not linux-next
>>> (https://wireless.wiki.kernel.org/en/developers/documentation/git-guide)
>>=20
>> Actually wireless-next is preferred for the baseline (unless it's a fix
>> going to -rc releases):
>>=20
>> https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.g=
it/
>
> Oh, ok, thanks for the correction, I may have misinterpreted the wiki then

Ah, we should update that page. That page was written before we had
common wireless and wireless-next trees.

I don't know Johannes thoughts on this but my recommendation for
baseline:

* use wireless tree for important fixes going to -rc releases

* for other patches use either driver specific tree (eg. iwlwifi, mt76,
  ath) or wireless-next (if no driver specific tree available)

* for automated testing etc. use wireless-testing as it's a merge of
  wireless and wireless-next and contains all latest code

--=20
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatc=
hes