Received: by 2002:a05:7412:5112:b0:fa:6e18:a558 with SMTP id fm18csp645872rdb; Tue, 23 Jan 2024 10:10:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IH2oG8SoRPI7z8+8LKxA0hQNgmGzQOMEM7/Es4orWLX/9qv4hMKeGsaehhER/2M5ghN/103 X-Received: by 2002:a17:90b:11c7:b0:290:5d81:339b with SMTP id gv7-20020a17090b11c700b002905d81339bmr3760516pjb.65.1706033426649; Tue, 23 Jan 2024 10:10:26 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706033426; cv=pass; d=google.com; s=arc-20160816; b=kNhYKiPD6oJ8x+GRNVUtKHkocQpFg1w9L8lzF4dYJoM/EXwa/oo5SpFfiGz1dx+BkS wpa5Xdc6y2PFjOmscNl31QnyIZ4QUTk7lP+QJZCGo5tm2i4p/F+ZIl/67It41jflFsIc CqG3WelA3P4win6nmA6CWXwCQtjlROAgLqu7eeu6Wr0FpjPR98g7EDXQzBS1eUPrbEt+ vMLDklS3qj2i5+YTSt9yd+WxGe9pqD0Pg9zsp1F4me4AczxQ7JZpkthhEPuXzmyiT2Gp E7mECJXiHMNdYrZt0Q5Xd/q6jMx5tCVmrEUjjAHr3hnwur2ePU6TDM+6aM3Q67G0yNlF CJYA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:organization:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=DzLlkHr9ajqCiiIlw2DGLqh8jDxhNH+TRX0p3gGbUMc=; fh=Y2IfAqdjkYQAx7XZcGq/8JceY1atOOwfX771vvMvH7o=; b=VCsddycNOsss8UOE/idIi1wlzWRIa5Su8XEfW+gPrOPR2N+iAYBvef9EffK73E6iK5 iMQH2b1zC8FNwuq4LIYxKqgM5TSSttS74khrFneCW08Ax/Ozma6yhiIK3/eN5lTa+0fg 5iAQWy7lgQGsr6pu5QuQUYse2GHXkkUR1bXsKg42fj0pWnQ9a2yn1AXti4+dsTpt/NN/ ary5X52tYaLTIrWvDd31hxj0LkYpG4UbRGogck5rvKUiXOSeWZdDxqlExYivLgRI4yyF oXKzg3CeiZJokuzbVQtgUMf4uaAxmLX/ITXERobStb+4faGtjqoqX+xSAwoXUitwgRhk 0Ltg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=JpBkn7ZA; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-wireless+bounces-2399-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-2399-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id w23-20020a17090a8a1700b002905eeccaf4si7051043pjn.187.2024.01.23.10.10.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jan 2024 10:10:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-2399-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=JpBkn7ZA; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-wireless+bounces-2399-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-2399-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 6D81928A1CD for ; Tue, 23 Jan 2024 18:09:24 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0E5B981211; Tue, 23 Jan 2024 18:08:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="JpBkn7ZA" X-Original-To: linux-wireless@vger.kernel.org Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FB1E81AB8 for ; Tue, 23 Jan 2024 18:08:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.13 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706033333; cv=none; b=IOcD2Xu4HHOtouABEUSq9PZUXP2XI4eElr+aQau7XH/bXU4hnfHyMqVgBRb8izbvxtYgSmeL37hioxQG9Rd4LiHbxsgyz3Yc/yomOEhkxYY3MDxUOxqpx+UwXVCKRNZXADnXcgq6OzzqR6bcY5frZurxZ60Wm7a3548jQMDrrjQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706033333; c=relaxed/simple; bh=RgzVesXq/zZ1bAJozBx51741iH+CxrsLQs9esaSLgIY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=bJiJGATFC85kJonUCt8jdpwevuUbXbemkakmaRaAbwxA5B+0gyA7Gqz5/ITh4ODO2BE4PCwgE0iXMFA781JjU1oVmtvlBMUZ69tvTpELwgqwI0fE7x5xVhIib2GIMhsK+3cXajQpaNJV0xIKy8fIeTExJtC7rbSspSUiAuRx+PY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=JpBkn7ZA; arc=none smtp.client-ip=192.198.163.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1706033333; x=1737569333; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=RgzVesXq/zZ1bAJozBx51741iH+CxrsLQs9esaSLgIY=; b=JpBkn7ZAqTdaWIyp98Xn+rnImikgLrGtNct+WszqVvQuocOgu8UUxrAV yGyPTGZ9BgjvdiaTfuFr/EIssylrnjT1trgL0Ppv3FV+1JOww5a6yTyeU OhYCCMSLnBa8gAn/m0gnod21M44GR4OMJweEsteDqRUC2fGBXt3XIousD UJltxWq/BtWy2T0xLFkvem4hxpM+ccY6RyD4umywM+8oXz7jJFRm3wEna KtNaLYxBHv4YFBIpQiUru1MeP/tNDYQqWhHQhfoypxBiyBAv5PVhv6FMX zeGzMV2lQRulqfKYfz6VEd4TbUgwiYFlOtTJ9HjH9P5HwR/b4+PLLwpql A==; X-IronPort-AV: E=McAfee;i="6600,9927,10962"; a="501738" X-IronPort-AV: E=Sophos;i="6.05,215,1701158400"; d="scan'208";a="501738" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jan 2024 10:08:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,215,1701158400"; d="scan'208";a="1666486" Received: from unknown (HELO WEIS0040.iil.intel.com) ([10.12.217.108]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jan 2024 10:08:50 -0800 From: Miri Korenblit To: johannes@sipsolutions.net Cc: linux-wireless@vger.kernel.org, Johannes Berg , Gregory Greenman Subject: [PATCH 04/15] wifi: iwlwifi: make TB reallocation a debug message Date: Tue, 23 Jan 2024 20:08:12 +0200 Message-Id: <20240123200528.329d5f2ee7f7.I0bfc6dde17fe2c738129f3aba746c6cba57589f9@changeid> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240123180823.2441162-1-miriam.rachel.korenblit@intel.com> References: <20240123180823.2441162-1-miriam.rachel.korenblit@intel.com> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Organization: Intel Israel (74) Limited Content-Transfer-Encoding: 8bit From: Johannes Berg There's no need to print this, it's a known issue and the workaround works just fine. Make the reallocation message just a debug message. Signed-off-by: Johannes Berg Reviewed-by: Gregory Greenman Signed-off-by: Miri Korenblit --- drivers/net/wireless/intel/iwlwifi/queue/tx.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/queue/tx.c b/drivers/net/wireless/intel/iwlwifi/queue/tx.c index ca74b1b63cac..ba0419bc1765 100644 --- a/drivers/net/wireless/intel/iwlwifi/queue/tx.c +++ b/drivers/net/wireless/intel/iwlwifi/queue/tx.c @@ -271,9 +271,10 @@ static int iwl_txq_gen2_set_tb_with_wa(struct iwl_trans *trans, meta = NULL; goto unmap; } - IWL_WARN(trans, - "TB bug workaround: copied %d bytes from 0x%llx to 0x%llx\n", - len, (unsigned long long)oldphys, (unsigned long long)phys); + IWL_DEBUG_TX(trans, + "TB bug workaround: copied %d bytes from 0x%llx to 0x%llx\n", + len, (unsigned long long)oldphys, + (unsigned long long)phys); ret = 0; unmap: -- 2.34.1