Received-SPF: pass (google.com: domain of linux-wireless+bounces-2411-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <d4c1a7c715a1f47dc45c5d033822d8f47e304bd4.camel@sipsolutions.net>
Subject: Re: pull-request: wireless-2024-01-22
From: Johannes Berg <johannes@sipsolutions.net>
To: Jakub Kicinski <kuba@kernel.org>, Kalle Valo <kvalo@kernel.org>, Lukas
	Bulwahn <lukas.bulwahn@gmail.com>
Cc: netdev@vger.kernel.org, linux-wireless@vger.kernel.org, David Gow
 <davidgow@google.com>, Brendan Higgins <brendanhiggins@google.com>, Shuah
 Khan <skhan@linuxfoundation.org>, linux-kselftest@vger.kernel.org, 
 kunit-dev@googlegroups.com
Date: Tue, 23 Jan 2024 19:19:35 +0100
In-Reply-To: <20240123084504.1de9b8ac@kernel.org>
References: <20240122153434.E0254C433C7@smtp.kernel.org>
	 <20240123084504.1de9b8ac@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.3 (3.50.3-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

On Tue, 2024-01-23 at 08:45 -0800, Jakub Kicinski wrote:
> On Mon, 22 Jan 2024 15:34:34 +0000 (UTC) Kalle Valo wrote:
> > Lukas Bulwahn (1):
> >       wifi: cfg80211/mac80211: remove dependency on non-existing option
>=20
> BTW we run all kernel's kunit tests on netdev periodically by doing:
>=20
> ./tools/testing/kunit/kunit.py run --all
>=20
> and AFAICT the WiFi tests don't pop up there :(
>=20
> https://netdev.bots.linux.dev/contest.html?branch=3Dnet-next-2024-01-23--=
15-00&executor=3Dkunit
>=20
> Is that on purpose?

No, but honestly, I didn't even really know about it, which is mostly
for lack of bothering to look - because we run them in a different way
now both in upstream hostap and internally (internally we also have
another file with metadata to tie them to other bits of the whole
project that isn't interesting upstream).

Looks like that needs adjustments to the config file there, mostly? I
can see about adding that, probably not that hard, at least for
mac80211/cfg80211.

++kunit folks:

We're also adding unit tests to iwlwifi (slowly), any idea if we should
enable that here also? It _is_ now possible to build PCI stuff on kunit,
but it requires some additional config options (virt-pci etc.), not sure
that's desirable here? It doesn't need it at runtime for the tests, of
course.

johannes