Received-SPF: pass (google.com: domain of linux-wireless+bounces-2414-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <eef19795-96c1-4608-896a-4a41471be7ff@quicinc.com>
Date: Tue, 23 Jan 2024 10:45:29 -0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] wifi: ath12k: Fix issues in channel list update
Content-Language: en-US
To: Kalle Valo <kvalo@kernel.org>, Sriram R <quic_srirrama@quicinc.com>
CC: <ath12k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
References: <20240117062628.8260-1-quic_srirrama@quicinc.com>
 <170600237376.3897582.9674673785656987739.kvalo@kernel.org>
From: Jeff Johnson <quic_jjohnson@quicinc.com>
In-Reply-To: <170600237376.3897582.9674673785656987739.kvalo@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

On 1/23/2024 1:32 AM, Kalle Valo wrote:
> Sriram R <quic_srirrama@quicinc.com> wrote:
> 
>> Currently, the logic used to select the 6 GHz band is incorrect,
>> which may cause 6 GHz supported channels to not be updated properly.
>> This is because the 6 GHz max frequency supported by the driver is
>> being compared to the max frequency supported on the board. If in
>> some cases, the 6 GHz max frequency supported on the board is less
>> than the defined 6 GHz max frequency, all 6 GHz channels are disabled.
>> To address this, compare the max frequency supported by the board to
>> the defined 6 GHz minimum frequency by the driver.
>>
>> Similarly, when a dual mac card supports both 6 GHz and 5 GHz radios,
>> if the 5 GHz radio gets enumerated first before 6 GHz, the checks in
>> ath12k_mac_setup_channels_rates() can cause the 5 GHz channels which
>> were enabled earlier to get disabled when the 6 GHz channel list is
>> updated. This is because the min 6 GHz frequency defined in the driver
>> is 5945 MHz, which should be 5925 MHz since channel 2 is not considered
>> currently, but the firmware can pass 5925 MHz as the minimum.
>> Hence, update the min frequency supported by the driver to 5925 MHz.
>>
>> In addition, ensure that the channel list update to firmware updates
>> only the channels that the current radio (ar) supports rather than
>> considering the wiphy support. This would be required when multiple pdevs
>> are supported in a wiphy and they support different ranges of frequencies
>> or bands as in single wiphy support.
>>
>> Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices")
>>
>> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
>> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.1.1-00188-QCAHKSWPL_SILICONZ-1
>> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3
>>
>> Signed-off-by: Sriram R <quic_srirrama@quicinc.com>
>> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
> 
> I did because it looks odd for me that these are capitalised (could be wrong though):
> 
> s/Min/min/
> s/Max/max/
> 
> Jeff, what do you think about that the patch and my changes?
> 
Both the patch and your change LGTM
Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>