Received: by 2002:a05:7412:5112:b0:fa:6e18:a558 with SMTP id fm18csp933261rdb; Tue, 23 Jan 2024 22:29:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IH0GmFAOZTveWApIKpquw2yX/LMm5c1r4x3ObF8IzsdUJKaRZogkx/JuyRud07EdjSrZan+ X-Received: by 2002:a05:6a00:4b0c:b0:6d9:96cb:ab92 with SMTP id kq12-20020a056a004b0c00b006d996cbab92mr9078551pfb.46.1706077776544; Tue, 23 Jan 2024 22:29:36 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706077776; cv=pass; d=google.com; s=arc-20160816; b=g5qarINu8F6ok+d0aAg3oELCurGj63YVLLo0ZhS6GgZjyELXPDtRZu7ltu0uKxAtAZ wTh2de+ESWg/+WfV+iioZtNz4Cw7eCs/MeDw1wjL46ua1z3aSSOTjWzz8T/VlCgnRIl3 XMkl6QXjH2Y6b/1p+gGMiamnP5Iv/S6/y960KyvGmzlAzQZOlnZOqO15zr3rQ8+cxmLL pwQ+O8tTw6au0gC5xT2vY4lbZf8PlqctlSglY6HAnXLZDFhIQJVSLzrTBjajxxBqWEdZ sCzMCEzlxaqpOQb3t8GYRCV7isrZ8q8c1cWUxdRwUYx7NhzMPQFwu81fxPU1EJPqlUHk h9NA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=tWMan89ST+3Os9iGMy4eEXlRU4vNKV7uWisIMka8GfY=; fh=xu4GFUJGgYJaMaE+D2stAcLAP4tnQKNujRCOuytT8bA=; b=i+vZ4X0vgPNfINWMCaTxRW2LWPnohKUTi6ddoTaHsS1ruZ2ogtQjJIdqG/pXkmy0Am 7glchgvYiFFZJOL8APwuTTgbdIi8jVBHEhnHldIHMqYim3wNfJY0n8it50LeOTmnldE8 uQMhhCLn7oBGy5UWJMtJVMqsCF/shiV7s6nMsU85wb36hGxkyTItuPCwukKva/+bF68q yOZgwlnjDfbyHlOgMde+zwVaKGEntTZntfQ00PY9APvRxmSca0RIMUi+G0XwtYCpkpop 74Hzh3lxZszZONP/GfWekyVjvOxDzTCMxEE51rZL2PKUQMOXcNhM/ERmxUHYhagJDaHg PCMA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@yandex.ru header.s=mail header.b="g/sSkd/Z"; arc=pass (i=1 spf=pass spfdomain=yandex.ru dkim=pass dkdomain=yandex.ru dmarc=pass fromdomain=yandex.ru); spf=pass (google.com: domain of linux-wireless+bounces-2435-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-wireless+bounces-2435-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id n3-20020aa79843000000b006da8c929a14si13295431pfq.106.2024.01.23.22.29.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jan 2024 22:29:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-2435-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@yandex.ru header.s=mail header.b="g/sSkd/Z"; arc=pass (i=1 spf=pass spfdomain=yandex.ru dkim=pass dkdomain=yandex.ru dmarc=pass fromdomain=yandex.ru); spf=pass (google.com: domain of linux-wireless+bounces-2435-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-wireless+bounces-2435-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 32AD72829EE for ; Wed, 24 Jan 2024 06:29:36 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E5EE9F51C; Wed, 24 Jan 2024 06:29:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=yandex.ru header.i=@yandex.ru header.b="g/sSkd/Z" X-Original-To: linux-wireless@vger.kernel.org Received: from forward501a.mail.yandex.net (forward501a.mail.yandex.net [178.154.239.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2EE86F517 for ; Wed, 24 Jan 2024 06:29:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.154.239.81 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706077772; cv=none; b=F6YLXIXZtsBtjAj+hc0aF6rQTcflVDUivd1CAWW2fub3eu57EY3vW4myOboj+4oeKkv/yVgw1Oz1WBF6l+nwsDDL8utiIkki8LoS1UK/kMAnLv4r56QngBpzAPz5kQLzQEJRjHIE5E/4bx5C9xntXD8N0NVk8DeNizDbFTj9Sm0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706077772; c=relaxed/simple; bh=tWMan89ST+3Os9iGMy4eEXlRU4vNKV7uWisIMka8GfY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tgpUCO2Lh6KNYZjgl7sTYhS4dDZ+xK3tpzFn758rFPub/jvXscZzuwW7VrKrgYPznhjVPvacUgQIXJbLNMHvd5UAOxeBNwiyH2nf0qVeaTSbLOgJkInIAwXkbjxyCXTJZIcMuz8ThncQZgDcYkrHC2jbIwWR2cx9kJzRsdm2XhM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=yandex.ru; spf=pass smtp.mailfrom=yandex.ru; dkim=pass (1024-bit key) header.d=yandex.ru header.i=@yandex.ru header.b=g/sSkd/Z; arc=none smtp.client-ip=178.154.239.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=yandex.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=yandex.ru Received: from mail-nwsmtp-smtp-production-main-51.vla.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-51.vla.yp-c.yandex.net [IPv6:2a02:6b8:c0d:2a02:0:640:77d9:0]) by forward501a.mail.yandex.net (Yandex) with ESMTP id 1DF526190A; Wed, 24 Jan 2024 09:22:57 +0300 (MSK) Received: by mail-nwsmtp-smtp-production-main-51.vla.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id tMMncp5j3Gk0-QGUlPQib; Wed, 24 Jan 2024 09:22:56 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1706077376; bh=tWMan89ST+3Os9iGMy4eEXlRU4vNKV7uWisIMka8GfY=; h=In-Reply-To:To:Cc:References:From:Subject:Date:Message-ID; b=g/sSkd/Z5c4KPKLpUwv6eVAtRegZiKi3kDv91lfTtALnZWKKAq6L3cVhsZ6SJV/vQ DrR6JubekmHNFemGZoPvkDY1lfZQHziNUEjOVNG9b9gRN7fVU3ZMiGdAfOx3ZvMzjG GXjpSlv0BCY7Lb+WEzBlOwZQVEyc2qH4cTYTs8+o= Authentication-Results: mail-nwsmtp-smtp-production-main-51.vla.yp-c.yandex.net; dkim=pass header.i=@yandex.ru Message-ID: <15dff48a-730e-4771-a84d-64624ab8d34c@yandex.ru> Date: Wed, 24 Jan 2024 09:22:55 +0300 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] [v3] wifi: brcmfmac: handle possible PCIE irq handling errors Content-Language: en-US To: Bjorn Helgaas Cc: Arend van Spriel , Kalle Valo , linux-wireless@vger.kernel.org, lvc-project@linuxtesting.org References: <20240122182031.GA276974@bhelgaas> From: Dmitry Antipov Autocrypt: addr=dmantipov@yandex.ru; keydata= xsDNBGBYjL8BDAC1iFIjCNMSvYkyi04ln+5sTl5TCU9O5Ot/kaKKCstLq3TZ1zwsyeqF7S/q vBVSmkWHQaj80BlT/1m7BnFECMNV0M72+cTGfrX8edesMSzv/id+M+oe0adUeA07bBc2Rq2V YD88b1WgIkACQZVFCo+y7zXY64cZnf+NnI3jCPRfCKOFVwtj4OfkGZfcDAVAtxZCaksBpTHA tf24ay2PmV6q/QN+3IS9ZbHBs6maC1BQe6clFmpGMTvINJ032oN0Lm5ZkpNN+Xcp9393W34y v3aYT/OuT9eCbOxmjgMcXuERCMok72uqdhM8zkZlV85LRdW/Vy99u9gnu8Bm9UZrKTL94erm 0A9LSI/6BLa1Qzvgwkyd2h1r6f2MVmy71/csplvaDTAqlF/4iA4TS0icC0iXDyD+Oh3EfvgP iEc0OAnNps/SrDWUdZbJpLtxDrSl/jXEvFW7KkW5nfYoXzjfrdb89/m7o1HozGr1ArnsMhQC Uo/HlX4pPHWqEAFKJ5HEa/0AEQEAAc0kRG1pdHJ5IEFudGlwb3YgPGRtYW50aXBvdkB5YW5k ZXgucnU+wsEPBBMBCAA5FiEEgi6CDXNWvLfa6d7RtgcLSrzur7cFAmBYjL8FCQWjmoACGwMF CwkIBwIGFQgJCgsCBRYCAwEAAAoJELYHC0q87q+34CEMAKvYwHwegsKYeQokLHXeJVg/bcx9 gVBPj88G+hcI0+3VBdsEU0M521T4zKfS6i7FYWT+mLgf35wtj/kR4akAzU3VyucUqP92t0+T GTvzNiJXbb4a7uxpSvV/vExfPRG/iEKxzdnNiebSe2yS4UkxsVdwXRyH5uE0mqZbDX6Muzk8 O6h2jfzqfLSePNsxq+Sapa7CHiSQJkRiMXOHZJfXq6D+qpvnyh92hqBmrwDYZvNPmdVRIw3f mRFSKqSBq5J3pCKoEvAvJ6b0oyoVEwq7PoPgslJXwiuBzYhpubvSwPkdYD32Jk9CzKEF9z26 dPSVA9l8YJ4o023lU3tTKhSOWaZy2xwE5rYHCnBs5sSshjTYNiXflYf8pjWPbQ5So0lqxfJg 0FlMx2S8cWC7IPjfipKGof7W1DlXl1fVPs6UwCvBGkjUoSgstSZd/OcB/qIcouTmz0Pcd/jD nIFNw/ImUziCdCPRd8RNAddH/Fmx8R2h/DwipNp1DGY251gIJQVO3c7AzQRgWIzAAQwAyZj1 4kk+OmXzTpV9tkUqDGDseykicFMrEE9JTdSO7fiEE4Al86IPhITKRCrjsBdQ5QnmYXcnr3/9 i2RFI0Q7Evp0gD242jAJYgnCMXQXvWdfC55HyppWazwybDiyufW/CV3gmiiiJtUj3d8r8q6l aXMOGky37sRlv1UvjGyjwOxY6hBpB2oXdbpssqFOAgEw66zL54pazMOQ6g1fWmvQhUh0TpKj JZRGF/sib/ifBFHA/RQfAlP/jCsgnX57EOP3ALNwQqdsd5Nm1vxPqDOtKgo7e0qx3sNyk05F FR+f9px6eDbjE3dYfsicZd+aUOpa35EuOPXS0MC4b8SnTB6OW+pmEu/wNzWJ0vvvxX8afgPg lUQELheY+/bH25DnwBnWdlp45DZlz/LdancQdiRuCU77hC4fnntk2aClJh7L9Mh4J3QpBp3d h+vHyESFdWo5idUSNmWoPwLSYQ/evKynzeODU/afzOrDnUBEyyyPTknDxvBQZLv0q3vT0Uiq caL7ABEBAAHCwPwEGAEIACYWIQSCLoINc1a8t9rp3tG2BwtKvO6vtwUCYFiMwAUJBaOagAIb DAAKCRC2BwtKvO6vtwe/C/40zBwVFhiQTVJ5v9heTiIwfE68ZIKVnr+tq6+/z/wrRGNro4PZ fnqumrZtC+nD2Aj5ktNmrwlL2gTauhMT/L0tUrr287D4AHnXfZJT9fra+1NozFm7OeYkcgxh EG2TElxcnXSanQffA7Xx25423FD0dkh2Z5omMqH7cvmh45hBAO/6o9VltTe9T5/6mAqUjIaY 05v2npSKsXqavaiLt4MDutgkhFCfE5PTHWEQAjnXNd0UQeBqR7/JWS55KtwsFcPvyHblW4be 9urNPdoikGY+vF+LtIbXBgwK0qp03ivp7Ye1NcoI4n4PkGusOCD4jrzwmD18o0b31JNd2JAB hETgYXDi/9rBHry1xGnjzuEBalpEiTAehORU2bOVje0FBQ8Pz1C/lhyVW/wrHlW7uNqNGuop Pj5JUAPxMu1UKx+0KQn6HYa0bfGqstmF+d6Stj3W5VAN5J9e80MHqxg8XuXirm/6dH/mm4xc tx98MCutXbJWn55RtnVKbpIiMfBrcB8= In-Reply-To: <20240122182031.GA276974@bhelgaas> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/22/24 21:20, Bjorn Helgaas wrote: > If you have occasion to update this, possibly s/PCIE/PCI/ in the > subject, since this is generic to PCI and PCIe. OK. BTW if we're touching this anyway, shouldn't we hook into the generic device framework and switch to devm_request_threaded_irq()/devm_free_irq() as well? Dmitry