Received: by 2002:a05:7412:5112:b0:fa:6e18:a558 with SMTP id fm18csp1432811rdb; Wed, 24 Jan 2024 15:40:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IEb9jM7wENpya9LfTLWXQT6ph6XA3OPH9m26K6rVirgnGgaco2WVzl28p6euFNU4MkYYis3 X-Received: by 2002:a17:906:5fc8:b0:a2a:b932:d929 with SMTP id k8-20020a1709065fc800b00a2ab932d929mr24174ejv.90.1706139621343; Wed, 24 Jan 2024 15:40:21 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706139621; cv=pass; d=google.com; s=arc-20160816; b=EIFM3AHBr+F1fjxnlxK1WpWwqKvt5yfw5FAfR2bPfC2NG//JIehnXQA6+gAfxOhvTB psG5C3TFZgDeJjGHUMj9rAiMiyBqFw3uxRqX8yY2s4UA5YpZUf0Irt4kNjl7VwCmDXwE z9B6fBFEi4OSwPGvXeXPw8rawVPr6HrevLm46UakidjEKbAJy+OFSZF1QFRBtX74gZj8 vSVtQcxNHCMwsEMPc5m2vU9rDa95hMIzixgN31XjtRA3R97ztQ8n81kGZ8ZlKH/bZB/o zntyAbpPJy+rCZXwSksoZ2FoqqKETX3DUH+RH6DSKyeUQmRjpNuzosN/EePQt8kLNtDy VPhw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=sHxGkSarEJ6IlmdXksur6Pv2HYrbvaLZkrq/Qy3deMg=; fh=JGo68CSSuMvIiCFEOc3y2AZH3Obmz+ooWNz6ujtIcS8=; b=YtogvGXf5sxND5fzt7PMxPls2bkRvgkpLFo+8ISIrCYVtHqH0i3iuQpgHQ/lvJiHyH Zzoq3tng+9LaJGOej+anxmbSFDe3Fh2+L0/Stcy1N8A1ZdrJp6QM9rPT5lBkRFEmZgsa YIWiPqXHahkjkIIeu9TziI88iPs3Xh7p9SRG3S9cGwYOKCTgHkE7ukxn1bNd6WtcsQqW 0P60xamU2FQqf2G+trr+KL96IXkE2DK6XVrRqehQ4Gay858Ub1sq0eqBTOQbez3rxvjU 3bf0fRG6E039Pc+IukivOhtfKKyMuuFvFPKsWvLOO2EVOFJDK8Uw1Ebvkv+gJoQyJtgG 8F6w== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b="HTUeA/U0"; arc=pass (i=1 spf=pass spfdomain=quicinc.com dkim=pass dkdomain=quicinc.com dmarc=pass fromdomain=quicinc.com); spf=pass (google.com: domain of linux-wireless+bounces-2457-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-wireless+bounces-2457-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id z9-20020a170906714900b00a3153a0eed8si333941ejj.461.2024.01.24.15.40.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jan 2024 15:40:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-2457-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b="HTUeA/U0"; arc=pass (i=1 spf=pass spfdomain=quicinc.com dkim=pass dkdomain=quicinc.com dmarc=pass fromdomain=quicinc.com); spf=pass (google.com: domain of linux-wireless+bounces-2457-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-wireless+bounces-2457-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 1C0CE1F24C06 for ; Wed, 24 Jan 2024 23:40:21 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 89D3F12C532; Wed, 24 Jan 2024 23:40:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="HTUeA/U0" X-Original-To: linux-wireless@vger.kernel.org Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 408691350E0 for ; Wed, 24 Jan 2024 23:40:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706139617; cv=none; b=uc/gOwyWABbQn38a6KSTOQpiFPTKuXhItQxSVs+Ta5bPm2I38jGWKVjOTtJGCrgL8Ly7c4DK4NNH2SfOfe/ZzTG2T+4xZRJAAbSWVxa2BI2VJmT38aN7uqsFPIYav4kQ4F3DjgoA1MAeUsCBb8zMqoiD6LpU4z7/dukhWvU0Huo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706139617; c=relaxed/simple; bh=72Hpcig7gYEoODvx2hEpvgOAptqEz7vEa7fuMCEwiUU=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=Yi2YxdlWN3o+ljCne5XFSOetapyYaYiDTVc4BRvIr917aGhimXeGkBugCDraw/x13rkzp3294A1F9kNfncn8fiPYFppiL3zGR8BTqRyl3k6d0ZKZaw65Xa0ZzOBaIFqaRAWYyV1O5LN6ZzqKq9rKNah2qQzjtOc6AzaYjD2r6/Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=HTUeA/U0; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 40ONZL0B009835; Wed, 24 Jan 2024 23:40:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= qcppdkim1; bh=sHxGkSarEJ6IlmdXksur6Pv2HYrbvaLZkrq/Qy3deMg=; b=HT UeA/U0qOZ3AgQ4AX4GWHKKsaJdBOLrj9qiN2Ih/br1rrC3NGULLfGja3L00xoZjP 1OOJGWbNwrg6uTfbvr4mi8NuYV9I3bRw1BJEqZKsSzkvR67KQvy9MUn+dpJ1Tzi+ eKWE4kF4tGVj7oR7EF3k4PryoXn9Wb4MJnotfssJZ6XMiLVAtxg/bUaNu0mDkd3e g5wRtSMLIvcp2VL8YxiNrgg4eX996vgNwenUckovld8LiyTU7GFkGW4rF4gKXzNl kVmV4dbqwvMZTPi4pKYXV9zwn9dcr6DXXa6lEjXXir59jFSegyHyBqYf9XoqjeTV Okmwt8iFcVii9ok1hWVA== Received: from nalasppmta01.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3vu19ghmpm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 24 Jan 2024 23:40:11 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 40ONeAl5005909 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 24 Jan 2024 23:40:10 GMT Received: from [10.110.18.75] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Wed, 24 Jan 2024 15:40:09 -0800 Message-ID: Date: Wed, 24 Jan 2024 15:40:08 -0800 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] wifi: cfg80211: add support for link id attribute in NL80211_CMD_DEL_STATION Content-Language: en-US To: Aditya Kumar Singh , CC: References: <20240124132814.802018-1-quic_adisi@quicinc.com> <20240124132814.802018-2-quic_adisi@quicinc.com> From: Jeff Johnson In-Reply-To: <20240124132814.802018-2-quic_adisi@quicinc.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: e1W61tDO03OLZUItZkypAXcqoZjAhbIH X-Proofpoint-ORIG-GUID: e1W61tDO03OLZUItZkypAXcqoZjAhbIH X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-24_12,2024-01-24_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 malwarescore=0 clxscore=1015 mlxlogscore=677 spamscore=0 phishscore=0 lowpriorityscore=0 impostorscore=0 priorityscore=1501 bulkscore=0 suspectscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2401190000 definitions=main-2401240171 On 1/24/2024 5:28 AM, Aditya Kumar Singh wrote: > Currently whenever NL80211_CMD_DEL_STATION command is called without any > MAC address, all stations present on that interface are flushed. > However with MLO there is a need to flush the stations from a particular > link in the interface, and not from all the links associated with the MLD > interface. > > For example - 2 GHz and 5 GHz are part of an AP MLD. When 2 GHz BSS is > brought up, it sends flush command on the interface (MLD). Then eventually "it sends": can you please clarify what "it" is > 5 GHZ links comes up and that also sends the command on the same interface. "that also sends": likewise what is "that" > Now by the time 5 GHz link comes up, if any station gets connected to 2 GHz > link, it would be flushed while 5 GHz link is started which is wrong. > > Hence, add an option to pass link ID as well in the command so that if link > ID is passed, station using that passed link ID alone would be deleted > and others will not be removed. > > A subsequent patch would add logic to delete only the station using the > passed link ID. > > Signed-off-by: Aditya Kumar Singh Actual code change LGTM