Received-SPF: pass (google.com: domain of linux-wireless+bounces-2542-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <3a56c591a03a17e4ad1332b88bcd5790346cdc7c.camel@sipsolutions.net>
Subject: Re: [PATCH 2/3] wifi: mac80211: add link id argument for
 sta_flush() function
From: Johannes Berg <johannes@sipsolutions.net>
To: Aditya Kumar Singh <quic_adisi@quicinc.com>
Cc: linux-wireless@vger.kernel.org
Date: Fri, 26 Jan 2024 10:11:53 +0100
In-Reply-To: <20240125125855.827619-3-quic_adisi@quicinc.com>
References: <20240125125855.827619-1-quic_adisi@quicinc.com>
	 <20240125125855.827619-3-quic_adisi@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.3 (3.50.3-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

On Thu, 2024-01-25 at 18:28 +0530, Aditya Kumar Singh wrote:
> Whenever sta_flush() function is invoked, all sta present in that interfa=
ce

STAs

> is flushed. However, there is a requirement in case of MLO that only flus=
h

are flushed; The sentence starting here could be reworded.

> those sta who are using a given link id.

who -> which/that? They're not people :)

>  This is not possible currently.

reorder the words a bit here?

> Hence add the support for the same.

I think (and hope :) ) you can improve the commit messages ... Maybe say
"Add support for this by implementing the new cfg80211 API ..."

> Passing link id is done currently via cfg80211 op - del_station.

The mechanics of this aren't really all _that_ interesting unless
they're really complicated - we can all read the code if we care about
that part.

johannes