Received-SPF: pass (google.com: domain of linux-wireless+bounces-2547-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Kalle Valo <kvalo@kernel.org>
To: Arend Van Spriel <arend.vanspriel@broadcom.com>
Cc: Jakub Kicinski <kuba@kernel.org>,  <netdev@vger.kernel.org>,
  <linux-wireless@vger.kernel.org>
Subject: Re: pull-request: wireless-next-2024-01-25
References: <20240125104030.B6CA6C433C7@smtp.kernel.org>
	<20240125165128.7e43a1f3@kernel.org> <87r0i4zl92.fsf@kernel.org>
	<18d447cc0b8.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com>
Date: Fri, 26 Jan 2024 12:05:17 +0200
In-Reply-To: <18d447cc0b8.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com>
	(Arend Van Spriel's message of "Fri, 26 Jan 2024 07:37:23 +0100")
Message-ID: <877cjwz9ya.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

Arend Van Spriel <arend.vanspriel@broadcom.com> writes:

> On January 26, 2024 7:01:18 AM Kalle Valo <kvalo@kernel.org> wrote:
>
>> Jakub Kicinski <kuba@kernel.org> writes:
>>
>>> On Thu, 25 Jan 2024 10:40:30 +0000 (UTC) Kalle Valo wrote:
>>>> The first "new features" pull request for v6.9. We have only driver
>>>> changes this time and most of them are for Realtek drivers. Really
>>>> nice to see activity in Broadcom drivers again.
>>>
>>> minor thing for a follow up:
>>>
>>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwil.c:432:49:
>>> warning: no newline at end of file
>>
>> Oh, sorry about that. Any tips how to detect this?
>
> I thought checkpatch would signal that or is it a sparse warning.

I don't run checkpatch except for ath10k/ath11k/ath12k, too much noise.
I ended up adding this to my script:

for file in $(git ls-tree -r --name-only HEAD drivers/net/wireless/ net/wireless/ net/mac80211/); do if [ "$(tail -c 1 $file | cat -E)" != "$" ]; then echo $file: no newline at end of file; fi; done

> Anyway, I can fix it.

Thanks!

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches