Received-SPF: pass (google.com: domain of linux-wireless+bounces-2592-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <489989fe-4663-47a3-9340-6ef4f17ab735@quicinc.com>
Date: Sat, 27 Jan 2024 10:22:36 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v5 1/3] wifi: cfg80211: send link id in channel_switch ops
To: Johannes Berg <johannes@sipsolutions.net>
CC: <linux-wireless@vger.kernel.org>
References: <20240125130410.827701-1-quic_adisi@quicinc.com>
 <20240125130410.827701-2-quic_adisi@quicinc.com>
 <bc9e932fd450fb4f8e0c6a35a5ee6087d9c5b189.camel@sipsolutions.net>
Content-Language: en-US
From: Aditya Kumar Singh <quic_adisi@quicinc.com>
In-Reply-To: <bc9e932fd450fb4f8e0c6a35a5ee6087d9c5b189.camel@sipsolutions.net>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit

On 1/26/24 14:48, Johannes Berg wrote:
> On Thu, 2024-01-25 at 18:34 +0530, Aditya Kumar Singh wrote:
>> Currently, during channel switch, no link id information is passed
>> due to which channel switch is carried on deflink always.
> 
> I guess I already know what you mean, but ... that's really hard to
> parse, can you rewrite it?
> 

Sure, let me rephrase it.

>> --- a/include/net/cfg80211.h
>> +++ b/include/net/cfg80211.h
>> @@ -1531,6 +1531,8 @@ struct cfg80211_ap_update {
>>    * @punct_bitmap: Preamble puncturing bitmap. Each bit represents
>>    *	a 20 MHz channel, lowest bit corresponding to the lowest channel.
>>    *	Bit set to 1 indicates that the channel is punctured.
>> + * @link_id: defines the link on which channel switch is expected during
>> + *	     MLO. 0 is case of non-MLO.
> 
> please use a tab
> 
Oh, checkpatch did not warn me. Let me take a look still. Thanks for 
pointing it out.