Received-SPF: pass (google.com: domain of linux-wireless+bounces-2670-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Kalle Valo <kvalo@kernel.org>
To: Kang Yang <quic_kangyang@quicinc.com>
Cc: <ath12k@lists.infradead.org>,  <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v3 00/10] wifi: ath12k: P2P support for WCN7850
References: <20240122113904.8938-1-quic_kangyang@quicinc.com>
	<87cytp1nhd.fsf@kernel.org>
	<9a90fab6-18f1-4664-96f4-6795174d636f@quicinc.com>
Date: Mon, 29 Jan 2024 15:02:14 +0200
In-Reply-To: <9a90fab6-18f1-4664-96f4-6795174d636f@quicinc.com> (Kang Yang's
	message of "Fri, 26 Jan 2024 17:34:44 +0800")
Message-ID: <87sf2gwaw9.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

Kang Yang <quic_kangyang@quicinc.com> writes:

> On 1/25/2024 10:44 PM, Kalle Valo wrote:
>> Kang Yang <quic_kangyang@quicinc.com> writes:
>> 
>>> Add P2P support for WCN7850.
>>>
>>> Kang Yang (10):
>>>    wifi: ath12k: change interface combination for P2P mode
>>>    wifi: ath12k: add P2P IE in beacon template
>>>    wifi: ath12k: implement handling of P2P NoA event
>>>    wifi: ath12k: implement remain on channel for P2P mode
>>>    wifi: ath12k: change WLAN_SCAN_PARAMS_MAX_IE_LEN from 256 to 512
>>>    wifi: ath12k: allow specific mgmt frame tx while vdev is not up
>>>    wifi: ath12k: fix broken structure wmi_vdev_create_cmd
>>>    wifi: ath12k: move peer delete after vdev stop of station for WCN7850
>>>    wifi: ath12k: designating channel frequency for ROC scan
>>>    wifi: ath12k: advertise P2P dev support for WCN7850
>>>
>>> v3: rebase on new ath-tag, use ath12k_ah_to_ar() get ar(Karthikeyan).
>>> v2:
>>>      1. add Tested-on tag of QCN9274.
>>>      2. update copyright in patch #1, #2, #4 and #10.
>> I have not been able to run any p2p tests yet but during rmmod with
>> WCN7850 I now see:
>> [  136.260660] ------------[ cut here ]------------
>> [ 136.260909] UBSAN: shift-out-of-bounds in
>> drivers/net/wireless/ath/ath12k/mac.c:6005:38
>> [  136.261008] shift exponent 255 is too large for 64-bit type 'long long int'
>
>
> It seems you enable CONFIG_UBSAN, CONFIG_UBSAN_SANITIZE_ALL and other
> CONFIG_UBSAN_XXX.

Yes, I try to enable debug facilities as much as possible. They are
really good at finding issues in the code.

> I will add them to my config file and debug this warning.

Thanks.

> It's been a long time since the last update of kernel config. Can you
> share the new one if convenient?

Yeah, it is. I updated it now.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches