Received-SPF: pass (google.com: domain of linux-wireless+bounces-2693-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <7e0c33a964ad9c0b569c5363e2d5b70210154a52.camel@sipsolutions.net>
Subject: Re: [PATCH 00/15] wifi: support wider-BW OFDMA and fix puncturing
From: Johannes Berg <johannes@sipsolutions.net>
To: linux-wireless@vger.kernel.org
Date: Mon, 29 Jan 2024 19:51:59 +0100
In-Reply-To: <20240129184108.49639-17-johannes@sipsolutions.net>
References: <20240129184108.49639-17-johannes@sipsolutions.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.3 (3.50.3-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

On Mon, 2024-01-29 at 19:34 +0100, Johannes Berg wrote:
>=20
> As part of the refactoring to more clearly determine both local
> and AP mode (HT/VHT/HE/EHT) and channel configuration, this makes
> mac80211 a bit more strict:
>  - no longer accept channel switch when the mode changes
>  - no longer use e.g. VHT if the HT channel inside of it
>    occupies the wrong spot (e.g. center 40 MHz inside 80 MHz)
>  - don't use EHT with bad puncturing (punctured subchannels
>    cover subchannels that are used by HE)
>=20
> Hopefully these things won't really break anything outside of
> a handful of hostapd tests seem misconfigured (e.g
>=20

Err, sorry.

The tests that are broken are mostly because of the first bullet, and we
had fixed this by:
https://lists.infradead.org/pipermail/hostap/2023-December/042218.html
but (IMHO) the justification was bad - I'd still think it's weird to
switch off e.g. EHT completely during CSA, and certainly mac80211 makes
no attempt at tracking this and reacting to it (e.g. updating rate
control to disable EHT rates), which is why I did the change to not
accept it, and disconnect (which should lead to reconnect).

The EHT puncturing tests are broken because of the last bullet, and I
had fixed that in a patch I just sent to the list, but due to the second
bullet those tests are _still_ failing, and I'm not right now sure why.
But I think we can agree that the second and third bullet changes are
reasonable, and the tests need updating.

johannes