Received-SPF: pass (google.com: domain of linux-wireless+bounces-2751-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <6ca7d562-faeb-456b-a189-1f508ad99453@quicinc.com>
Date: Tue, 30 Jan 2024 08:25:43 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v6 1/5] wifi: cfg80211: send link id in channel_switch ops
To: Jeff Johnson <quic_jjohnson@quicinc.com>, <johannes@sipsolutions.net>
CC: <linux-wireless@vger.kernel.org>
References: <20240129052832.905113-1-quic_adisi@quicinc.com>
 <20240129052832.905113-2-quic_adisi@quicinc.com>
 <153c2f4f-8caa-4d76-9d05-a0ee443fb274@quicinc.com>
Content-Language: en-US
From: Aditya Kumar Singh <quic_adisi@quicinc.com>
In-Reply-To: <153c2f4f-8caa-4d76-9d05-a0ee443fb274@quicinc.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit

On 1/30/24 06:44, Jeff Johnson wrote:
> On 1/28/2024 9:28 PM, Aditya Kumar Singh wrote:
>> --- a/net/wireless/trace.h
>> +++ b/net/wireless/trace.h
>> @@ -2341,11 +2342,13 @@ TRACE_EVENT(rdev_channel_switch,
>>   			memcpy(__get_dynamic_array(pres_ofs),
>>   			       params->counter_offsets_presp,
>>   			       params->n_counter_offsets_presp * sizeof(u16));
>> +		__entry->link_id = params->link_id;
>>   	),
>>   	TP_printk(WIPHY_PR_FMT ", " NETDEV_PR_FMT ", " CHAN_DEF_PR_FMT
>> -		  ", block_tx: %d, count: %u, radar_required: %d",
>> +		  ", block_tx: %d, count: %u, radar_required: %d link_id: %d",
> 
> nit s/%d link_id/%d, link_id/
> 

Sure will add comma in next version.

>>   		  WIPHY_PR_ARG, NETDEV_PR_ARG, CHAN_DEF_PR_ARG,
>> -		  __entry->block_tx, __entry->count, __entry->radar_required)
>> +		  __entry->block_tx, __entry->count, __entry->radar_required,
>> +		  __entry->link_id)
>>   );
>>   
>>   TRACE_EVENT(rdev_set_qos_map,
>