Received-SPF: pass (google.com: domain of linux-wireless+bounces-2791-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <e19c796c9ffe3170e34543c95c6d74ced5b1429f.camel@sipsolutions.net>
Subject: Re: [PATCH v7 5/5] wifi: mac80211: add support to call csa_finish
 on a link
From: Johannes Berg <johannes@sipsolutions.net>
To: Aditya Kumar Singh <quic_adisi@quicinc.com>
Cc: linux-wireless@vger.kernel.org
Date: Tue, 30 Jan 2024 11:21:33 +0100
In-Reply-To: <20240130043225.942202-6-quic_adisi@quicinc.com>
References: <20240130043225.942202-1-quic_adisi@quicinc.com>
	 <20240130043225.942202-6-quic_adisi@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.3 (3.50.3-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

On Tue, 2024-01-30 at 10:02 +0530, Aditya Kumar Singh wrote:
> Currently ieee80211_csa_finish() function finalizes CSA by scheduling a
> finalizing worker using the deflink. With MLO, there is a need to do it
> on a given link basis.
>=20
> Add changes to pass link ID of the link on which CSA needs to be finalize=
d.

Why not just directly say

"Pass the link ID of ..."

To me at least it seems obvious that a commit makes changes :)

Anyway .. I'll stop nit-picking too much about your commit messages I
guess, and worst case just rephrase them later.

(I'm kind of working on this area of CSA too right now, though with a
focus on client.)

> +	/* TODO: MBSSID with MLO changes */
>  	if (vif->mbssid_tx_vif =3D=3D vif) {

Could you say (even here) more precisely what'd be needed?

>  		/* Trigger ieee80211_csa_finish() on the non-transmitting
>  		 * interfaces when channel switch is received on
> @@ -3568,7 +3579,7 @@ void ieee80211_csa_finish(struct ieee80211_vif *vif=
)
>  					 &iter->deflink.csa_finalize_work);

that still seems to use deflink there, for sure.

johannes