Received-SPF: pass (google.com: domain of linux-wireless+bounces-2806-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <a04f47b4-b3fb-4cff-b9de-b7af89f1ff98@quicinc.com>
Date: Tue, 30 Jan 2024 16:23:17 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v7 5/5] wifi: mac80211: add support to call csa_finish on
 a link
Content-Language: en-US
To: Johannes Berg <johannes@sipsolutions.net>
CC: <linux-wireless@vger.kernel.org>
References: <20240130043225.942202-1-quic_adisi@quicinc.com>
 <20240130043225.942202-6-quic_adisi@quicinc.com>
 <e19c796c9ffe3170e34543c95c6d74ced5b1429f.camel@sipsolutions.net>
From: Aditya Kumar Singh <quic_adisi@quicinc.com>
In-Reply-To: <e19c796c9ffe3170e34543c95c6d74ced5b1429f.camel@sipsolutions.net>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit

On 1/30/24 15:51, Johannes Berg wrote:
> On Tue, 2024-01-30 at 10:02 +0530, Aditya Kumar Singh wrote:
>> Currently ieee80211_csa_finish() function finalizes CSA by scheduling a
>> finalizing worker using the deflink. With MLO, there is a need to do it
>> on a given link basis.
>>
>> Add changes to pass link ID of the link on which CSA needs to be finalized.
> 
> Why not just directly say
> 
> "Pass the link ID of ..."
> 
> To me at least it seems obvious that a commit makes changes :)
> 
> Anyway .. I'll stop nit-picking too much about your commit messages I
> guess, and worst case just rephrase them later.
> 
> (I'm kind of working on this area of CSA too right now, though with a
> focus on client.)
> 
>> +	/* TODO: MBSSID with MLO changes */
>>   	if (vif->mbssid_tx_vif == vif) {
> 
> Could you say (even here) more precisely what'd be needed?
> 

We are checking right now "vif->mbssid_tx_vif == vif" for mbssid check. 
However, with MLO, one single vif can have multiple links and among 
those 1 or more could be mbssid enabled. Hence, changes are needed to 
store this mbssid related info on link basis instead of vif directly.

>>   		/* Trigger ieee80211_csa_finish() on the non-transmitting
>>   		 * interfaces when channel switch is received on

Then later where we are iterating over all interfaces, there also we 
need to handle it on link basis. Including all these would make this 
patch a lot bigger. Hence planned to address the whole MBSSID+MLO 
changes in a separate series overall.


>> @@ -3568,7 +3579,7 @@ void ieee80211_csa_finish(struct ieee80211_vif *vif)
>>   					 &iter->deflink.csa_finalize_work);
> 
> that still seems to use deflink there, for sure.
> 

Yeah since MBSSID currently would work without MLO, it is safe to use 
deflink of the non tx vaps while we are iterating.