Received: by 2002:a05:7412:d1aa:b0:fc:a2b0:25d7 with SMTP id ba42csp1228276rdb; Tue, 30 Jan 2024 11:39:51 -0800 (PST) X-Google-Smtp-Source: AGHT+IFwkviI1bIcTkdgZoOx2DS5XNVPzhDnj5Z22ryvNxpBqDyLd+CasQsLivcU4LlVXecVspet X-Received: by 2002:a19:ca1a:0:b0:510:1013:c67f with SMTP id a26-20020a19ca1a000000b005101013c67fmr307975lfg.67.1706643591649; Tue, 30 Jan 2024 11:39:51 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706643591; cv=pass; d=google.com; s=arc-20160816; b=GFLwEv4YqaCxe2XnQXUrh7Ckg1vgRjq3k/B1azTMZ60Zed/u4Q+lQFmle2Z1nc4/P3 Ff9yNalKRGM8niNxe3ybAo4iuxQOayn3zW3amFXxZYcnUWTGzBPDgL+oNn4Wxf/5DW60 M59OaV8iL88w/pijtrtilO9idBg3cE3x4VP731UfKAUmPuVGHlFy55qUuXC2suBBCrmz 18i5BLNQOOh398JVB3ZK7dhXHARXMMCEp3XUAil1DrB7QSMKryBwQQ4+3jnx3C2g5Un6 2TQp2knMJS9iAI9dHCYUfOsTfKLp6Kkt5MznXk+hvOkD3IJlf6UAwzayUq5IF646ZRcj IjrQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=oBzds0B/EJQpxf86qnK/bhlQp7r65fM7oRzat/htx1g=; fh=Z7QZOR18VUeUq8BtKPJ9hY5MV/rEksXMARQl2GLGXhM=; b=TML1Wrgtm5pSTrw2RoTFxOZFUT8yi56Hj9s798J4M9h8J2EnEtkVISyKmd4NrCU4Jl UKIs6CmbP5Y/wUEdf4pws6q2HqHMh6VkeEETciH8hGghPnAvfnSy0aw+b/t9LN+oD38c VdOJjC/T2mdFT6Y8w1+Ym7xSzd5QBRtO31uEV/yqvgqS0XidUbnYXy6oAzDB8OJp9WO/ +NcggZtjmqnP0lzVxVpP8XGZS5DYZcHmLb4BdUkkeGIA+F4A0XZjIZ1EwXZe56Dyfavz qu0ls1iGCwJ/Hdfet0TmczfoJSAlZYOHtDpZw5RVqeTHGdGBA2QtLuw121MuKDvzfgki 2/MQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=VdLwpHlv; arc=pass (i=1 spf=pass spfdomain=quicinc.com dkim=pass dkdomain=quicinc.com dmarc=pass fromdomain=quicinc.com); spf=pass (google.com: domain of linux-wireless+bounces-2853-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-wireless+bounces-2853-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com X-Forwarded-Encrypted: i=1; AJvYcCXeeCLHi203hO5r3qKGF2pcBTJ2Q8eyeELs4dhIfmZY438Ur/5LurRpqFWhg3lo/tEaWeYYWy0M6ZSgektdZWJ2StVz4Otw3xVO9n+ofQ== Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id p10-20020a170906a00a00b00a354b441113si3498579ejy.19.2024.01.30.11.39.51 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 11:39:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-2853-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=VdLwpHlv; arc=pass (i=1 spf=pass spfdomain=quicinc.com dkim=pass dkdomain=quicinc.com dmarc=pass fromdomain=quicinc.com); spf=pass (google.com: domain of linux-wireless+bounces-2853-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-wireless+bounces-2853-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 643371F21301 for ; Tue, 30 Jan 2024 19:39:51 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E174C7B3C3; Tue, 30 Jan 2024 19:39:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="VdLwpHlv" X-Original-To: linux-wireless@vger.kernel.org Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9B117B3DA for ; Tue, 30 Jan 2024 19:39:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706643584; cv=none; b=MOuof3/L39oqQoKnfT8PHZ+K+ZVGDgb5uixVqxTLP+lvBER/5z+BWuauQOLmRzWIuffWVVDzNLrLpffsiJMDDIZDiXfKhR78GqMRqFrxWbTuUQFh0reF5POTxujAq920uCqOgGDKJ0fg7u1YGPY/A68Oy3GSdiF0uhQBR1p1AE0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706643584; c=relaxed/simple; bh=2hcS4gx8xG/OzhEXLY1mY3quXYACmdiy/wlh81sYVEg=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=DD31+6PbpvYOJ0ftSloCjRoV8i7XzIiDOY5ROdaXluHUImkOh1JPjObTbGmtsnfKqbm63EONIq2hJzsUFTYqK4ovTryrZ6F1JWl/3fuVC23ri5u92zvjtN76J9mJW5sLGkr5VXmEF8AWt76bGFzBEnyQ6KduygsZvQdtYyNEV7M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=VdLwpHlv; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 40UJUI5X010226; Tue, 30 Jan 2024 19:39:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= qcppdkim1; bh=oBzds0B/EJQpxf86qnK/bhlQp7r65fM7oRzat/htx1g=; b=Vd LwpHlvB5JqJVaPXVdxJegfLyOGeRNfuFJNXyXeRoBRTzjviPM2+OMR+GwM8km6E8 pA+zBvHDaOf2MLDddCxMU0/i+dvCBliDK25pGxINLf9p6RrfLyi9Zw1v8oEX+2N7 o81JAakPwLFLR5ka020agEo0GT4b2e4TmMUZK41NEcGn5WxMDWJgFNNcrcM16Bl1 p6K1frFBVN6bjgqVm1PDT76uSrrqRp+Vn8xv7ZRqT2LRe6E5ceKWVmhvitwtdAvj LlS+le9R6ksM8l2urplp+2GvVhni08HlBrVlB8OHOq1fWFyqRjnnro68bffvGXnR ra/E47/B9HV08P7KPe6A== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3vxvve1nmb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 30 Jan 2024 19:39:39 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 40UJdcKP020411 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 30 Jan 2024 19:39:38 GMT Received: from [10.110.47.232] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Tue, 30 Jan 2024 11:39:37 -0800 Message-ID: Date: Tue, 30 Jan 2024 11:39:37 -0800 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] wifi: ath12k: Refactor hardware recovery synchronous Content-Language: en-US To: Karthikeyan Periyasamy , CC: References: <20240130060838.3895599-1-quic_periyasa@quicinc.com> <20240130060838.3895599-3-quic_periyasa@quicinc.com> From: Jeff Johnson In-Reply-To: <20240130060838.3895599-3-quic_periyasa@quicinc.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: -_WbOUSLNxTpzWgyiJQiQEWK9LihAuPU X-Proofpoint-ORIG-GUID: -_WbOUSLNxTpzWgyiJQiQEWK9LihAuPU X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-30_09,2024-01-30_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0 suspectscore=0 priorityscore=1501 impostorscore=0 mlxscore=0 lowpriorityscore=0 phishscore=0 bulkscore=0 adultscore=0 malwarescore=0 mlxlogscore=300 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2401190000 definitions=main-2401300146 On 1/29/2024 10:08 PM, Karthikeyan Periyasamy wrote: > Currently, in multi wiphy models, radio/link level synchronization is > sufficient for MAC hardware (ieee80211_hw) reconfigure/recovery procedures > since each radio/link is exposed as a MAC hardware (ieee80211_hw). However, > in single wiphy models, multiple radio/links is exposed as a MAC hardware > (ieee80211_hw) through the driver hardware abstraction (ath12k_hw) layer. > In such scenario, we need synchronization between the reconfigure/recovery > callback operations (i.e., ath12k_core_post_reconfigure_recovery(), > ieee80211_ops->start(), ieee80211_ops->reconfig_complete(), > ieee80211_ops->stop()) at the driver hardware abstraction (ath12k_hw) layer > instead of radio/link (ath12k) layer. Therefore, introduce a new mutex in > the ath12k_hw layer. This approach ensures compatibility of the hardware > recovery procedure with both multi wiphy models and future single wiphy > models. > > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 > > Signed-off-by: Karthikeyan Periyasamy Acked-by: Jeff Johnson