Received-SPF: pass (google.com: domain of linux-wireless+bounces-2930-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Kalle Valo <kvalo@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@toke.dk>,  Arend van
 Spriel
 <aspriel@gmail.com>,  Franky Lin <franky.lin@broadcom.com>,  Hante
 Meuleman <hante.meuleman@broadcom.com>,  Andy Shevchenko
 <andriy.shevchenko@linux.intel.com>,  Arnd Bergmann <arnd@arndb.de>,  Lee
 Jones <lee@kernel.org>,  Brian Norris <briannorris@chromium.org>,
  Srinivasan Raju <srini.raju@purelifi.com>,
  linux-wireless@vger.kernel.org,  linux-kernel@vger.kernel.org,
  brcm80211-dev-list.pdl@broadcom.com
Subject: Re: [PATCH 6/6] wifi: cw1200: Convert to GPIO descriptors
References: <20240131-descriptors-wireless-v1-0-e1c7c5d68746@linaro.org>
	<20240131-descriptors-wireless-v1-6-e1c7c5d68746@linaro.org>
Date: Thu, 01 Feb 2024 12:02:56 +0200
In-Reply-To: <20240131-descriptors-wireless-v1-6-e1c7c5d68746@linaro.org>
	(Linus Walleij's message of "Wed, 31 Jan 2024 23:37:25 +0100")
Message-ID: <87h6isv6wf.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

Linus Walleij <linus.walleij@linaro.org> writes:

> The CW1200 uses two GPIOs to control the powerup and reset
> pins, get these from GPIO descriptors instead of being passed
> as platform data from boardfiles.
>
> The RESET line will need to be marked as active low as we will
> let gpiolib handle the polarity inversion.
>
> The SDIO case is a bit special since the "card" need to be
> powered up before it gets detected on the SDIO bus and
> properly probed. Fix this by using board-specific GPIOs
> assigned to device "NULL".
>
> There are currently no in-tree users.
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

[...]

> +/* Like the rest of the driver, this only supports one device per system */
> +static struct gpio_desc *cw1200_reset;
> +static struct gpio_desc *cw1200_powerup;

Side comment about cw1200 driver: it's pretty bad that the driver
supports only one device per system. As I haven't seen any real activity
for this driver a long time I thinking of just removing it in the near
future.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches