Received-SPF: pass (google.com: domain of linux-wireless+bounces-2974-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <34028bfa3550f36f9c03c507caf1570f12ae5674.camel@sipsolutions.net>
Subject: Re: [PATCH] wifi: mac80211: trace SMPS requests from driver
From: Johannes Berg <johannes@sipsolutions.net>
To: Jeff Johnson <quic_jjohnson@quicinc.com>, linux-wireless@vger.kernel.org
Date: Thu, 01 Feb 2024 19:33:26 +0100
In-Reply-To: <acffd9a8-062a-4deb-a996-03fd71d3e357@quicinc.com>
References: 
	<20240129195435.b20d2ead2013.I8213e65c274451d523a3397519ac578c3ed2df4d@changeid>
	 <acffd9a8-062a-4deb-a996-03fd71d3e357@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.3 (3.50.3-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

On Thu, 2024-02-01 at 10:21 -0800, Jeff Johnson wrote:
>=20
> > +
> > +	TP_fast_assign(
> > +		LOCAL_ASSIGN;
> > +		VIF_ASSIGN;
> > +		__entry->link_id =3D
> > +			ieee80211_vif_is_mld(&sdata->vif) ? link->link_id : -1;
>=20
> why go to this trouble?
> why not just print the link_id that was passed into
> ieee80211_request_smps()? just so non-MLD will give -1 instead of 0?
> seems all of the other existing trace functions just print the link_id
> that was provided

Yeah, good point, we should anyway know from the context whether it's
MLO or not.

Didn't really think about it, tbh.

johannes