Received-SPF: pass (google.com: domain of linux-wireless+bounces-3009-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Lingbo Kong <lingbok@qti.qualcomm.com>
To: Kalle Valo <kvalo@kernel.org>,
        "Lingbo Kong (QUIC)"
	<quic_lingbok@quicinc.com>
CC: "ath12k@lists.infradead.org" <ath12k@lists.infradead.org>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        "Ramasamy
 Kaliappan (QUIC)" <quic_rkaliapp@quicinc.com>
Subject: RE: [PATCH v3] wifi: ath12k: report tx bitrate for iw dev xxx station
 dump
Thread-Topic: [PATCH v3] wifi: ath12k: report tx bitrate for iw dev xxx
 station dump
Thread-Index: AQHaNwljeY+TzF/lSE+tLUqyemzbCLDUkEhegCKUWfA=
Date: Fri, 2 Feb 2024 11:20:43 +0000
Message-ID: 
 <IA1PR02MB90432E82A9842EAA47A7B87498422@IA1PR02MB9043.namprd02.prod.outlook.com>
References: <20231225080723.9518-1-quic_lingbok@quicinc.com>
 <877ckgazt2.fsf@kernel.org>
In-Reply-To: <877ckgazt2.fsf@kernel.org>
Accept-Language: zh-CN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?cNZq5P7mXud4yoqHYzzt0WBjS9+cM4Voie3IX8522l4eVAyMPQn9b5jsYzyI?=
 =?us-ascii?Q?2gqr8moLHTUraGloXoZusS6XGNumq4J3c5pnTUFCi0UO8zRu4MeHOZe6qJhY?=
 =?us-ascii?Q?zhOGgqCQBbsiCMm9YGzDuKWUJcBffyeBHbmWcZYK2wFLvrH7wIHKKgHYsozE?=
 =?us-ascii?Q?jYwpYwc6ozapJ3OuD9zb2DIpE8I9VtnJgTVXjuy1CaI9FDkhAqM07fiP3rLy?=
 =?us-ascii?Q?3CJe9nQ2puBMlFFqO29cJi84sM3ki7tlwu7OgIOXNm4I6G81RZxp2mWsavcs?=
 =?us-ascii?Q?t/R14oKI0plOm7ypz+4nJ2hjohJObQgAeqvJb5X7Hn02nRpkzFyv7KFCAtbK?=
 =?us-ascii?Q?onqIgqfyJO5tqDmAcPe1WpKJ7IKRWEW63JSVbSwS3Q1tnvcAkNtxoUnlOMeL?=
 =?us-ascii?Q?TJ+WxzcCT4JFakS4QClvhFk7KGSf4BilZrZ/yP+1NukXu+BIQtnFqA+mXU1O?=
 =?us-ascii?Q?xO2j6y3rS4kfzM/TCDpJD4bRB/UTMwEKY9d0Az2ZJJtyZ7wINblV75N0YEW2?=
 =?us-ascii?Q?3aHxQiCcQGtiNknCtwMgVhE1kMsm05z05riQdZOKfYvhGeEIOOQTeSOaCoUi?=
 =?us-ascii?Q?+tmCxNdQ3tw/I4p7hNFILns8xMTMC24nQgrfI9Er+Tc9815qKdJmYlA9GxEj?=
 =?us-ascii?Q?AJog+g09sAaCyZyvr/SwNojXd1fgRQcc/Q8WoUDLDj/s4fqyA4oRMj7BMD1w?=
 =?us-ascii?Q?6uVblyJoZ5WJ972tRcllZUx2zS04Ay/8pQxS2H9UCVobt0vf1qtDV+rwAdhB?=
 =?us-ascii?Q?Y4ElFB8nnguXEhjB7yt++j5+pqUZvjko85ApIfuTQsa6YK0IeVJikaLC0MyB?=
 =?us-ascii?Q?bxQ3Rwp8xPWmblRglmbosF5Jk54KO59DmHorYxkiQlHBgTFPHG4t1fgs8YMS?=
 =?us-ascii?Q?+0sJ1lK012143re1HdQvJB7SF4ctFlTa3iyoIBPLy2BvkkKk2y1LOKvnsoAD?=
 =?us-ascii?Q?RbjBlzarkPTMd38S/yWJb9oWhbqITuNDZKIKvXTHmu2ZG+IyeIuwG4ZfKRF9?=
 =?us-ascii?Q?BlHS1j82oUVX2uKzbE6HpTp4AmYuYvnOZaefYPon8TuGHA+Cmovuo/cinHSM?=
 =?us-ascii?Q?RCK9PpgvTjt38S8L5k1iS0Jp2QALF7mOqxbJT9YGkgrzBm2GRger7VUN0SiJ?=
 =?us-ascii?Q?cACpbYu4yHTHFMTMgXN3Mqo9BEGJ2/7bf/QZGwwS2eKewgzhOI8dEZkVa6ZT?=
 =?us-ascii?Q?EHKt/pn+kNN/ypGGtY9Av5m7gAzJqg+FKJedBdoVIrM7AjfCydIrjBPdFTcb?=
 =?us-ascii?Q?hd2sjzBBF5++puvr/Zvo/nWuOLIxQN2zL3oKq0oke7yBCI7qNYmXsXnpRwHg?=
 =?us-ascii?Q?tOUjwDyVQF02oRPBr9joWemA3wB9MNAXiNqoUvathirygMCLlPCiEOdM/YZd?=
 =?us-ascii?Q?59PtIlYynHVXA3RzakLCKMs4eq/Oxna5OhT6QojF5xOIaNG4tR67MPORomjs?=
 =?us-ascii?Q?jw6UnKyMJfh0Ji2RCfChC0twUjv4FS2TqtRa1b+BKfU/8feJ/IiWLobrjHXQ?=
 =?us-ascii?Q?SAG84QapDp8q2IXH/x0anuRt8oPcUYHJbvbJauHdCpW2iyHGhUe5rjrC6QvI?=
 =?us-ascii?Q?siBUFSjT5Hi09BFWFpYaANFDtIMpO+4yoQjaulbv?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-wireless@vger.kernel.org
List-Id: <linux-wireless.vger.kernel.org>
List-Subscribe: <mailto:linux-wireless+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-wireless+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	MKmI+6l+vEYivxT9cIoXTcRlj7PuFLVbUu8Xkzb1t6MvptwyVf0lnsg/G6hDJZvWUvmt/vMC/1lf+FBmzrM/L7B7eo4UCJNiALDlbbmjnc/AUHXmOk1WsbLdfRjYGZhkjOuG8onQXdI32GOxGKujuc2ojjTyTmlC5LExCC0USXvacdf74V8zQfmW0qKJDI4LzH7TcgYZaaa8i8rnfxrKsRtIqJ1Em1o7M9BU8bRaNn4WYVGWaNzHIw7wYXtsHHAmfHbkpSH48pF3zJuGihnjWUlhKshCRmAVnjhKEK21ojYVTZAFzTiPY3i5SdkKnzBFr1/lSultjqiPhkgbTS0XxTXzNK42TEVqOLv3V34HQO2GZFwxmdUhCoI2kqgIl2s3fPGeBsdCof5ErTluq4V93zMNsaPQvvzpT+NhTgTafs/DOyOACqZXrgsTC1AolKKIWUmMKTGl3dceF2qXPP5zQjBrEamMpzU5vAOpshL4Oc3nAjMs3wCekTohVQ5sNYyZUc8OPvQ0PwBz7848CpEpx80rzf5qGEaJF7NtyVFLBQ9MhgbNqhBnIi3paQjbwDqPheR70N9qgWoTWmjMIPrvUL1Iu1vyXKu06hH0lhWv6IT277ssWWUBYXC/Ram5SZl3
X-OriginatorOrg: qti.qualcomm.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: IA1PR02MB9043.namprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9c829889-63e5-4a45-f2d5-08dc23e0feec
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2024 11:20:43.5901
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 98e9ba89-e1a1-4e38-9007-8bdabc25de1d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 32Q4oVHr6GRNMs7dchLO1UcaAS4eeNc2IwgdylbO6R/wWAPHQdDTwBOSDa1felNigVm7H+SivMpoRV2jt1u+R9JpdozIcfttEq6tQ/CS7Bg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR02MB8578
X-Proofpoint-GUID: 1HoYO56-fXGTJSvyKufoWYas9Ged5-Sr
X-Proofpoint-ORIG-GUID: 1HoYO56-fXGTJSvyKufoWYas9Ged5-Sr
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-02_05,2024-01-31_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0
 lowpriorityscore=0 clxscore=1011 mlxscore=0 phishscore=0 mlxlogscore=556
 malwarescore=0 suspectscore=0 adultscore=0 priorityscore=1501 spamscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.19.0-2401310000 definitions=main-2402020082

> -----Original Message-----
> From: Kalle Valo <kvalo@kernel.org>
> Sent: Thursday, January 11, 2024 7:13 PM
> To: Lingbo Kong (QUIC) <quic_lingbok@quicinc.com>
> Cc: ath12k@lists.infradead.org; linux-wireless@vger.kernel.org
> Subject: Re: [PATCH v3] wifi: ath12k: report tx bitrate for iw dev xxx st=
ation
> dump
>=20
> WARNING: This email originated from outside of Qualcomm. Please be wary
> of any links or attachments, and do not enable macros.
>=20
> Lingbo Kong <quic_lingbok@quicinc.com> writes:
>=20
> > The tx bitrate of "iw dev xxx station dump" always show an invalid
> > value "tx bitrate: 6.0MBit/s".
> >
> > To address this issue, parse the tx complete report from firmware and
> > indicate the tx rate to mac80211.
> >
> > After that, "iw dev xxx station dump" show the correct tx bitrate such =
as:
> > tx bitrate: 104.0 MBit/s MCS 13
> > tx bitrate: 144.4 MBit/s MCS 15 short GI tx bitrate: 626.9 MBit/s
> > 80MHz HE-MCS 6 HE-NSS 2 HE-GI 0 HE-DCM 0 tx bitrate: 1921.5 MBit/s
> > 160MHz HE-MCS 9 HE-NSS 2 HE-GI 0 HE-DCM 0
> >
> > Tested-on: WCN7850 hw2.0 PCI
> > WLAN.HMT.1.0-03427-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.15378.4
> >
> > Signed-off-by: Lingbo Kong <quic_lingbok@quicinc.com>
>=20
> [...]
>=20
> > +static void ath12k_dp_tx_update(struct ath12k *ar, struct
> > +hal_tx_status *ts) {
> > +     if (!ar->ab->hw_params->single_pdev_only)
> > +             return;
>=20
> I'm not really a fan of using single_pdev_only to check for other feature=
s.
> Basically what this check implies is if we are using a mobile chipset or =
not,
> right?
>=20
> I can't test QCN9274 right now but why do we need this check? I would hop=
e
> that the firmware interface is designed so that this check is not needed.
>=20

Hi kalle,
You're right, Ramasamy Kaliappan help me test this patch on QCN9274.
I'll send you a new version of this patch.

Best regards,
Lingbo Kong

> --
> https://patchwork.kernel.org/project/linux-wireless/list/
>=20
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpa=
t
> ches