Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp771836rdb; Fri, 2 Feb 2024 03:45:00 -0800 (PST) X-Google-Smtp-Source: AGHT+IFsb6LAbewpOhwbxk8A1C+HDwAWFyWz1TXNec7ZsPbu/XFz710Wnzp6NhBMfObrz5o6rZ7m X-Received: by 2002:a05:6214:1314:b0:686:acb4:e71 with SMTP id pn20-20020a056214131400b00686acb40e71mr8620541qvb.31.1706874300275; Fri, 02 Feb 2024 03:45:00 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706874300; cv=pass; d=google.com; s=arc-20160816; b=MxS295zxeXR9BxRsA5zvIEEOHApETCsAAtdgh2TDxN+NunKJTFLc2ZYbdurPY0UiSH hXu6fZOqP5p82GPEbg2E5IaxNvYxr4Tj+4EMwf0B0KhzFCS0+umJmxhbf4GHqvckn48b UZBYpBNEx5bmb/+x6u7eq+Q9gX9+vHBkDr9+k3EysIP7DJX3BxGSr6VD5F/NXuliXwQo tvLMn89ml+g4N0PgqPQNRiEtj4+bkbkSJOa88udDqa3pJuMCOqHNwwEUQj5gGBwj1hwU j/2A20/9PlF2Q0rLAkujku3RDNc1Aa03VnU09fNWHkMoZ3agEwISBmZV2jGuKpAYEYsa 5Pxw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=date:message-id:user-agent:cc:to:references:in-reply-to:from :subject:content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature; bh=GK2d7xkp+5AQ1CvoFM5La5/z8eBp6y/8ieSCqyY4iu8=; fh=NkZyP+sJ2YFMkFqi6IZbxin+vaiyxxzYs8R7EvrkdQU=; b=QLulPmFc/AGzNTZ/iyOoD+lggbnCxSEUe03bUBROB3ImGBCHa2dmpIjLeq9P3kjX8X WSLbo09UL/0j5qqo56CRIITQRkcavgh+aADf8N+XwPv6uIbnS3EFGFOtkpldsH2AhW0j l5GaBrDQOQpkX1WBeLh2ZxLEcwUEIUOqws7DVxnoIHbMT5Lgcs10sTY1V9aOmrPWKD1b Co7k+oGJwf1VT9lXmYi0RNek9p66lnch2TcXmTHXCddmlWeUOYQJGN2lAlUkZ5V2EWcl Yk1DPzabIa4BTkHmjuOWqrwAa49Ot1ZjObziwhwHdtiULVbPxCPtIHAmysqlGGHGptaj fs2g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KKiFdLxI; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-3013-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-3013-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=1; AJvYcCV8N8WQmCI0zD/e9D5GxTl/RdCEv/p17WQ2/GKQombBgNZcg/U1u6i8HXwSxnYDVNSg1ppWAqCBt0gOwDuibbQUneFOzXUyNyUpIP+Ykg== Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id x4-20020ae9e644000000b00783e1590eb2si1732479qkl.731.2024.02.02.03.45.00 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Feb 2024 03:45:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-3013-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KKiFdLxI; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-3013-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-3013-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id E1AF61C2498D for ; Fri, 2 Feb 2024 11:44:59 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C4A42651A2; Fri, 2 Feb 2024 11:41:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KKiFdLxI" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A0B88608FD for ; Fri, 2 Feb 2024 11:41:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706874117; cv=none; b=MnAwx7Pggca60mnvvydLoUykTvPZjAGLJ2KYNyfSwqVuvHFbQvcejKLjGiHaY827GDIYus7u703GGihOqIto7eTVVwwn9F7hyCm2gMd+e0tRBTjecGXEGlbrgsBNnN+HZSv2G2qdf5pmpnju14t566DKVHZMGYUgDnw0cor3BX0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706874117; c=relaxed/simple; bh=z4gO3mQEqJNFiFdLOMUsqG+yj2/Gcf/2cOR4uqD60BM=; h=Content-Type:MIME-Version:Subject:From:In-Reply-To:References:To: Cc:Message-ID:Date; b=i+2lINcDRFPq8qZzOdylJPBUi/sivzsQ7xhEEkd0oOMBrh21dO7QXB5Q0nyHTsTWJ7T3EqOOgod7nF2J4anNd7EdsHWFA/JRkflymQi4K4tYJ7YAYENRWFKU6Liz4aiHJMLuqI/IKFFWC41ULLouNGBGyaHkYXxf9Q+GFYeeeeo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KKiFdLxI; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8D29FC433F1; Fri, 2 Feb 2024 11:41:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706874117; bh=z4gO3mQEqJNFiFdLOMUsqG+yj2/Gcf/2cOR4uqD60BM=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=KKiFdLxIqUk+F0Va0NnSfqzLthXkiQgrakd22NAqiKhx2ilEJ3Doef9hMk+UzLE3P mavVexPZpQ+deNy40zkcoSBFxcSUKO/QQU/HZKSpNVhwnaSfMcNCWBZUQFWsQ7eNQY qyByZt42B+FotnIep1uWMUB0w8BKMDtHOAwpmWmla+Uxtwy1cfunRE3CFClBeo1ovv /5k39+XCpxZ4XfQByc2KBrFfHmFRhasFOaihel4bahx4KaJ5vefAYcxZPJPmPXXlca IRud+uKWsczxjXlmBx4ywaw3ytuMfbnMqcwF+ZsuWTTncoGNOVFrnGJ5QdBpisXesA 2lSFIfjLzK0cg== Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wifi: ath11k: change to move WMI_VDEV_PARAM_SET_HEMU_MODE before WMI_PEER_ASSOC_CMDID From: Kalle Valo In-Reply-To: <20240131021832.17298-1-quic_bqiang@quicinc.com> References: <20240131021832.17298-1-quic_bqiang@quicinc.com> To: Baochen Qiang Cc: , , User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <170687411452.3200018.9505739166220430603.kvalo@kernel.org> Date: Fri, 2 Feb 2024 11:41:56 +0000 (UTC) Baochen Qiang wrote: > Currently when connecting to an AP with 11AX-HE phy mode, host sends > WMI_VDEV_PARAM_SET_HEMU_MODE parameter to firmware after > WMI_PEER_ASSOC_CMDID command. This results in TXBF not working, because > firmware calculates TXBF values while handling WMI_PEER_ASSOC_CMDID, > however at that time WMI_VDEV_PARAM_SET_HEMU_MODE has not been sent yet. > See below log: > > AP sends "VHT/HE/EHT NDP Announcement" to station, and station sends > "Action no Ack" of category code HE to AP, the "Nc Index" and > "Codebook Information" are wrong: > > Issued action: > IEEE 802.11 Action No Ack, Flags: ........ > IEEE 802.11 wireless LAN > Fixed parameters > Category code: HE (30) > HE Action: HE Compressed Beamforming And CQI (0) > Total length: 152 > HE MIMO Control: 0x0004008018 > .... .... .... .... .... .... .... .... .... .000 = Nc Index: 1 Column (0) > .... .... .... .... .... .... .... ..0. .... .... = Codebook Information: 0 > > Change to send WMI_VDEV_PARAM_SET_HEMU_MODE before WMI_PEER_ASSOC_CMDID, > then firmware will calculate the TXBF values with valid parameters > instead of empty values. TXBF works well and throughput performance is > improved from 80 Mbps to 130 Mbps with this patch. > > Good action after this patch: > IEEE 802.11 Action No Ack, Flags: ........ > IEEE 802.11 wireless LAN > Fixed parameters > Category code: HE (30) > HE Action: HE Compressed Beamforming And CQI (0) > Total length: 409 > HE MIMO Control: 0x0004008219 > .... .... .... .... .... .... .... .... .... .001 = Nc Index: 2 Columns (1) > .... .... .... .... .... .... .... ..1. .... .... = Codebook Information: 1 > > This change applies to all chipsets. > > Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3.6510.23 > > Fixes: 38dfe775d0ab ("wifi: ath11k: push MU-MIMO params from hostapd to hardware") > Signed-off-by: Wen Gong > Signed-off-by: Baochen Qiang > Acked-by: Jeff Johnson > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 413e20e82ee7 wifi: ath11k: change to move WMI_VDEV_PARAM_SET_HEMU_MODE before WMI_PEER_ASSOC_CMDID -- https://patchwork.kernel.org/project/linux-wireless/patch/20240131021832.17298-1-quic_bqiang@quicinc.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches