Received-SPF: pass (google.com: domain of linux-wireless+bounces-3027-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Kalle Valo <kvalo@kernel.org>
To: Jeff Johnson <quic_jjohnson@quicinc.com>
Cc: Raj Kumar Bhagat <quic_rajkbhag@quicinc.com>,
  <ath12k@lists.infradead.org>,  <linux-wireless@vger.kernel.org>,  P
 Praneesh <quic_ppranees@quicinc.com>
Subject: Re: [PATCH v3 05/13] wifi: ath12k: Add logic to write QRTR node id
 to scratch
References: <20240129065724.2310207-1-quic_rajkbhag@quicinc.com>
	<20240129065724.2310207-6-quic_rajkbhag@quicinc.com>
	<b7a6ad2c-7f28-4758-921e-f77b56b5190e@quicinc.com>
Date: Fri, 02 Feb 2024 14:20:54 +0200
In-Reply-To: <b7a6ad2c-7f28-4758-921e-f77b56b5190e@quicinc.com> (Jeff
	Johnson's message of "Wed, 31 Jan 2024 13:06:28 -0800")
Message-ID: <87il37t5uh.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

Jeff Johnson <quic_jjohnson@quicinc.com> writes:

> On 1/28/2024 10:57 PM, Raj Kumar Bhagat wrote:
>> From: P Praneesh <quic_ppranees@quicinc.com>
>> 
>> Currently only one MHI device is registered successfully on platform
>> having two or more identical MHI devices. This is beacuse QMI service
>> runs with identical QRTR node ID. And, qrtr-lookup cannot register
>> more than one QMI service with identical node ID.
>> 
>> Hence, generate a unique QRTR instance ID from PCIe domain number and
>> bus number. QMI allows node id to be written on scratch register.
>> Add logic to write QRTR node id to the register. It is available for
>> firmware to uniquely identify an instance.
>> 
>> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.1.1-00188-QCAHKSWPL_SILICONZ-1
>> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
>> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3
>> 
>> Depends-On: wifi: ath12k: add firmware-2.bin support
>
> I would not expect this information to be part of the final commit text,
> but I suspect Kalle can remove it when it goes into the pending branch

Yes, I removed Depends-On. In the future, please add it to the cover
letter or, if there's no cover letter, after "---" line.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches