Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp840105rdb; Fri, 2 Feb 2024 05:51:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IFSeby99ijIpr+Rai+kNePyQJgVMwCIfqIcBILXk2gA1WvlKJLidI/qabq/LbKmVmtFGmTl X-Received: by 2002:a05:6402:695:b0:55f:2821:553a with SMTP id f21-20020a056402069500b0055f2821553amr3836428edy.13.1706881918820; Fri, 02 Feb 2024 05:51:58 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706881918; cv=pass; d=google.com; s=arc-20160816; b=iFbVM7TMpzYlaDqsdLlrVYsjiyvZuPM1CIV2f8N8ppjAlJ+tLbiZ5l5/w2Cew7T/uD L+cf//Ur8zdolFcoYqOAPK9aBXQ07ZNfwHzZSjoXUs9ECpBDIL9VLzgq5dWMa0jcXVIp uDc0/8S3IqDzXkIQlbpPNR5QtyrygE8E65i7NIzWHh/9lnpbNtNOS3df4Bm0k704A3tg yLLgTtzU0lH1g3NeiiqMoExiTF575xPF6ZiOYq1cnAKIoX5qb8djluIoA+Uh8/Ffyi33 8DylF+etwBqWz9jt0JSS8whFsTaTpD9vy2uddfNIaiWTp8LWguYZLpJ/R/FEK9CsT+qc IKMg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:message-id:in-reply-to:date:references:subject:cc:to :from:dkim-signature; bh=J36FDKkTwwH1zgyIYNp37sB7pVjQQSOEZjvh+EttvmM=; fh=fpjTogWJCsAgnFm+kr14d544yqpwl33Rkp622IWDbOs=; b=nLTvPKufHvWG/V1+hU2aKvoUJIqejOdrZ45s82JHtxnYKvTpyESNXjE82/EEgnm+ED 05upcij5QwrFlfaYAhfO9EsJYhFD+fS5tKUWScBT+0KiGVXjp3m+UWccUUZt0GqvXvXZ 4L9emrkDPYeiXzgy/aAS4if3e2Q9rEKAxKuyBwjoAyGeo3rXBmNAWEqmgVghL1Q96NsZ uw0hIg+d/3Y2y+fxPpI5helAR+OHn6XHbuuyCxssxicIrp/JoOdd9ohK/VUDzcYJqxND RhGLS4hfwjMczcuDXr1B0j23t0RR3PqPogVllM1u9NZMMowU1o8zsIhVVi2G0OUJEM5U k4Fg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=j1uldy5E; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-3036-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-wireless+bounces-3036-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=1; AJvYcCUOgaNyQmymY8S9iHZJ2DaBvtRKg6hkJJ7wNQWN+/iMaN2sECFXNusqQrq/0xOKG24nVGUMGIstNEp2sh2Z1mlm2+BU5TvCceKd6T4mlA== Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id ec15-20020a0564020d4f00b0055c556d12casi864575edb.73.2024.02.02.05.51.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Feb 2024 05:51:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-3036-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=j1uldy5E; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-3036-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-wireless+bounces-3036-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id CFA411F22475 for ; Fri, 2 Feb 2024 13:51:21 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5E210A48; Fri, 2 Feb 2024 13:51:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="j1uldy5E" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B00B4401 for ; Fri, 2 Feb 2024 13:51:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706881878; cv=none; b=lwGUKAyifhiv/kYR6JocEWP9VrHIoOwMnICESkiidp28Ka97b9HkpvxtGR7joOjIwbZod3foZhDWAm6Z6XzdBF2o2gyIBQdG8NsxveIxYhKdZpXVgihbimm5m01bLR5zItKAtfxQ6seydiZ0GJ8OXcERbmzHLDID7DHxIVWxNPs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706881878; c=relaxed/simple; bh=2u/xsY1L2si0J2WGbemdiniFW2LPrp7tHa/x+5LzCkQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID: MIME-Version:Content-Type; b=X3LskWxiSQ0PvCBSspikJtCc1DRQmugTaST+5MwawXffzmgIElONWAo1jHLZZJb1I2hEOHrzMGp6pEhl64gpEnvzwvfhwnQ9n7+EfG5HRvbxnhBeKx5Q0krfpGxHuZIvNCIr+ugL1IiWVbvMyIHiTmu28QvMCHcpUwjkjaSo4Lo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=j1uldy5E; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id E7C09C433F1; Fri, 2 Feb 2024 13:51:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706881877; bh=2u/xsY1L2si0J2WGbemdiniFW2LPrp7tHa/x+5LzCkQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=j1uldy5EIqxh4o46Mou0yx/SeNrZaUungBmwNQKQa+sRRm/H+O14Cze3NQALUoSY0 FXprzXPBbTIr3dbrRgJoJ6mN5o1S9NkkVQhni3KltCcdSb15jeCFbD3YDsRG6E0Gbp abgcyDpaG3HO+QaCeSXn99tV97c5dCOSCiRuizUlg4UmDaLJivV9k1tZ5C977KXAzH 7VYKWE5gmk1E54IL/g4ama3BfMqIbibQN/AKnk8xY0xqu8Lwb2Ib+LwQ/+r1/952If U4qRKEsXtm2hY50M0JsjgQUfnkigk7HmFa264O/PEUC+Vx1AhYFfeFFtWpqSr9rTXt dS4gECAAkRM/A== From: Kalle Valo To: Baochen Qiang Cc: , Subject: Re: [PATCH] wifi: ath12k: enable 802.11 power save mode in station mode References: <20240201035830.2534-1-quic_bqiang@quicinc.com> Date: Fri, 02 Feb 2024 15:51:15 +0200 In-Reply-To: <20240201035830.2534-1-quic_bqiang@quicinc.com> (Baochen Qiang's message of "Thu, 1 Feb 2024 11:58:30 +0800") Message-ID: <875xz7t1nw.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Baochen Qiang writes: > To reduce power consumption enable 802.11 power save mode in > station mode. This allows both radio and CPU to sleep more. > > Only enable the mode on WCN7850, other chips don't support it > for now. > > To test that power save mode is running, run below command and > check there is no NULL Data frame seen by a sniffer: > iw dev set power_save off > > And run below command, then check there is a NULL Data frame > in sniffer: > iw dev set power_save on > > Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0-03427-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.15378.4 > > Signed-off-by: Baochen Qiang This had simple conflicts in hw_params, please check: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=f776fd9ccb6561c4e4fdf05552a8b57a06686a90 -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches