Received-SPF: pass (google.com: domain of linux-wireless+bounces-3041-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <86e82bb7-eb30-f025-79d6-0fe739255243@quicinc.com>
Date: Fri, 2 Feb 2024 20:02:42 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH v3 05/13] wifi: ath12k: Add logic to write QRTR node id to
 scratch
Content-Language: en-US
To: Kalle Valo <kvalo@kernel.org>, Jeff Johnson <quic_jjohnson@quicinc.com>
CC: <ath12k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
        P Praneesh
	<quic_ppranees@quicinc.com>
References: <20240129065724.2310207-1-quic_rajkbhag@quicinc.com>
 <20240129065724.2310207-6-quic_rajkbhag@quicinc.com>
 <b7a6ad2c-7f28-4758-921e-f77b56b5190e@quicinc.com>
 <87il37t5uh.fsf@kernel.org>
From: Raj Kumar Bhagat <quic_rajkbhag@quicinc.com>
In-Reply-To: <87il37t5uh.fsf@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

On 2/2/2024 5:50 PM, Kalle Valo wrote:
> Jeff Johnson <quic_jjohnson@quicinc.com> writes:
> 
>> On 1/28/2024 10:57 PM, Raj Kumar Bhagat wrote:
>>> From: P Praneesh <quic_ppranees@quicinc.com>
>>>
>>> Currently only one MHI device is registered successfully on platform
>>> having two or more identical MHI devices. This is beacuse QMI service
>>> runs with identical QRTR node ID. And, qrtr-lookup cannot register
>>> more than one QMI service with identical node ID.
>>>
>>> Hence, generate a unique QRTR instance ID from PCIe domain number and
>>> bus number. QMI allows node id to be written on scratch register.
>>> Add logic to write QRTR node id to the register. It is available for
>>> firmware to uniquely identify an instance.
>>>
>>> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.1.1-00188-QCAHKSWPL_SILICONZ-1
>>> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
>>> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3
>>>
>>> Depends-On: wifi: ath12k: add firmware-2.bin support
>>
>> I would not expect this information to be part of the final commit text,
>> but I suspect Kalle can remove it when it goes into the pending branch
> 
> Yes, I removed Depends-On. In the future, please add it to the cover
> letter or, if there's no cover letter, after "---" line.
> 

Sure Kalle, would follow above for future patches.