Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp934178rdb; Fri, 2 Feb 2024 08:18:28 -0800 (PST) X-Google-Smtp-Source: AGHT+IHKS8Z3DburnGiXk5FUEbRyZZgnEnWZKzwBbmJMVgshPSzxBW/okutgJBBRx3kaVEu/iA+T X-Received: by 2002:a05:6870:46a3:b0:218:d610:2285 with SMTP id a35-20020a05687046a300b00218d6102285mr168142oap.14.1706890707987; Fri, 02 Feb 2024 08:18:27 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706890707; cv=pass; d=google.com; s=arc-20160816; b=n6uHit6dWPNJbu86k8IQq73ah0tXmb07GzeA4bTf6g0HvTH54Vbh8jKFFYaPyVPbH8 Qeh8wspbUq/jHkjP6ErWqV3ZchspTesSmlnx1VkMDpF0kG4bY3pGOM8E8/DXMHiHvHAA +S6W9FahuLztHkFbZYoI//pqdmBBlZ3x43+IhJHk0AlQRX+AZyI9fj6YMtDoM05svE1b TRfr+HD1A3f2bULc0flN4GRBkyky4lyMnEyAB5/ANDtVDk7JukhbAZ7QrYI6YcFa7d/4 Cfuc2pcREaZUVqhA3coNGVLYsCQccaAFufH17elC7fZFNckwUfBKyGFgP7IYTgvecDri w8Aw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=LHRNUu7pDShbkJyGUNApyrlhyTyc68VFxP7JxnTHaBk=; fh=BDhEuO5wC0zYCmZJegtEju3ZykgPjhGsxsUWHkUXD20=; b=CnakXLs+lXrlunHThVTaPeuIQ93aSUyg/ohKy/I7sO+rJWTcGLECHLIvb1moOCITue rK0jUQCV8SWSa95Z0TF3VjeRDDK6GNDoDY9lzEA4FmZkE03Qd1c5AxodCymwuPRwp4UX yG2VtshtnEnFwB7Kv2VLK4pm9ya7zpvLb8Eo8u5jazyk8GcATOzjFlG9DysODHq1fyIL naMsHdqpDzJ3iWlp05yQtnCGrgpRGN8eyk1Vqt5WGsbwh0T9xWDqdEepyQ+8VtfMv0xI 1Wl/xxh4y6BXX6gyRXiEmaBhMIugLBQO9c59/DkX5ouOIpFNk5789ciO/d21iAayZ1S3 Jl7w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=JK7PKQqv; arc=pass (i=1 spf=pass spfdomain=quicinc.com dkim=pass dkdomain=quicinc.com dmarc=pass fromdomain=quicinc.com); spf=pass (google.com: domain of linux-wireless+bounces-3042-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-3042-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com X-Forwarded-Encrypted: i=1; AJvYcCUTHeVBZ31ATo/u68BJr5CntA4HEJnSneYHsd9q05JmPn+TQlfVeA/hRp/z2+BQXOPq+ixtkhzaYUJwrbJM36XqWxTStmEy+jnINBD/6g== Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id y9-20020ad457c9000000b00680b0f40fb4si2310531qvx.206.2024.02.02.08.18.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Feb 2024 08:18:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-3042-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=JK7PKQqv; arc=pass (i=1 spf=pass spfdomain=quicinc.com dkim=pass dkdomain=quicinc.com dmarc=pass fromdomain=quicinc.com); spf=pass (google.com: domain of linux-wireless+bounces-3042-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-3042-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id A764F1C261CB for ; Fri, 2 Feb 2024 16:17:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id CBFE61474A1; Fri, 2 Feb 2024 16:17:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="JK7PKQqv" X-Original-To: linux-wireless@vger.kernel.org Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A3681468F3 for ; Fri, 2 Feb 2024 16:17:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706890656; cv=none; b=nXm9I3zx0gNSm4PjYyMWIi06sxOAUnPKXWvyh0f9LEJHmxDbCy85sxoD5fQB6uPasuZVaQjWsVDQKOPqtpUhuYGK5I7+Fmga2wsyHnqGQ17y1FvDJt0e80kY35DjwmF4ZTJg6aJT7+TYODKc2c8f9eox/aDdJKuHsNg8EIUeDvM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706890656; c=relaxed/simple; bh=A8qZ4zT1z7l6Gu+37Usffuf4PX6TDw+0K4FTrAYgmiY=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=p2bFQ+1BPCJPeqzXQ4AoEvu+SJpKWkQvEbf5QUymaUClsoYQvT4bSOkr28MbXranaLNiceNpaFVFxEs+UpG12GOqrCT7ygRdpdb8m37+cKAsClSJYNeQg8KgU1IRPfuaQBFryvRKLXGEtBXntduKuP7h5xUkDdxb0nswxNRLhYs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=JK7PKQqv; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 412G97IJ028971; Fri, 2 Feb 2024 16:17:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= qcppdkim1; bh=LHRNUu7pDShbkJyGUNApyrlhyTyc68VFxP7JxnTHaBk=; b=JK 7PKQqvruVExiXLW5m2mCGzpU7/QfFmta2Pubb7Sf9mfpzbHhamn5LPu7zC20h/Cn /MLq4f6W9N9cSE9a8Q738nubinx/HNX6NSxFIOdVNLdWjedEibE9dDADSSBOVYzY dj07YS7PPSAVLFQGU1oTmbbLRMLM0Ba23FkTeAQKvKrpTlkl7Xsd23Wd8d/SCsaZ eGOr2zgyCIewaEtfwG3dRJLtpeqn71Bqz/y0ZfVMlV6sdNDeQcRWKI3Fo+VcVl6z Jb9jbC0Q6jYkrIeUiALFwQ3T/WdLNmTUk/9BoDp3rQDhkK5XTBl/9jS1ztXUe312 nEkBxDr/kqWv0bnSCQGA== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3w0pwc1smu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 02 Feb 2024 16:17:10 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 412GHATn031264 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 2 Feb 2024 16:17:10 GMT Received: from [10.110.16.197] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Fri, 2 Feb 2024 08:17:09 -0800 Message-ID: Date: Fri, 2 Feb 2024 08:17:08 -0800 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] wifi: ath12k: enable 802.11 power save mode in station mode Content-Language: en-US To: Kalle Valo , Baochen Qiang CC: , References: <20240201035830.2534-1-quic_bqiang@quicinc.com> <875xz7t1nw.fsf@kernel.org> From: Jeff Johnson In-Reply-To: <875xz7t1nw.fsf@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: GsN9xeGC0mRoNRA-6J3Gh1eoRe455luE X-Proofpoint-ORIG-GUID: GsN9xeGC0mRoNRA-6J3Gh1eoRe455luE X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-02_10,2024-01-31_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=390 clxscore=1015 phishscore=0 bulkscore=0 mlxscore=0 suspectscore=0 adultscore=0 priorityscore=1501 malwarescore=0 impostorscore=0 lowpriorityscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2401310000 definitions=main-2402020117 On 2/2/2024 5:51 AM, Kalle Valo wrote: > Baochen Qiang writes: > >> To reduce power consumption enable 802.11 power save mode in >> station mode. This allows both radio and CPU to sleep more. >> >> Only enable the mode on WCN7850, other chips don't support it >> for now. >> >> To test that power save mode is running, run below command and >> check there is no NULL Data frame seen by a sniffer: >> iw dev set power_save off >> >> And run below command, then check there is a NULL Data frame >> in sniffer: >> iw dev set power_save on >> >> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0-03427-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.15378.4 >> >> Signed-off-by: Baochen Qiang > > This had simple conflicts in hw_params, please check: > > https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=f776fd9ccb6561c4e4fdf05552a8b57a06686a90 > LGTM