Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp939283rdb; Fri, 2 Feb 2024 08:27:10 -0800 (PST) X-Google-Smtp-Source: AGHT+IGacD0L43tzpXxCoWdWlN4OfS1l176QUpZ+vQAxc1hyvCI85EJLw2lMqPrqtHdf4ZuK/D+G X-Received: by 2002:a62:ae13:0:b0:6db:d040:4d05 with SMTP id q19-20020a62ae13000000b006dbd0404d05mr7989420pff.22.1706891229958; Fri, 02 Feb 2024 08:27:09 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706891229; cv=pass; d=google.com; s=arc-20160816; b=amYzA+K2vBuwNYih8bzMOg3+OCuzdL+ot+CoHaolRPIDg1L0kdlBCpnzj3yI/hO7ar z+GFBNE433oNVAqQIryBMaRYh3azSMj7gzhfzK4yzHT1dqWfPWylUm2iNVP5lO2MRiS4 1yLVnCg/eRsfFuOQFcgq9VgP6HYDHwrvI15VT+66XG4aEJHC1Jj0dYoEc79EkjOpW6Sh ghyeMJc/9EBlOGha7QHPBePl/iioymlrgPvF6XwbmNh7ErmPNSojPBqZGNCB8vPOXNlY Iaffavw/ch6GevOgxv8jun+WzV8jR3PYrcx8iCDI+3I1Boud4Os4o/ncKSkgeD7rUSHa Dy7A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=1sM4sc8t+56vSJd/5xISQ9hv9POHn/iy6DAQJ0YZmgo=; fh=sMyu8O/gM424MZuZ6RIQfAd/R9zAM0S915v8MDGB7Rw=; b=c26vHn0QBV3Ua0RgR9MzfIAv6D9Rqmj8AmRfI+94Deo/6vY66JyjhqggPA8uaGCiWu VvfdmC4iLKgdVED/Ov/1KWYwcQ/2sO5TUtyWf3uowEIKXbVSASJSZKkOC8mb6sjzBg3A UhV2WKsf0ZfVC54TLwfgTutHSCktuqAQoQyvBHjU+DwKc5i5tBorEPLD2zWCO6tbDr1b gKNi3gzMiiQkkAnCyjVMRqhBNRBIE15QZgf02QC0nFCHufEGEUBKJqVFaNnVIfWCmUdM +cRpeEbsrCmOL8W3XHblGdQvNhZ3KZl+e8SQoOHrRCvkx803kjxdWIGhy1nNtIrh8vVD DLVw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=PVaRxJnC; arc=pass (i=1 spf=pass spfdomain=quicinc.com dkim=pass dkdomain=quicinc.com dmarc=pass fromdomain=quicinc.com); spf=pass (google.com: domain of linux-wireless+bounces-3043-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-3043-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com X-Forwarded-Encrypted: i=1; AJvYcCX3xo+Rh+McztA8Y8hzRU03+iCHgYRiHSzhNP98kUiE+G9cSQytLoKzgRpUH5DI+3gDLmYUblDDVejpdMH+olwh77cJIf6LSd1/f5SElQ== Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id cw2-20020a056a00450200b006dfeb8b8043si1781288pfb.74.2024.02.02.08.27.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Feb 2024 08:27:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-3043-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=PVaRxJnC; arc=pass (i=1 spf=pass spfdomain=quicinc.com dkim=pass dkdomain=quicinc.com dmarc=pass fromdomain=quicinc.com); spf=pass (google.com: domain of linux-wireless+bounces-3043-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-3043-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 94108292432 for ; Fri, 2 Feb 2024 16:26:11 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6DC601474A2; Fri, 2 Feb 2024 16:26:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="PVaRxJnC" X-Original-To: linux-wireless@vger.kernel.org Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7A171468FF for ; Fri, 2 Feb 2024 16:26:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706891168; cv=none; b=rszDhA/cY7pFevene72QCXTUqZTgeIclvDM1H1/CbvLUjQwBdgPB4JCpcHPFXkKZVInK4s9lW8qbDF5khIVtWRm9shVuOBdSnbasXi1udhtYP3vP9fRFm4fCHurW3DzOtPmwVsjWDZgOcr2HywSie52xp3eY23PIWKXxyGWebbY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706891168; c=relaxed/simple; bh=4mMvq1R4poFbgA+MfuH6pRgSCdo1MOyFTliGMpoLfAc=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=D6qpRC920V4DQo5lQCwoSn8WnNgGtFvxHHeZC0QLGPT76syzICo08VaeN82ZxbRn+qpxblJ75Goqym0YSqntEiQmk4lBLLtF5m14Tu9hTOOwIuesBELF5MyoM6tpzi6T0KuECpK37a7bvV2h6Mn/bHpkn0aOlK5o1GU4bWn+0PE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=PVaRxJnC; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 412D4SBs003074; Fri, 2 Feb 2024 16:25:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= qcppdkim1; bh=1sM4sc8t+56vSJd/5xISQ9hv9POHn/iy6DAQJ0YZmgo=; b=PV aRxJnCnUm+7Gnp5zdm7km5IipOpYbEP3tJXHgoaylcL7cDyABQg9su0J6lu8KSJF heFptiGc2GqRbumN4zQXeeijqobI85mye8/q4YJWkH/Iv47SS8fW8uPX17bRkw30 +rnxtK9/pJZxwI6MsYYuVWvLOGlGCbMlF/cbfR5Me6835Cx27SN3X//3IHfroKXI yVtM279z4y3DHBSJOLxHu0lb4TX/smrXnEhTFTLRSRUPms05i3M8aRMI/KNNPXY2 ekOyG09WJ4a3Cjjp/n6LkHFRgvpuTOWKjRCji13Y65NY7kSbcFnCBqCeuVATKAE1 AYKhxrdqgJK/7/+0Mrjg== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3w0pu01um1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 02 Feb 2024 16:25:50 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 412GPnIt021575 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 2 Feb 2024 16:25:49 GMT Received: from [10.110.16.197] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Fri, 2 Feb 2024 08:25:49 -0800 Message-ID: Date: Fri, 2 Feb 2024 08:25:48 -0800 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 05/11] wifi: ath12k: implement handling of P2P NoA event Content-Language: en-US To: Kalle Valo , Kang Yang CC: , References: <20240130040303.370590-1-quic_kangyang@quicinc.com> <20240130040303.370590-6-quic_kangyang@quicinc.com> <871q9vt1km.fsf@kernel.org> From: Jeff Johnson In-Reply-To: <871q9vt1km.fsf@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: SKFx1-f9Tg9O7Qg2HZhNJoUbGwBsDxZW X-Proofpoint-ORIG-GUID: SKFx1-f9Tg9O7Qg2HZhNJoUbGwBsDxZW X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-02_10,2024-01-31_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 mlxscore=0 mlxlogscore=653 suspectscore=0 lowpriorityscore=0 impostorscore=0 bulkscore=0 clxscore=1015 adultscore=0 spamscore=0 priorityscore=1501 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2401310000 definitions=main-2402020119 On 2/2/2024 5:53 AM, Kalle Valo wrote: > Kang Yang writes: > >> The NoA(Notice of Absence) attribute is used by the P2P Group Owner to >> signal its absence due to power save timing, concurrent operation, or >> off-channel scanning. It is also used in the P2P Presence Request-Response >> mechanism. >> >> The NoA attribute shall be present in the P2P IE in the beacon frames >> transmitted by a P2P Group Owner when a NoA schedule is being advertised, >> or when the CTWindow is non-zero. >> >> So add support to update P2P information after P2P GO is up through >> event WMI_P2P_NOA_EVENTID, and always put it in probe resp. >> >> Create p2p.c and p2p.h for P2P related functions and definitions. >> >> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3 >> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 >> >> Signed-off-by: Kang Yang > > This patch 5 had simple conflicts in wmi.c, please check: > > https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=cbcb45c458a93d32a48b9280c13294e0853fa5dd > LGTM