Received-SPF: pass (google.com: domain of linux-wireless+bounces-3066-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Sat, 3 Feb 2024 06:13:17 +0800
From: kernel test robot <lkp@intel.com>
To: Miri Korenblit <miriam.rachel.korenblit@intel.com>
Cc: oe-kbuild-all@lists.linux.dev,
	Johannes Berg <johannes@sipsolutions.net>,
	Kalle Valo <kvalo@kernel.org>, linux-wireless@vger.kernel.org,
	Johannes Berg <johannes.berg@intel.com>,
	Gregory Greenman <gregory.greenman@intel.com>
Subject: [wireless-next:main 44/68]
 drivers/net/wireless/intel/iwlwifi/fw/regulatory.c:395:33: warning: '%s'
 directive argument is null
Message-ID: <202402030641.zUTuACYV-lkp@intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git main
head:   5932ad87828b267649d750869c89c0f1a3873477
commit: 084e0452a42b1d4ccde601cc1873a4ee9d8a4cbb [44/68] wifi: iwlwifi: read WTAS table from UEFI
config: mips-allyesconfig (https://download.01.org/0day-ci/archive/20240203/202402030641.zUTuACYV-lkp@intel.com/config)
compiler: mips-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240203/202402030641.zUTuACYV-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202402030641.zUTuACYV-lkp@intel.com/

All warnings (new ones prefixed by >>):

   In file included from drivers/net/wireless/intel/iwlwifi/fw/regulatory.c:7:
   drivers/net/wireless/intel/iwlwifi/fw/regulatory.c: In function 'iwl_is_ppag_approved':
>> drivers/net/wireless/intel/iwlwifi/fw/regulatory.c:395:33: warning: '%s' directive argument is null [-Wformat-overflow=]
     395 |                                 "System vendor '%s' is not in the approved list, disabling PPAG.\n",
         |                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net/wireless/intel/iwlwifi/iwl-debug.h:91:56: note: in definition of macro '__IWL_DEBUG_DEV'
      91 |                 __iwl_dbg(dev, level, limit, __func__, fmt, ##args);    \
         |                                                        ^~~
   drivers/net/wireless/intel/iwlwifi/iwl-debug.h:209:41: note: in expansion of macro 'IWL_DEBUG'
     209 | #define IWL_DEBUG_RADIO(p, f, a...)     IWL_DEBUG(p, IWL_DL_RADIO, f, ## a)
         |                                         ^~~~~~~~~
   drivers/net/wireless/intel/iwlwifi/fw/regulatory.c:394:17: note: in expansion of macro 'IWL_DEBUG_RADIO'
     394 |                 IWL_DEBUG_RADIO(fwrt,
         |                 ^~~~~~~~~~~~~~~
   drivers/net/wireless/intel/iwlwifi/fw/regulatory.c:395:49: note: format string is defined here
     395 |                                 "System vendor '%s' is not in the approved list, disabling PPAG.\n",
         |                                                 ^~


vim +395 drivers/net/wireless/intel/iwlwifi/fw/regulatory.c

09059c6764a887 Miri Korenblit 2024-01-31  390  
09059c6764a887 Miri Korenblit 2024-01-31  391  bool iwl_is_ppag_approved(struct iwl_fw_runtime *fwrt)
09059c6764a887 Miri Korenblit 2024-01-31  392  {
09059c6764a887 Miri Korenblit 2024-01-31  393  	if (!dmi_check_system(dmi_ppag_approved_list)) {
09059c6764a887 Miri Korenblit 2024-01-31  394  		IWL_DEBUG_RADIO(fwrt,
09059c6764a887 Miri Korenblit 2024-01-31 @395  				"System vendor '%s' is not in the approved list, disabling PPAG.\n",
09059c6764a887 Miri Korenblit 2024-01-31  396  				dmi_get_system_info(DMI_SYS_VENDOR));
09059c6764a887 Miri Korenblit 2024-01-31  397  				fwrt->ppag_flags = 0;
09059c6764a887 Miri Korenblit 2024-01-31  398  				return false;
09059c6764a887 Miri Korenblit 2024-01-31  399  	}
09059c6764a887 Miri Korenblit 2024-01-31  400  
09059c6764a887 Miri Korenblit 2024-01-31  401  	return true;
09059c6764a887 Miri Korenblit 2024-01-31  402  }
09059c6764a887 Miri Korenblit 2024-01-31  403  IWL_EXPORT_SYMBOL(iwl_is_ppag_approved);
ad5a85d8fdd346 Miri Korenblit 2024-01-31  404  

:::::: The code at line 395 was first introduced by commit
:::::: 09059c6764a8870ff7515c2d78ecbea7fbcffc23 wifi: iwlwifi: prepare for reading PPAG table from UEFI

:::::: TO: Miri Korenblit <miriam.rachel.korenblit@intel.com>
:::::: CC: Johannes Berg <johannes.berg@intel.com>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki