Received-SPF: pass (google.com: domain of linux-wireless+bounces-3121-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: Ping-Ke Shih <pkshih@realtek.com>
To: Fiona Klute <fiona.klute@gmx.de>,
        "linux-wireless@vger.kernel.org"
	<linux-wireless@vger.kernel.org>
CC: Kalle Valo <kvalo@kernel.org>, Ulf Hansson <ulf.hansson@linaro.org>,
        "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
        Pavel Machek
	<pavel@ucw.cz>,
        =?iso-8859-2?Q?Ond=F8ej_Jirman?= <megi@xff.cz>
Subject: RE: [PATCH 8/9] wifi: rtw88: Reset 8703b firmware before download
Thread-Topic: [PATCH 8/9] wifi: rtw88: Reset 8703b firmware before download
Thread-Index: AQHaVdEGm9PdtNCN9kWLwSLylHN2w7D7FCFA
Date: Mon, 5 Feb 2024 03:05:00 +0000
Message-ID: <3f625eaee20e4399b8b6ef7d2776a530@realtek.com>
References: <20240202121050.977223-1-fiona.klute@gmx.de>
 <20240202121050.977223-9-fiona.klute@gmx.de>
In-Reply-To: <20240202121050.977223-9-fiona.klute@gmx.de>
Accept-Language: en-US, zh-TW
Content-Language: zh-TW
Content-Type: text/plain; charset="iso-8859-2"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
MIME-Version: 1.0


> -----Original Message-----
> From: Fiona Klute <fiona.klute@gmx.de>
> Sent: Friday, February 2, 2024 8:11 PM
> To: linux-wireless@vger.kernel.org; Ping-Ke Shih <pkshih@realtek.com>
> Cc: Kalle Valo <kvalo@kernel.org>; Ulf Hansson <ulf.hansson@linaro.org>; =
linux-mmc@vger.kernel.org; Pavel
> Machek <pavel@ucw.cz>; Ond=F8ej Jirman <megi@xff.cz>; Fiona Klute <fiona.=
klute@gmx.de>
> Subject: [PATCH 8/9] wifi: rtw88: Reset 8703b firmware before download
>=20
> Sometimes 8703b firmware is still active from previous use when the
> driver needs to download the firmware during MAC activation. Reset it
> in that case.
>=20
> Signed-off-by: Fiona Klute <fiona.klute@gmx.de>
> ---
>  drivers/net/wireless/realtek/rtw88/mac.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>=20
> diff --git a/drivers/net/wireless/realtek/rtw88/mac.c b/drivers/net/wirel=
ess/realtek/rtw88/mac.c
> index 298663b035..b6de097e44 100644
> --- a/drivers/net/wireless/realtek/rtw88/mac.c
> +++ b/drivers/net/wireless/realtek/rtw88/mac.c
> @@ -936,6 +936,12 @@ static int __rtw_download_firmware_legacy(struct rtw=
_dev *rtwdev,
>  {
>         int ret =3D 0;
>=20
> +       /* reset firmware if still present */
> +       if (rtwdev->chip->id =3D=3D RTW_CHIP_TYPE_8703B &&
> +           rtw_read8(rtwdev, REG_MCUFW_CTRL) & BIT_RAM_DL_SEL) {

rtw_read8_mask(rtwdev, REG_MCUFW_CTRL, BIT_RAM_DL_SEL)=20

> +               rtw_write8(rtwdev, REG_MCUFW_CTRL, 0x00);
> +       }
> +
>         en_download_firmware_legacy(rtwdev, true);
>         ret =3D download_firmware_legacy(rtwdev, fw->firmware->data, fw->=
firmware->size);
>         en_download_firmware_legacy(rtwdev, false);
> --
> 2.43.0
>=20