Received-SPF: pass (google.com: domain of linux-wireless+bounces-3123-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: Kalle Valo <kvalo@kernel.org>
To: Ping-Ke Shih <pkshih@realtek.com>
Cc: "lkp@intel.com" <lkp@intel.com>,  "linux-wireless@vger.kernel.org"
 <linux-wireless@vger.kernel.org>,  "oe-kbuild-all@lists.linux.dev"
 <oe-kbuild-all@lists.linux.dev>
Subject: Re: [PATCH 3/4] wifi: rtw89: fw: parse secure section from firmware
 file
References: <20240203003251.10641-4-pkshih@realtek.com>
	<202402040350.rRpOepoU-lkp@intel.com>
	<e645b875c771216f688ae106abd5be86aff59b42.camel@realtek.com>
Date: Mon, 05 Feb 2024 08:47:04 +0200
In-Reply-To: <e645b875c771216f688ae106abd5be86aff59b42.camel@realtek.com>
	(Ping-Ke Shih's message of "Sun, 4 Feb 2024 01:31:45 +0000")
Message-ID: <87wmrjs907.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

Ping-Ke Shih <pkshih@realtek.com> writes:

> On Sun, 2024-02-04 at 03:22 +0800, kernel test robot wrote:
>> 
>>    drivers/net/wireless/realtek/rtw89/fw.c: In function 'rtw89_fw_hdr_parser_v1':
>> > > drivers/net/wireless/realtek/rtw89/fw.c:384:88: warning: format
>> > > '%lx' expects argument of type
>> > > 'long unsigned int', but argument 9 has type 'int' [-Wformat=]
>>      384 | "section[%d] type=%d len=0x%-6x mssc=%d mssc_len=%d
>> addr=%lx\n",
>>          |                                                                                      ~~
>> ^
>>          |
>> |
>>          |
>> long unsigned int
>>          |                                                                                      %x
>>      385 |                             i, section_info->type, section_info->len,
>>      386 |                             section_info->mssc, mssc_len, bin - fw);
>>          |                                                           ~~~~~~~~
>>          |                                                               |
>>          |                                                               int
>
> I looked for how to print out differences (subtraction) of points, and
> "%tx" is the desired format [1]. I corrected this by v2.
>
> [1] https://docs.kernel.org/core-api/printk-formats.html#pointer-differences

Heh, never heard of %td and %tx before. Thanks for teaching us :)

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches