Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp2267072rdb; Mon, 5 Feb 2024 00:37:28 -0800 (PST) X-Google-Smtp-Source: AGHT+IFOPTCJoCESgHkR8fjAXhm4qcyqXJ+pmMG6DalASGQCSQhYJPF9rBVLb4x0z+B9JA+lGzhS X-Received: by 2002:a17:902:7c88:b0:1d7:3229:ea5c with SMTP id y8-20020a1709027c8800b001d73229ea5cmr8172824pll.34.1707122248466; Mon, 05 Feb 2024 00:37:28 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707122248; cv=pass; d=google.com; s=arc-20160816; b=T51/utqv3Tek2wDHeYaLhQZSB1xwWboiVYwYRUQ57OrsdTxuxg2o+4H19YMexYn2eT i+5uy2gKpN2/XmL9bonmfAidv8OVZ8zj974sR5uzvVOz3JnfOqldWtNQmZ9clBbAPzLK 1l3yy3Bpz28xxsURXLoj4gNdfoaG10049A6yxTJzkwNJAOLJOlFOHSDLjon5YQZVRFDb vjJVS+MwVhGMLYaXDOZa//RdI4uBuDMXV6vVostIfddJp9X/MYmBchnCCQyYRB9MV3CV R0bOsiN53Cq6KD+exFVviwcWuNlT50uOz0fD2JgZXnjNhSv0TsUERyojcWYCU4ZbYz9y QO0w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:message-id:in-reply-to:date:references:subject:cc:to :from:dkim-signature; bh=yB1bFcwZJs+QDW5dFeb3ndApxspZUYh9atN9MyIulqQ=; fh=V8oGaR8D0W6EfuN1rRzIvCS/H/LMbukEdILbVRuaEs8=; b=y1/Z3ztJAdn1zzB5CgQgR/U4F0ZEalZ+jVD2NG2yoLThjx4SEQYHkCtFmp9CJZY8dI whQ/miHVCQzT93fdklyV+BC9v0aOMkler8trsmctTsNwjtARkAoDi7IINny9w7VZSH+U 6e53voX69NvO4g7+OeRV7zDOYktjjkppxZxgZ4kLh/Ib1KdbV5VKuwgGs6osHvvQtSlr JEOKacepqkFZ/ZDMbjiUO4Eq/YCXVilyDrxE4C39MrtpZ5ozydpGEijKkx0EqmzYDy8r CLHvvqWmUyKgsTWskepV4K7f72keWJ0DmmbJZ8Qqg03c/7vtokstk/jFex0rKyCP2SvK DKXQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=m3Hbhpsx; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-3124-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-3124-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=1; AJvYcCX/apc2HWTecG2gx9/oHBEcyEdBzfj1ZHidpWGhurHSeTVk9Fq1CYMeNz61R9NtdgpP/Kfel33hXGvYmNqmk+VwfLWn0ny+rXCQGy1PjA== Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id x9-20020a170902ec8900b001d9a58179a5si2175336plg.625.2024.02.05.00.37.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 00:37:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-3124-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=m3Hbhpsx; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-3124-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-3124-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id E8DD5286D07 for ; Mon, 5 Feb 2024 08:37:27 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1ED961170A; Mon, 5 Feb 2024 08:37:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="m3Hbhpsx" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EFD7011709 for ; Mon, 5 Feb 2024 08:37:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707122245; cv=none; b=OMUKvQQVzIke2vKvghWxHrNDFjDtzpzKnM1zYRhh9vN7M+8WqBBpYI6Z1ClX7n94sqkxW0/HpotNZG6JlZI5Grj3i9lkBMYkpIrUZcz+nBNfiqIngS/ODmvo6Uk6y/R0GJXFGE3wgsEun2qb8eIXhrk0ayVkkHjoL3sW21Qtb6Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707122245; c=relaxed/simple; bh=hK6G4oM70wwT1JwJR2gW0vwH7YkiLydC22reeLWHZuM=; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID: MIME-Version:Content-Type; b=JlTexDT8C84P576Gfa3AUnAQ3sfWnMJ3JqGpRjAo01EusM/ajpuf99AnGJ3blNAEa3d8gUFow8swIlvbPCPRouSDUKKN5D+eYYEbYn5KDbJqnfnexsE1JbnRcCXSurJ1sC/HxQridr+qlOxZxk1YbUHqfZ9ry/vWgY2VPdGf2Pk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=m3Hbhpsx; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3FFDDC433C7; Mon, 5 Feb 2024 08:37:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707122244; bh=hK6G4oM70wwT1JwJR2gW0vwH7YkiLydC22reeLWHZuM=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=m3Hbhpsx6lWAIIskYed3JtA0efoq9FZuf6aWtayWu2B4Pst+3i1sCegxfHx4V9ktX 9G2PsUG85ww6CNI4n9dEvNXs8dGdEJshjJecOy4dnZKyuivEEzh2Lg6rIcvO4uOESz qw49aq+5GXbOr+SZVIzsMo5JVBAq6WJcV8Ol2HodtCejHS6IU2lp0ZIugQM4YByC4D bd48Wwy2FSX2K3EQV6lsOUGNiQSlX7AbgYDloNaZxto0VeH4akupSYKjL9rOqo0e8c q8kH3dw/Ce8EYidgsGjHUiQFXG7Azs3s/0AdsdN6oX6YJpnCrwsSv34/c6ns12FrRc DqWWfdVEJNTbQ== From: Kalle Valo To: Cc: , , , , , , , , , , , , , , , , Subject: Re: [PATCH] Bluetooth: btusb: medaitek: fix double free of skb in coredump References: Date: Mon, 05 Feb 2024 10:37:19 +0200 In-Reply-To: (sean wang's message of "Sat, 3 Feb 2024 07:55:27 +0800") Message-ID: <871q9rb934.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain writes: > From: Sean Wang > > hci_devcd_append() would free the skb on error so the caller don't > have to free it again otherwise it would cause the double free of skb. > > Fixes: 0b7015132878 ("Bluetooth: btusb: mediatek: add MediaTek devcoredump support") > Reported-by : Dan Carpenter > Signed-off-by: Sean Wang > --- > drivers/bluetooth/btmtk.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) This should be sent to the bluetooth list. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches